refactor(query): use serviceFunctionIdentifier for operation IDs

Author: adamkasper

packages/openapi-ts/src/plugins/@tanstack/query-core/infiniteQueryOptions.ts

@@ -5,6 +5,7 @@ import { tsNodeToString } from '../../../compiler/utils';
 import { clientApi } from '../../../generate/client';
 import { operationPagination } from '../../../ir/operation';
 import type { IR } from '../../../ir/types';
+import { serviceFunctionIdentifier } from '../../@hey-api/sdk/plugin-legacy';
 import { schemaToType } from '../../@hey-api/typescript/plugin';
 import {
   createOperationComment,
@@ -313,9 +314,16 @@ export const createInfiniteQueryOptions = ({
   });
   file.add(node);
 
+  const functionName = serviceFunctionIdentifier({
+    config: plugin.context.config,
+    handleIllegal: true,
+    id: operation.id,
+    operation,
+  });
+
   const identifierInfiniteQueryKey = file.identifier({
     // TODO: refactor for better cross-plugin compatibility
-    $ref: `#/tanstack-query-infinite-query-key/${operation.id}`,
+    $ref: `#/tanstack-query-infinite-query-key/${functionName}`,
     case: plugin.config.infiniteQueryKeys.case,
     nameTransformer: plugin.config.infiniteQueryKeys.name,
     namespace: 'value',
@@ -430,7 +438,7 @@ export const createInfiniteQueryOptions = ({
 
   const identifierInfiniteQueryOptions = file.identifier({
     // TODO: refactor for better cross-plugin compatibility
-    $ref: `#/tanstack-query-infinite-query-options/${operation.id}`,
+    $ref: `#/tanstack-query-infinite-query-options/${functionName}`,
     case: plugin.config.infiniteQueryOptions.case,
     create: true,
     nameTransformer: plugin.config.infiniteQueryOptions.name,

packages/openapi-ts/src/plugins/@tanstack/query-core/mutationOptions.ts

@@ -2,6 +2,7 @@ import type ts from 'typescript';
 
 import { compiler } from '../../../compiler';
 import type { IR } from '../../../ir/types';
+import { serviceFunctionIdentifier } from '../../@hey-api/sdk/plugin-legacy';
 import { createOperationComment } from '../../shared/utils/operation';
 import type { PluginInstance, PluginState } from './types';
 import { useTypeData, useTypeError, useTypeResponse } from './useType';
@@ -101,9 +102,17 @@ export const createMutationOptions = ({
     );
   }
 
+  // Get the function name from SDK plugin instead of using operation.id directly
+  const functionName = serviceFunctionIdentifier({
+    config: plugin.context.config,
+    handleIllegal: true,
+    id: operation.id,
+    operation,
+  });
+
   const identifier = file.identifier({
     // TODO: refactor for better cross-plugin compatibility
-    $ref: `#/tanstack-query-mutation-options/${operation.id}`,
+    $ref: `#/tanstack-query-mutation-options/${functionName}`,
     case: plugin.config.mutationOptions.case,
     create: true,
     nameTransformer: plugin.config.mutationOptions.name,

packages/openapi-ts/src/plugins/@tanstack/query-core/queryKey.ts

@@ -3,6 +3,7 @@ import { clientApi } from '../../../generate/client';
 import { hasOperationDataRequired } from '../../../ir/operation';
 import type { IR } from '../../../ir/types';
 import { getClientBaseUrlKey } from '../../@hey-api/client-core/utils';
+import { serviceFunctionIdentifier } from '../../@hey-api/sdk/plugin-legacy';
 import type { PluginInstance } from './types';
 import { useTypeData } from './useType';
 
@@ -304,18 +305,27 @@ export const queryKeyStatement = ({
 }) => {
   const file = plugin.context.file({ id: plugin.name })!;
   const typeData = useTypeData({ operation, plugin });
+
+  // Get the function name from SDK plugin instead of using operation.id directly
+  const functionName = serviceFunctionIdentifier({
+    config: plugin.context.config,
+    handleIllegal: true,
+    id: operation.id,
+    operation,
+  });
+
   const identifier = isInfinite
     ? file.identifier({
         // TODO: refactor for better cross-plugin compatibility
-        $ref: `#/tanstack-query-infinite-query-key/${operation.id}`,
+        $ref: `#/tanstack-query-infinite-query-key/${functionName}`,
         case: plugin.config.infiniteQueryKeys.case,
         create: true,
         nameTransformer: plugin.config.infiniteQueryKeys.name,
         namespace: 'value',
       })
     : file.identifier({
         // TODO: refactor for better cross-plugin compatibility
-        $ref: `#/tanstack-query-query-key/${operation.id}`,
+        $ref: `#/tanstack-query-query-key/${functionName}`,
         case: plugin.config.queryKeys.case,
         create: true,
         nameTransformer: plugin.config.queryKeys.name,
@@ -333,7 +343,7 @@ export const queryKeyStatement = ({
       ],
       returnType: isInfinite ? typeQueryKey : undefined,
       statements: createQueryKeyLiteral({
-        id: operation.id,
+        id: functionName,
         isInfinite,
         plugin,
       }),

packages/openapi-ts/src/plugins/@tanstack/query-core/queryOptions.ts

@@ -2,6 +2,7 @@ import type ts from 'typescript';
 
 import { compiler } from '../../../compiler';
 import type { IR } from '../../../ir/types';
+import { serviceFunctionIdentifier } from '../../@hey-api/sdk/plugin-legacy';
 import {
   createOperationComment,
   isOperationOptionsRequired,
@@ -68,9 +69,17 @@ export const createQueryOptions = ({
 
   const typeData = useTypeData({ operation, plugin });
 
+  // Get the function name from SDK plugin instead of using operation.id directly
+  const functionName = serviceFunctionIdentifier({
+    config: plugin.context.config,
+    handleIllegal: true,
+    id: operation.id,
+    operation,
+  });
+
   const identifierQueryKey = file.identifier({
     // TODO: refactor for better cross-plugin compatibility
-    $ref: `#/tanstack-query-query-key/${operation.id}`,
+    $ref: `#/tanstack-query-query-key/${functionName}`,
     case: plugin.config.queryKeys.case,
     nameTransformer: plugin.config.queryKeys.name,
     namespace: 'value',
@@ -129,7 +138,7 @@ export const createQueryOptions = ({
 
   const identifierQueryOptions = file.identifier({
     // TODO: refactor for better cross-plugin compatibility
-    $ref: `#/tanstack-query-query-options/${operation.id}`,
+    $ref: `#/tanstack-query-query-options/${functionName}`,
     case: plugin.config.queryOptions.case,
     create: true,
     nameTransformer: plugin.config.queryOptions.name,