Fix GitHub issue report enabled by default and --interactive option not working

Co-authored-by: mrlubos <[email protected]>

Author: Copilot

packages/openapi-ts/bin/index.cjs

@@ -49,6 +49,10 @@ const params = program
     '--useOptions [value]',
     'DEPRECATED. Use options instead of arguments?',
   )
+  .option(
+    '--interactive [value]',
+    'Show an interactive error reporting tool when the program crashes? (default: false)',
+  )
   .parse(process.argv)
   .opts();
 
@@ -91,15 +95,14 @@ async function start() {
       'experimentalParser',
       'exportCore',
       'useOptions',
+      'interactive',
     ]);
 
-    const isInteractive =
-      process.stdin.isTTY &&
-      process.stdout.isTTY &&
-      !process.env.CI &&
-      !process.env.NO_INTERACTIVE &&
-      !process.env.NO_INTERACTION;
-    userConfig.interactive = isInteractive;
+    // Only set interactive automatically if not explicitly configured by user
+    // Default should be false according to documentation
+    if (userConfig.interactive === undefined) {
+      userConfig.interactive = false; // Default to false as per documentation
+    }
 
     if (params.plugins === true) {
       userConfig.plugins = [];

packages/openapi-ts/src/__tests__/error.test.ts

@@ -0,0 +1,111 @@
+import { describe, expect, it, vi } from 'vitest';
+
+import { shouldReportCrash } from '../error';
+
+describe('shouldReportCrash', () => {
+  it('should return false when isInteractive is false', async () => {
+    const result = await shouldReportCrash({
+      error: new Error('test error'),
+      isInteractive: false,
+    });
+    expect(result).toBe(false);
+  });
+
+  it('should return false when isInteractive is undefined', async () => {
+    const result = await shouldReportCrash({
+      error: new Error('test error'),
+      isInteractive: undefined,
+    });
+    expect(result).toBe(false);
+  });
+
+  it('should not prompt when isInteractive is explicitly false', async () => {
+    // Mock stdin/stdout to ensure we don't wait for user input
+    const writeSpy = vi
+      .spyOn(process.stdout, 'write')
+      .mockImplementation(() => true);
+    const setEncodingSpy = vi
+      .spyOn(process.stdin, 'setEncoding')
+      .mockImplementation(() => {});
+    const onceSpy = vi
+      .spyOn(process.stdin, 'once')
+      .mockImplementation(() => process.stdin);
+
+    const result = await shouldReportCrash({
+      error: new Error('test error'),
+      isInteractive: false,
+    });
+
+    expect(result).toBe(false);
+    expect(writeSpy).not.toHaveBeenCalled();
+    expect(setEncodingSpy).not.toHaveBeenCalled();
+    expect(onceSpy).not.toHaveBeenCalled();
+
+    writeSpy.mockRestore();
+    setEncodingSpy.mockRestore();
+    onceSpy.mockRestore();
+  });
+
+  it('should prompt when isInteractive is true', async () => {
+    // Mock stdin/stdout for interactive session
+    const writeSpy = vi
+      .spyOn(process.stdout, 'write')
+      .mockImplementation(() => true);
+    const setEncodingSpy = vi
+      .spyOn(process.stdin, 'setEncoding')
+      .mockImplementation(() => {});
+    const onceSpy = vi
+      .spyOn(process.stdin, 'once')
+      .mockImplementation((event, callback) => {
+        // Simulate user typing 'n'
+        setTimeout(() => {
+          (callback as any)('n');
+        }, 0);
+        return process.stdin;
+      });
+
+    const result = await shouldReportCrash({
+      error: new Error('test error'),
+      isInteractive: true,
+    });
+
+    expect(result).toBe(false); // User said 'n'
+    expect(writeSpy).toHaveBeenCalledWith(
+      expect.stringContaining('📢 Open a GitHub issue with crash details?'),
+    );
+
+    writeSpy.mockRestore();
+    setEncodingSpy.mockRestore();
+    onceSpy.mockRestore();
+  });
+
+  it('should handle user saying yes to crash report', async () => {
+    // Mock stdin/stdout for interactive session
+    const writeSpy = vi
+      .spyOn(process.stdout, 'write')
+      .mockImplementation(() => true);
+    const setEncodingSpy = vi
+      .spyOn(process.stdin, 'setEncoding')
+      .mockImplementation(() => {});
+    const onceSpy = vi
+      .spyOn(process.stdin, 'once')
+      .mockImplementation((event, callback) => {
+        // Simulate user typing 'y'
+        setTimeout(() => {
+          (callback as any)('y');
+        }, 0);
+        return process.stdin;
+      });
+
+    const result = await shouldReportCrash({
+      error: new Error('test error'),
+      isInteractive: true,
+    });
+
+    expect(result).toBe(true); // User said 'y'
+
+    writeSpy.mockRestore();
+    setEncodingSpy.mockRestore();
+    onceSpy.mockRestore();
+  });
+});