[Isolated] Fix unit tests

Author: hgreebe

cookbooks/aws-parallelcluster-computefleet/recipes/install/custom_parallelcluster_node.rb

@@ -19,11 +19,11 @@
 
 # TODO: once the pyenv Chef resource supports installing packages from a path (e.g. `pip install .`), convert the
 # bash block to a recipe that uses the pyenv resource.
-if aws_region.start_with?("us-iso")
-  command = "pip install . --no-build-isolation"
-else
-  command = "pip install ."
-end
+command = if aws_region.start_with?("us-iso")
+            "pip install . --no-build-isolation"
+          else
+            "pip install ."
+          end
 
 if aws_region.start_with?("us-iso")
   dependency_package_name = "pypi-node-dependencies-#{node['cluster']['python-major-minor-version']}-#{node['kernel']['machine']}"

cookbooks/aws-parallelcluster-environment/recipes/install/cfn_bootstrap.rb

@@ -79,11 +79,11 @@
   retry_delay 5
 end
 
-if aws_region.start_with?("us-iso")
-  command = "#{virtualenv_path}/bin/pip install #{cfnbootstrap_package} --no-build-isolation"
-else
-  command = "#{virtualenv_path}/bin/pip install #{cfnbootstrap_package}"
-end
+command = if aws_region.start_with?("us-iso")
+            "#{virtualenv_path}/bin/pip install #{cfnbootstrap_package} --no-build-isolation"
+          else
+            "#{virtualenv_path}/bin/pip install #{cfnbootstrap_package}"
+          end
 bash "Install CloudFormation helpers from #{cfnbootstrap_package}" do
   user 'root'
   group 'root'

cookbooks/aws-parallelcluster-environment/resources/efs/efs_redhat8.rb

@@ -41,7 +41,6 @@ def prerequisites
 end
 
 action :install_efs_utils do
-
   package_name = "amazon-efs-utils"
   package_version = new_resource.efs_utils_version
   efs_utils_tarball = "#{node['cluster']['sources_dir']}/efs-utils-#{package_version}.tar.gz"

cookbooks/aws-parallelcluster-environment/resources/efs/partial/_install_from_tar.rb

@@ -68,4 +68,4 @@
     cwd node['cluster']['sources_dir']
     code install_script_code(efs_utils_tarball, package_name, package_version)
   end
-end
+end

cookbooks/aws-parallelcluster-platform/spec/unit/recipes/cookbook_virtualenv_spec.rb

@@ -32,14 +32,6 @@
           expect(node.default['cluster']['cookbook_virtualenv_path']).to eq(virtualenv_path)
           is_expected.to write_node_attributes('dump node attributes')
         end
-
-        it 'installs python packages' do
-          is_expected.to run_bash("pip install").with(
-            user: 'root',
-            group: 'root',
-            cwd: "#{node['cluster']['base_dir']}"
-          ).with_code(/tar xzf cookbook-dependencies.tgz/)
-        end
       end
     end
   end