Add a fix to ensure we get correct behaviour when dealing with time-range computations.

Author: hhenson

hgraph/_impl/_operators/_tsw_operators.py

@@ -44,7 +44,8 @@ def min_tsw(
     ts: TSW[NUMBER, WINDOW_SIZE, WINDOW_SIZE_MIN], default_value: TS[NUMBER] = None, _tp: type[NUMBER] = AUTO_RESOLVE
 ) -> TS[NUMBER]:
     default = default_value.value if default_value.valid else None
-    value = min(ts.value, default=default)
+    values = ts.value if ts.value is not None else ()
+    value = min(values, default=default)
     return _tp(value) if value is not None else None
 
 
@@ -53,5 +54,6 @@ def max_tsw(
     ts: TSW[NUMBER, WINDOW_SIZE, WINDOW_SIZE_MIN], default_value: TS[NUMBER] = None, _tp: type[NUMBER] = AUTO_RESOLVE
 ) -> TS[NUMBER]:
     default = default_value.value if default_value.valid else None
-    value = max(ts.value, default=default)
+    values = ts.value if ts.value is not None else ()
+    value = max(values, default=default)
     return _tp(value) if value is not None else None

hgraph_unit_tests/_operators/test_tsw_operators.py

@@ -1,4 +1,5 @@
 from hgraph import graph, TS, sum_, to_window, abs_, TSW, mean, min_, max_
+from hgraph._runtime._constants import MIN_TD
 from hgraph.test import eval_node
 
 import pytest
@@ -38,9 +39,18 @@ def test_tsw_min():
     @graph
     def g(ts: TS[int]) -> TS[int]:
         window = to_window(ts, 3, 3)
-        return min_(window)
+        return min_(window, default_value=0)
 
-    assert eval_node(g, [1, -2, 3, 4]) == [None, None, -2, -2]
+    assert eval_node(g, [None, 1, -2, 3, 4]) == [None, None, None, -2, -2]
+
+
+def test_tsw_min_time_period_with_default():
+    @graph
+    def g(ts: TS[int]) -> TS[int]:
+        window = to_window(ts, MIN_TD * 2)
+        return min_(window, default_value=99)
+
+    assert eval_node(g, [1, 2, 3, 4]) == [99, 99, 1, 2]
 
 
 def test_tsw_max():
@@ -50,3 +60,12 @@ def g(ts: TS[int]) -> TS[int]:
         return max_(window)
 
     assert eval_node(g, [1, -2, 3, 4]) == [None, None, 3, 4]
+
+
+def test_tsw_max_time_period_with_default():
+    @graph
+    def g(ts: TS[int]) -> TS[int]:
+        window = to_window(ts, MIN_TD * 2)
+        return max_(window, default_value=99)
+
+    assert eval_node(g, [1, 2, 3, 4]) == [99, 99, 3, 4]