Skip to content
This repository was archived by the owner on Aug 25, 2025. It is now read-only.

Commit a0e4ed9

Browse files
committed
Make travis.sh use /bin/bash instead of /bin/sh
`foo/{file1,file2}.php` is a bashism. Also add comment explaining why we're doing both that and regen'ing + diffing
1 parent 609ddb1 commit a0e4ed9

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

.travis.sh

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
#!/bin/sh
1+
#!/bin/bash
22
set -ex
33
apt update -y
44
DEBIAN_FRONTEND=noninteractive apt install -y php-cli zip unzip
@@ -21,8 +21,11 @@ if !(hhvm --version | grep -q -- -dev); then
2121
vendor/bin/hhast-lint
2222
fi
2323

24+
# Check the codegen hasn't been modified; this is also done as part of the next
25+
# step, but we want to make sure the verify-signatures executable works
2426
bin/hh-codegen-verify-signatures \
2527
examples/dorm/demo/{DormUser.php,DormUserMutator.php}
28+
# Check that they're up-to-date
2629
hhvm examples/dorm/codegen.hack examples/dorm/demo/DormUserSchema.php
2730
if ! git diff --exit-code examples/; then
2831
echo "Demo codegen not up to date."

0 commit comments

Comments
 (0)