Update forward compatibility level, fix lint warnings

Author: kmeht

.hhconfig

@@ -10,4 +10,4 @@ enable_experimental_tc_features=shape_field_check,sealed_classes
 # - otherwise, we get a circular dependency
 # - we don't use anything other than executables from it
 ignored_paths = [ "vendor/.+/tests/.+", "vendor/hhvm/hhast/.+" ]
-forward_compatibility_level=20180704
+forward_compatibility_level=3.28

examples/dorm/CodegenDorm.php

@@ -91,7 +91,7 @@ private function getLoad(): CodegenMethod {
     $body = $this->codegen->codegenHackBuilder()
       ->addLinef('$conn = new PDO(\'%s\');', $this->schema->getDsn())
       ->add('$cursor = ')
-      ->addMultilineCall('$conn->query', Vector {"\"$sql\""}, true)
+      ->addMultilineCall('$conn->query', Vector {"\"".$sql."\""}, true)
       ->addLine('$result = $cursor->fetch(PDO::FETCH_ASSOC);')
       ->startIfBlock('!$result')
       ->addReturnf('null')

examples/dorm/codegen.php

@@ -1,4 +1,4 @@
-<?hh
+<?hh // strict
 /*
  *  Copyright (c) 2015-present, Facebook, Inc.
  *  All rights reserved.
@@ -12,13 +12,13 @@
 
 require_once(__DIR__.'/../../vendor/hh_autoload.php');
 
-if ($argc == 1) {
+if ($argc === 1) {
   echo "  Usage: ".$argv[0]." file_name.php\n\n";
   exit(1);
 }
 $fname = $argv[1];
 if (!file_exists($fname)) {
-  echo "  File doesn't exist: $fname\n\n";
+  echo "  File doesn't exist: ".$fname."\n\n";
   exit(1);
 }
 
@@ -36,7 +36,7 @@
   if (!$instance instanceof DormSchema) {
     continue;
   }
-  echo "Generating code for $class_name\n";
+  echo "Generating code for ".$class_name."\n";
   (new CodegenDorm($instance))->generate();
   (new CodegenMutator($instance))->generate();
 }

examples/dorm/demo/demo_usage.php

@@ -1,4 +1,4 @@
-<?hh
+<?hh // strict
 /*
  *  Copyright (c) 2015-present, Facebook, Inc.
  *  All rights reserved.
@@ -40,7 +40,7 @@
  ->setIsActive(true)
  ->save();
 
-echo "Created user with id $id\n";
+echo "Created user with id ".$id."\n";
 
 $user = DormUser::load($id);
 echo "Loaded: ".$user->getFirstName()." ".$user->getLastName()."\n";

src/CodegenClassBase.php

@@ -269,7 +269,7 @@ protected function buildGenericsDeclaration(): string {
       return '';
     }
 
-    if ($generics_count == 1) {
+    if ($generics_count === 1) {
       return '<'.C\onlyx($this->genericsDecl).'>';
     }
 

src/CodegenFactoryTrait.php

@@ -119,7 +119,7 @@ final public function codegenGeneratedFromClass(
     string $class,
   ): CodegenGeneratedFrom {
     return
-      new CodegenGeneratedFrom($this->getConfig(), "Generated from $class");
+      new CodegenGeneratedFrom($this->getConfig(), "Generated from ".$class);
   }
 
   final public function codegenGeneratedFromMethod(
@@ -128,7 +128,7 @@ final public function codegenGeneratedFromMethod(
   ): CodegenGeneratedFrom {
     return new CodegenGeneratedFrom(
       $this->getConfig(),
-      "Generated from $class::$method()",
+      "Generated from ".$class."::".$method."()",
     );
   }
 
@@ -139,7 +139,7 @@ final public function codegenGeneratedFromMethodWithKey(
   ): CodegenGeneratedFrom {
     return new CodegenGeneratedFrom(
       $this->getConfig(),
-      "Generated from $class::$method()['$key']",
+      "Generated from ".$class."::".$method."()['".$key."']",
     );
   }
 
@@ -158,7 +158,7 @@ final public function codegenGeneratedFromScript(
     }
     return new CodegenGeneratedFrom(
       $this->getConfig(),
-      "To re-generate this file run $script",
+      "To re-generate this file run ".$script,
     );
   }
 

src/CodegenFunctionBase.php

@@ -168,7 +168,7 @@ protected function getFunctionDeclarationBase(
 
       $multi_line_builder = (new HackBuilder($this->config))
         ->add($keywords)
-        ->addLine("$this->name(")
+        ->addLine($this->name."(")
         ->indent()
         ->addLines($parameter_lines)
         ->unindent()

src/CodegenProperty.php

@@ -101,7 +101,7 @@ public function appendToBuilder(HackBuilder $builder): HackBuilder {
       ->addIf($this->isStatic, 'static ')
       ->addIf($this->type !== null, $this->type.' ')
       ->add('$'.$this->name)
-      ->addIf($this->value != self::UNSET_VALUE, ' = '.$this->value)
+      ->addIf($this->value !== self::UNSET_VALUE, ' = '.$this->value)
       ->addLine(';');
   }
 

src/HackBuilder.php

@@ -74,7 +74,7 @@ public function addMultilineCall(
     }
 
     $this
-      ->addWithSuggestedLineBreaks("$func_call_line(")
+      ->addWithSuggestedLineBreaks($func_call_line."(")
       ->newLine()
       ->indent()
       ->addLinesWithSuggestedLineBreaks(Vec\map($params, $line ==> $line.','))
@@ -577,7 +577,7 @@ private function addSimpleMultilineCall(
     Traversable<string> $params,
   ): this {
     return $this
-      ->addLine("$name(")
+      ->addLine($name."(")
       ->indent()
       ->addLines(Vec\map($params, $line ==> $line.','))
       ->unindent()

src/HackfmtFormatter.php

@@ -10,12 +10,11 @@
 
 namespace Facebook\HackCodegen;
 
-use namespace HH\Lib\Str;
 
 final class HackfmtFormatter implements ICodegenFormatter {
   public function format(
     string $code,
-    string $file_name,
+    string $_file_name,
   ): string {
     $output = array();
     $exit_code = null;