Support disallow_array_literal (#8)

* Support `disallow_array_literal`

* Enable strict options that introduce test failures

* Require HHVM 4.25 for HHI support of array_literal

* Test on composer.json version of hhvm

Author: lexidor

.hhconfig

@@ -8,3 +8,4 @@ enable_experimental_tc_features=shape_field_check,sealed_classes
 user_attributes=
 disable_primitive_refinement=true
 disable_static_local_variables = true
+disallow_array_literal = true

.travis.yml

@@ -2,7 +2,7 @@ sudo: required
 language: generic
 services: docker
 env:
-- HHVM_VERSION=4.13-latest
+- HHVM_VERSION=4.25-latest
 - HHVM_VERSION=latest
 - HHVM_VERSION=nightly
 install:

composer.json

@@ -4,7 +4,7 @@
     "keywords": ["hack", "router", "routing", "hhvm"],
     "homepage": "https://github.com/hhvm/hack-router-codegen",
     "require": {
-        "hhvm": "^4.13",
+        "hhvm": "^4.25",
         "facebook/hack-router": "^0.19",
         "facebook/hack-http-request-response-interfaces": "^0.2",
         "facebook/hack-codegen": "^4.1.0",

src/Codegen.hack

@@ -242,10 +242,10 @@ final class Codegen {
     ))
       ->setDiscardChanges(Shapes::idx($this->config ?? shape(), 'discardChanges', false))
       ->setGeneratedFrom($this->getGeneratedFrom());
-    foreach ($config['trait']['requireExtends'] ?? [] as $what) {
+    foreach ($config['trait']['requireExtends'] ?? varray[] as $what) {
       $builder->traitRequireExtends($what);
     }
-    foreach ($config['trait']['requireImplements'] ?? [] as $what) {
+    foreach ($config['trait']['requireImplements'] ?? varray[] as $what) {
       $builder->traitRequireImplements($what);
     }
 

tests/RouterCLILookupCodegenBuilderTest.hack

@@ -44,7 +44,7 @@ final class RouterCLILookupCodegenBuilderTest extends BaseCodegenTestCase {
     ));
 
     $exit_code = null;
-    $output = [];
+    $output = varray[];
     \exec(
       \vsprintf(
         '%s -d hhvm.jit=0 %s %s',
@@ -67,7 +67,7 @@ final class RouterCLILookupCodegenBuilderTest extends BaseCodegenTestCase {
     await $this->rebuildAsync();
 
     $exit_code = 0;
-    $output = [];
+    $output = varray[];
     \exec(
       \vsprintf(
         '%s -d hhvm.jit=0 %s /foo/bar',

tests/RouterCodegenBuilderTest.hack

@@ -131,7 +131,7 @@ final class RouterCodegenBuilderTest extends BaseCodegenTestCase {
     expect($controller)->toBeSame(GetRequestExampleController::class);
     $params = new RequestParameters(
       GetRequestExampleController::getUriPattern()->getParameters(),
-      [],
+      varray[],
       $params,
     );
     expect($params->getString('MyString'))->toBeSame('foo');

tests/TestTypechecksTestTrait.hack

@@ -18,7 +18,7 @@ trait TestTypechecksTestTrait {
   final public async function testTypechecks(): Awaitable<void> {
     await $this->rebuildAsync();
     $exit_code = 0;
-    $out_array = [];
+    $out_array = varray[];
     \exec(
       'hh_client',
       inout $out_array,