Skip to content
This repository was archived by the owner on Aug 1, 2023. It is now read-only.

Commit 941b0b1

Browse files
committed
don't codegen redundant 'final'
1 parent 647979b commit 941b0b1

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

src/RouterCodegenBuilder.hack

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,6 @@ final class RouterCodegenBuilder<T as IncludeInUriMap> {
9090
))
9191
->addMethod(
9292
$this->cg->codegenMethod('getRoutes')
93-
->setIsFinal(true)
9493
->setIsOverride(true)
9594
->setReturnTypef(
9695
'ImmMap<\\%s, ImmMap<string, classname<\\%s>>>',

tests/examples/codegen/MySiteRouter.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,15 @@
55
* To re-generate this file run vendor/hhvm/hacktest/bin/hacktest
66
*
77
*
8-
* @generated SignedSource<<87e793dd3e7f67b9636fe2de5fd524d3>>
8+
* @generated SignedSource<<5fc74ee3cca9f2cc0eda4d4743d264d9>>
99
*/
1010
namespace Facebook\HackRouter\CodeGen\Tests\Generated;
1111

1212
final class MySiteRouter
1313
extends \Facebook\HackRouter\BaseRouter<classname<\Facebook\HackRouter\CodeGen\Tests\GetRequestExampleController>> {
1414

1515
<<__Override>>
16-
final public function getRoutes(
16+
public function getRoutes(
1717
): ImmMap<\Facebook\HackRouter\HttpMethod, ImmMap<string, classname<\Facebook\HackRouter\CodeGen\Tests\GetRequestExampleController>>> {
1818
$map = ImmMap {
1919
\Facebook\HackRouter\HttpMethod::GET => ImmMap {

0 commit comments

Comments
 (0)