Skip to content
This repository was archived by the owner on Aug 1, 2023. It is now read-only.

Commit fc03e1a

Browse files
committed
port to Hack-Codegen v3.0
1 parent d4ab1a8 commit fc03e1a

File tree

7 files changed

+42
-44
lines changed

7 files changed

+42
-44
lines changed

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
"require": {
77
"hhvm": ">=3.22.0",
88
"facebook/hack-router": "^0.10",
9-
"facebook/hack-codegen": "^2.2.0",
9+
"facebook/hack-codegen": "^3.0.1",
1010
"facebook/definition-finder": "^1.5.3",
1111
"hhvm/type-assert": "^3.0"
1212
},

composer.lock

Lines changed: 32 additions & 35 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/RequestParametersCodegenBuilder.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ protected function getCodegenClass(self::TSpec $spec): CodegenClass {
9696

9797
return $this->cg
9898
->codegenClass($spec['class']['name'])
99-
->setUserAttribute('Codegen')
99+
->addEmptyUserAttribute('Codegen')
100100
->setIsFinal(true)
101101
->setExtends("\\".$this->base)
102102
->addTypeConst(
@@ -122,7 +122,7 @@ protected function getCodegenTrait(self::TSpec $spec): CodegenTrait {
122122

123123
$trait = $this->cg
124124
->codegenTrait($trait['name'])
125-
->setUserAttribute('Codegen')
125+
->addEmptyUserAttribute('Codegen')
126126
->addMethod(
127127
$this->cg->codegenMethod($trait['method'])
128128
->setIsFinal(true)

src/RouterCLILookupCodegenBuilder.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ private function getCodegenClass(
9292
string $utility_classname,
9393
): CodegenClass {
9494
return $this->cg->codegenClass($utility_classname)
95-
->setUserAttribute('Codegen')
95+
->addEmptyUserAttribute('Codegen')
9696
->setIsFinal(true)
9797
->addMethod(
9898
$this->cg->codegenMethod('getRouter')
@@ -182,7 +182,7 @@ private function getInitCode(): string {
182182
}
183183

184184
return $this->cg->codegenHackBuilder()
185-
->beginManualSection('init')
185+
->startManualSection('init')
186186
->addAssignment(
187187
'$autoloader',
188188
'null',

src/RouterCodegenBuilder.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ private function getCodegenClass(
8686
string $classname,
8787
): CodegenClass{
8888
$class = ($this->cg->codegenClass($classname)
89-
->setUserAttribute('Codegen')
89+
->addEmptyUserAttribute('Codegen')
9090
->setExtends(sprintf(
9191
"\\%s<classname<\\%s>>",
9292
BaseRouter::class,

src/UriBuilderCodegenBuilder.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ protected function getCodegenClass(self::TSpec $spec): CodegenClass {
7474

7575
$common = $this->cg
7676
->codegenClass($spec['class']['name'])
77-
->setUserAttribute('Codegen')
77+
->addEmptyUserAttribute('Codegen')
7878
->addConst(
7979
sprintf("classname<\\%s> CONTROLLER", HasUriPattern::class),
8080
$controller,
@@ -130,7 +130,7 @@ protected function getCodegenTrait(self::TSpec $spec): CodegenTrait {
130130

131131
return $this->cg
132132
->codegenTrait($trait['name'])
133-
->setUserAttribute('Codegen')
133+
->addEmptyUserAttribute('Codegen')
134134
->addMethod($method);
135135
}
136136
}

tests/BaseCodegenTestCase.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,8 @@
1919

2020
abstract class BaseCodegenTestCase extends \PHPUnit\Framework\TestCase {
2121
protected function getCodegenConfig(): HackCodegenConfig {
22-
return new HackCodegenConfig(realpath(__DIR__.'/../'));
22+
return (new HackCodegenConfig())
23+
->withRootDir(realpath(__DIR__.'/../'));
2324
}
2425

2526
protected function getCodegenFactory(): HackCodegenFactory {

0 commit comments

Comments
 (0)