replace all is_array() calls

Author: jjergus

src/TypeSpec/__Private/ShapeSpec.hack

@@ -67,7 +67,7 @@ final class ShapeSpec extends TypeSpec<shape()> {
 
   <<__Override>>
   public function assertType(mixed $value): shape() {
-    if (!(\is_array($value) || ($value is dict<_, _>))) {
+    if (!\HH\is_dict_or_darray($value)) {
       throw IncorrectTypeException::withValue(
         $this->getTrace(),
         'shape',
@@ -80,7 +80,9 @@ final class ShapeSpec extends TypeSpec<shape()> {
     foreach ($this->inners as $key => $spec) {
       $trace = $this->getTrace()->withFrame('shape['.$key.']');
       if (C\contains_key($value, $key)) {
-        $out[$key] = $spec->withTrace($trace)->assertType($value[$key] ?? null);
+        // Using idx() even though we just checked the key's existence, to avoid
+        // a Hack error.
+        $out[$key] = $spec->withTrace($trace)->assertType(idx($value, $key));
         continue;
       }
 

src/TypeSpec/__Private/TupleSpec.hack

@@ -22,7 +22,7 @@ final class TupleSpec extends TypeSpec<BogusTuple> {
 
   <<__Override>>
   public function coerceType(mixed $value): BogusTuple {
-    if (!(\is_array($value) || ($value is vec<_>))) {
+    if (!\HH\is_vec_or_varray($value)) {
       throw
         TypeCoercionException::withValue($this->getTrace(), 'tuple', $value);
     }
@@ -49,12 +49,13 @@ final class TupleSpec extends TypeSpec<BogusTuple> {
 
   <<__Override>>
   public function assertType(mixed $value): BogusTuple {
-    if (\is_array($value)) {
-      $value = vec($value);
-    } else if (!($value is vec<_>)) {
+    if (!\HH\is_vec_or_varray($value)) {
       throw
         IncorrectTypeException::withValue($this->getTrace(), 'tuple', $value);
     }
+    if (!$value is vec<_>) {
+      $value = vec($value);
+    }
     $values = $value;
 
     $count = \count($values);

src/TypeSpec/__Private/UntypedArraySpec.hack

@@ -31,7 +31,7 @@ final class UntypedArraySpec extends TypeSpec<varray_or_darray<mixed>> {
 
   <<__Override>>
   public function assertType(mixed $value): varray_or_darray<mixed> {
-    if (!\is_array($value)) {
+    if (!\HH\is_php_array($value)) {
       throw
         IncorrectTypeException::withValue($this->getTrace(), 'array', $value);
     }