fix(fullstack): enable emitAssets by default (#1176)

Author: hi-ogawa

packages/fullstack/examples/basic/vite.config.ts

@@ -2,7 +2,6 @@ import fullstack, {
   reactHmrPreamblePlugin,
 } from "@hiogawa/vite-plugin-fullstack";
 // import inspect from "vite-plugin-inspect";
-// import { cloudflare } from "@cloudflare/vite-plugin";
 import react from "@vitejs/plugin-react";
 import { defineConfig } from "vite";
 
@@ -20,15 +19,14 @@ export default defineConfig((_env) => ({
         outDir: "./dist/client",
       },
       // excplit rollupOptions.input is not necessary,
-      // but `optimizeDeps.entries` is desired to set.
+      // but `optimizeDeps.entries` is still desired to set.
       optimizeDeps: {
         entries: ["./src/entry.client.tsx"],
       },
     },
     ssr: {
       build: {
         outDir: "./dist/ssr",
-        emitAssets: true,
         rollupOptions: {
           input: {
             index: "./src/entry.server.tsx",
@@ -39,8 +37,6 @@ export default defineConfig((_env) => ({
   },
   builder: {
     async buildApp(builder) {
-      // NOTE
-      // dynamically adding entry is supported only when building ssr -> client
       await builder.build(builder.environments["ssr"]!);
       await builder.build(builder.environments["client"]!);
     },

packages/fullstack/examples/cloudflare/vite.config.ts

@@ -31,7 +31,6 @@ export default defineConfig((_env) => ({
     ssr: {
       build: {
         outDir: "./dist/ssr",
-        emitAssets: true,
         rollupOptions: {
           input: {
             index: "./src/entry.server.tsx",

packages/fullstack/examples/island/vite.config.ts

@@ -26,7 +26,6 @@ export default defineConfig((_env) => ({
     ssr: {
       build: {
         outDir: "./dist/ssr",
-        emitAssets: true,
         rollupOptions: {
           input: {
             index: "./src/entry.server.tsx",

packages/fullstack/examples/react-router/vite.config.ts

@@ -29,7 +29,6 @@ export default defineConfig((_env) => ({
     ssr: {
       build: {
         outDir: "./dist/ssr",
-        emitAssets: true,
         rollupOptions: {
           input: {
             index: "./src/framework/entry.server.tsx",

packages/fullstack/examples/vue-router/vite.config.ts

@@ -26,7 +26,6 @@ export default defineConfig((_env) => ({
     ssr: {
       build: {
         outDir: "./dist/ssr",
-        emitAssets: true,
         rollupOptions: {
           input: {
             index: "./src/framework/entry.server.tsx",

packages/fullstack/src/plugin.ts

@@ -36,10 +36,10 @@ type FullstackPluginOptions = {
    * @default true
    */
   serverHandler?: boolean;
-  // /**
-  //  * @default ["ssr"]
-  //  */
-  // serverEnvironments?: string[];
+  /**
+   * @default ["ssr"]
+   */
+  serverEnvironments?: string[];
 };
 
 type ImportAssetsMeta = {
@@ -68,8 +68,9 @@ export function serverHandlerPlugin(
         };
       },
       configureServer(server) {
-        assert(isRunnableDevEnvironment(server.environments.ssr));
-        const environment = server.environments.ssr;
+        const name = (pluginOpts?.serverEnvironments ?? ["ssr"])[0]!;
+        const environment = server.environments[name]!;
+        assert(isRunnableDevEnvironment(environment));
         const runner = environment.runner;
         return () => {
           server.middlewares.use(async (req, res, next) => {
@@ -88,7 +89,7 @@ export function serverHandlerPlugin(
   ];
 }
 
-export function assetsPlugin(_pluginOpts?: FullstackPluginOptions): Plugin[] {
+export function assetsPlugin(pluginOpts?: FullstackPluginOptions): Plugin[] {
   let server: ViteDevServer;
   let resolvedConfig: ResolvedConfig;
   const importAssetsMetaMap: {
@@ -107,6 +108,15 @@ export function assetsPlugin(_pluginOpts?: FullstackPluginOptions): Plugin[] {
       configResolved(config) {
         resolvedConfig = config;
       },
+      configEnvironment(name) {
+        if (pluginOpts?.serverEnvironments?.includes(name)) {
+          return {
+            build: {
+              emitAssets: true,
+            },
+          };
+        }
+      },
       /**
        * [Transform input]
        *   const assets = import.meta.vite.assets(...)