Optimize dictionary access

hi-xiaoxin · hi-xiaoxin · commit 005de95a1e18 · 2025-04-15T12:08:24.000+08:00
diff --git a/src/SourceGeneration.Reflection/SourceReflector.cs b/src/SourceGeneration.Reflection/SourceReflector.cs
@@ -4,6 +4,8 @@
 
 namespace SourceGeneration.Reflection;
 
+#pragma warning disable IDE0305
+
 public static class SourceReflector
 {
     private static readonly Dictionary<Type, SourceTypeInfo> _types = [];
@@ -12,8 +14,12 @@ public static class SourceReflector
     [EditorBrowsable(EditorBrowsableState.Never)]
     public static void Add(SourceTypeInfo typeInfo)
     {
+#if NET5_0_OR_GREATER
+        _types.TryAdd(typeInfo.Type, typeInfo);
+#else
         if (!_types.ContainsKey(typeInfo.Type))
             _types.Add(typeInfo.Type, typeInfo);
+#endif
     }
 
     public static T CreateInstance<

Original file line number	Diff line number	Diff line change
`@@ -4,6 +4,8 @@`
`4`	`4`
`5`	`5`	`namespace SourceGeneration.Reflection;`
`6`	`6`
	`7`	`+#pragma warning disable IDE0305`
	`8`	`+`
`7`	`9`	`public static class SourceReflector`
`8`	`10`	`{`
`9`	`11`	`private static readonly Dictionary<Type, SourceTypeInfo> _types = [];`
`@@ -12,8 +14,12 @@ public static class SourceReflector`
`12`	`14`	`[EditorBrowsable(EditorBrowsableState.Never)]`
`13`	`15`	`public static void Add(SourceTypeInfo typeInfo)`
`14`	`16`	`{`
	`17`	`+#if NET5_0_OR_GREATER`
	`18`	`+ _types.TryAdd(typeInfo.Type, typeInfo);`
	`19`	`+#else`
`15`	`20`	`if (!_types.ContainsKey(typeInfo.Type))`
`16`	`21`	`_types.Add(typeInfo.Type, typeInfo);`
	`22`	`+#endif`
`17`	`23`	`}`
`18`	`24`
`19`	`25`	`public static T CreateInstance<`