Skip to content

Commit 6f2d256

Browse files
committed
Remove caching for enforcer, formatter and impsort plugins
Because: 1. Retrieving something from the remote cache takes significantly more time than simply executing these goals, so caching remotely is hurtful. 2. These goals don't take much time to execute, so even caching locally is questionable. 3. In the case of the formatter and impsort plugins, we don't run the same goals on CI vs. local, so remote caching only helps on CI, and hurts locally. See for example https://ge.hibernate.org/s/zb7extrhgxneg/timeline?cacheability=cacheable&goal-execution=engine&outcome=success,failed&view=by-type * `enforcer:enforce (enforce-dependency-convergence) @ Hibernate Search Engine` 108ms to query the cache (miss), 112ms total, 1ms fingerprinting, so 3ms execution. * `enforcer:enforce (enforce-common-rules) @ Hibernate Search Engine` 91ms to query the cache (miss), 94ms total, 0ms fingerprinting, so 3 ms execution. * `enforcer:enforce (enforce-banned-dependencies-rules) @ Hibernate Search Engine` 91ms to query the cache (miss), 93ms total, 0ms fingerprinting, so 2 ms execution. * `formatter:format (code-formatting) @ Hibernate Search Engine` 89ms to query the cache (miss), 7ms fingerprinting, 99ms total, so 3 ms execution. * `impsort:sort (import-sorting) @ Hibernate Search Engine` 92ms to query the cache (miss), 14ms fingerprinting, 107ms total, so 1 ms execution.
1 parent 9152db8 commit 6f2d256

File tree

4 files changed

+0
-204
lines changed

4 files changed

+0
-204
lines changed

src/main/java/org/hibernate/search/develocity/HibernateSearchProjectDevelocityListener.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,8 @@
66
import org.codehaus.plexus.component.annotations.Component;
77
import org.hibernate.search.develocity.normalization.Normalization;
88
import org.hibernate.search.develocity.plugins.CompilerConfiguredPlugin;
9-
import org.hibernate.search.develocity.plugins.EnforcerConfiguredPlugin;
109
import org.hibernate.search.develocity.plugins.FailsafeConfiguredPlugin;
1110
import org.hibernate.search.develocity.plugins.ForbiddenApisConfiguredPlugin;
12-
import org.hibernate.search.develocity.plugins.FormatterConfiguredPlugin;
13-
import org.hibernate.search.develocity.plugins.ImpsortConfiguredPlugin;
1411
import org.hibernate.search.develocity.plugins.SurefireConfiguredPlugin;
1512
import org.hibernate.search.develocity.scan.BuildScanMetadata;
1613

@@ -37,9 +34,6 @@ public void configure(GradleEnterpriseApi gradleEnterpriseApi, MavenSession mave
3734
new CompilerConfiguredPlugin(),
3835
new SurefireConfiguredPlugin(),
3936
new FailsafeConfiguredPlugin(),
40-
new EnforcerConfiguredPlugin(),
41-
new FormatterConfiguredPlugin(),
42-
new ImpsortConfiguredPlugin(),
4337
new ForbiddenApisConfiguredPlugin()
4438
);
4539

src/main/java/org/hibernate/search/develocity/plugins/EnforcerConfiguredPlugin.java

Lines changed: 0 additions & 45 deletions
This file was deleted.

src/main/java/org/hibernate/search/develocity/plugins/FormatterConfiguredPlugin.java

Lines changed: 0 additions & 78 deletions
This file was deleted.

src/main/java/org/hibernate/search/develocity/plugins/ImpsortConfiguredPlugin.java

Lines changed: 0 additions & 75 deletions
This file was deleted.

0 commit comments

Comments
 (0)