add a compiler warning when a repo method accepts PageRequest but has no order

Author: gavinking

tooling/metamodel-generator/src/main/java/org/hibernate/processor/annotation/AnnotationMetaEntity.java

@@ -1645,6 +1645,7 @@ private void createCriteriaFinder(
 				checkFinderParameter(entity, parameter);
 			}
 		}
+		warnAboutMissingOrder( method );
 		putMember( methodKey,
 				new CriteriaFinderMethod(
 						this, method,
@@ -1911,6 +1912,7 @@ private void createMultipleParameterFinder(
 				multivalued.add( false );
 			}
 		}
+		warnAboutMissingOrder( method );
 		if ( !usingStatelessSession( sessionType[0] ) // no byNaturalId() lookup API for SS
 				&& matchesNaturalKey( entity, fieldTypes ) ) {
 			putMember( methodKey,
@@ -1959,6 +1961,25 @@ && matchesNaturalKey( entity, fieldTypes ) ) {
 		}
 	}
 
+	private void warnAboutMissingOrder(ExecutableElement method) {
+		if ( !hasAnnotation(  method, JD_ORDER_BY, JD_ORDER_BY_LIST ) ) {
+			boolean hasPageRequest = false;
+			boolean hasSortOrOrder = false;
+			for ( VariableElement parameter : method.getParameters() ) {
+				final String parameterType = parameter.asType().toString();
+				if ( isOrderParam( parameterType ) ) {
+					hasSortOrOrder = true;
+				}
+				if ( isPageParam( parameterType ) ) {
+					hasPageRequest = true;
+				}
+			}
+			if ( hasPageRequest && !hasSortOrOrder ) {
+				context.message( method, "'PageRequest' with no 'Sort' or 'Order' and no '@OrderBy'", Diagnostic.Kind.MANDATORY_WARNING );
+			}
+		}
+	}
+
 	private void createSingleParameterFinder(
 			ExecutableElement method, TypeMirror returnType, TypeElement entity, @Nullable String containerType) {
 		final String methodName = method.getSimpleName().toString();