Skip to content

Commit 0280f48

Browse files
committed
get rid of some raw types
1 parent 3d1d16b commit 0280f48

File tree

3 files changed

+13
-15
lines changed

3 files changed

+13
-15
lines changed

hibernate-core/src/main/java/org/hibernate/procedure/internal/OracleCallableStatementSupport.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ public OracleCallableStatementSupport(boolean supportsRefCursors) {
2424
@Override
2525
protected void appendNameParameter(
2626
StringBuilder buffer,
27-
ProcedureParameterImplementor parameter,
27+
ProcedureParameterImplementor<?> parameter,
2828
JdbcCallParameterRegistration registration) {
2929
buffer.append( parameter.getName() ).append( " => ?" );
3030
}

hibernate-core/src/main/java/org/hibernate/procedure/internal/SQLServerCallableStatementSupport.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,10 @@ private SQLServerCallableStatementSupport() {
1717
}
1818

1919
@Override
20-
protected void appendNameParameter(StringBuilder buffer, ProcedureParameterImplementor parameter, JdbcCallParameterRegistration registration) {
20+
protected void appendNameParameter(
21+
StringBuilder buffer,
22+
ProcedureParameterImplementor<?> parameter,
23+
JdbcCallParameterRegistration registration) {
2124
buffer.append( '@' ).append( parameter.getName() ).append( " = ?" );
2225
}
2326
}

hibernate-core/src/main/java/org/hibernate/procedure/internal/StandardCallableStatementSupport.java

Lines changed: 8 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@
44
*/
55
package org.hibernate.procedure.internal;
66

7-
import java.util.List;
8-
97
import org.hibernate.QueryException;
108
import org.hibernate.dialect.Dialect;
119
import org.hibernate.engine.spi.SharedSessionContractImplementor;
@@ -49,16 +47,13 @@ public JdbcOperationQueryCall interpretCall(ProcedureCallImplementor<?> procedur
4947
final FunctionReturnImplementor<?> functionReturn = procedureCall.getFunctionReturn();
5048
final ProcedureParameterMetadataImplementor parameterMetadata = procedureCall.getParameterMetadata();
5149
final SharedSessionContractImplementor session = procedureCall.getSession();
52-
final List<? extends ProcedureParameterImplementor<?>> registrations = parameterMetadata.getRegistrationsAsList();
53-
final int paramStringSizeEstimate;
54-
if ( functionReturn == null && parameterMetadata.hasNamedParameters() ) {
55-
// That's just a rough estimate. I guess most params will have fewer than 8 chars on average
56-
paramStringSizeEstimate = registrations.size() * 10;
57-
}
58-
else {
59-
// For every param rendered as '?' we have a comma, hence the estimate
60-
paramStringSizeEstimate = registrations.size() * 2;
61-
}
50+
final var registrations = parameterMetadata.getRegistrationsAsList();
51+
final int paramStringSizeEstimate =
52+
functionReturn == null && parameterMetadata.hasNamedParameters()
53+
// That's just a rough estimate. I guess most params will have fewer than 8 chars on average
54+
? registrations.size() * 10
55+
// For every param rendered as '?' we have a comma, hence the estimate
56+
: registrations.size() * 2;
6257
final JdbcCallImpl.Builder builder = new JdbcCallImpl.Builder();
6358
final StringBuilder buffer;
6459
final int offset;
@@ -110,7 +105,7 @@ public JdbcOperationQueryCall interpretCall(ProcedureCallImplementor<?> procedur
110105

111106
protected void appendNameParameter(
112107
StringBuilder buffer,
113-
ProcedureParameterImplementor parameter,
108+
ProcedureParameterImplementor<?> parameter,
114109
JdbcCallParameterRegistration registration) {
115110
buffer.append( '?' );
116111
}

0 commit comments

Comments
 (0)