HHH-16966 StackOverFlowError with @manytoone and @Proxy( lazy=false )

dreab8 · dreab8 · commit 0725022d79b6 · 2023-07-26T15:06:18.000+02:00
diff --git a/hibernate-core/src/main/java/org/hibernate/sql/results/graph/entity/internal/EntitySelectFetchInitializerBuilder.java b/hibernate-core/src/main/java/org/hibernate/sql/results/graph/entity/internal/EntitySelectFetchInitializerBuilder.java
@@ -147,12 +147,8 @@ else if ( creationState.isDynamicInstantiation() ) {
 	}
 
 	private static boolean canBatchInitializeBeUsed(EntityPersister entityPersister) {
-		if ( entityPersister.getRepresentationStrategy().getProxyFactory() == null
-				&& entityPersister.hasSubclasses() ) {
-			// We cannot neither create a proxy nor instantiate the entity because we don't know the concrete type
-			return false;
-		}
-		return true;
+		//  we need to create a Proxy in order to use batch initialize
+		return entityPersister.getRepresentationStrategy().getProxyFactory() != null;
 	}
 
 	enum BatchMode {

Original file line number	Diff line number	Diff line change
`@@ -147,12 +147,8 @@ else if ( creationState.isDynamicInstantiation() ) {`
`147`	`147`	`}`
`148`	`148`
`149`	`149`	`private static boolean canBatchInitializeBeUsed(EntityPersister entityPersister) {`
`150`		`- if ( entityPersister.getRepresentationStrategy().getProxyFactory() == null`
`151`		`- && entityPersister.hasSubclasses() ) {`
`152`		`- // We cannot neither create a proxy nor instantiate the entity because we don't know the concrete type`
`153`		`- return false;`
`154`		`- }`
`155`		`- return true;`
	`150`	`+ // we need to create a Proxy in order to use batch initialize`
	`151`	`+ return entityPersister.getRepresentationStrategy().getProxyFactory() != null;`
`156`	`152`	`}`
`157`	`153`
`158`	`154`	`enum BatchMode {`