HHH-8370 remove support for row value constructor and adjust naming of new support

Author: robwgreenjr

hibernate-core/src/main/java/org/hibernate/dialect/Dialect.java

@@ -6209,8 +6209,8 @@ public boolean supportsRowValueConstructorSyntaxInInSubQuery() {
 	}
 
 	/**
-	 * If the dialect supports {@link org.hibernate.dialect.Dialect#supportsRowValueConstructorSyntax() row values},
-	 * does it allow using them in a derived table within an EXISTS predicate that emulates an IN-list?
+	 * This pattern avoids the SQL length and performance issues of large disjunctions,
+	 * and emulates tuple-based IN-list comparisons using a derived VALUES table.
 	 * <p>
 	 * For example:
 	 * <pre>
@@ -6220,13 +6220,8 @@ public boolean supportsRowValueConstructorSyntaxInInSubQuery() {
 	 *         WHERE T.FIELD1 = V.FIELD1 AND T.FIELD2 = V.FIELD2
 	 *     )
 	 * </pre>
-	 * This pattern avoids the SQL length and performance issues of large disjunctions,
-	 * and emulates tuple-based IN-list comparisons using a derived VALUES table.
-	 *
-	 * @return True if this SQL dialect is known to support row value constructors in
-	 *         derived tables for EXISTS-based IN-list emulation; false otherwise.
 	 */
-	public boolean supportsRowValueConstructorSyntaxInDerivedTableInList() {
+	public boolean supportsValuesListForInListExistsEmulation() {
 		return false;
 	}
 }

hibernate-core/src/main/java/org/hibernate/dialect/SQLServerDialect.java

@@ -1245,7 +1245,7 @@ public boolean supportsSimpleQueryGrouping() {
 
 	@Override
 	public boolean supportsRowValueConstructorSyntax() {
-		return getVersion().isSameOrAfter( 10 );
+		return false;
 	}
 
 	@Override
@@ -1264,7 +1264,7 @@ public boolean supportsRowValueConstructorSyntaxInInList() {
 	}
 
 	@Override
-	public boolean supportsRowValueConstructorSyntaxInDerivedTableInList() {
+	public boolean supportsValuesListForInListExistsEmulation() {
 		return getVersion().isSameOrAfter( 10 );
 	}
 }

hibernate-core/src/main/java/org/hibernate/sql/ast/spi/AbstractSqlAstTranslator.java

@@ -21,7 +21,6 @@
 import java.util.function.Consumer;
 import java.util.function.Function;
 import java.util.function.Supplier;
-import java.util.stream.Collectors;
 
 import org.hibernate.AssertionFailure;
 import org.hibernate.Internal;
@@ -7643,49 +7642,38 @@ public void visitInListPredicate(InListPredicate inListPredicate) {
 						getSqlTuple( listExpression )
 								.getExpressions().get( 0 );
 			}
-			else if ( dialect.supportsRowValueConstructorSyntaxInDerivedTableInList() ) {
+			else if ( dialect.supportsValuesListForInListExistsEmulation() ) {
 				if ( inListPredicate.isNegated() ) {
 					appendSql( "not " );
 				}
-				appendSql( "exists (select 1 from (values " );
 
-				List<SqlTuple> listTuples = listExpressions.stream()
-						.map( SqlTupleContainer::getSqlTuple )
-						.toList();
-				for ( int i = 0; i < listTuples.size(); i++ ) {
+				appendSql( "exists (select 1 from (values " );
+				for ( int i = 0; i < listExpressions.size(); i++ ) {
 					if ( i > 0 ) {
 						appendSql( ", " );
 					}
-
 					appendSql( OPEN_PARENTHESIS );
-					renderCommaSeparatedSelectExpression( listTuples.get(i).getExpressions() );
+					renderCommaSeparatedSelectExpression( List.of( listExpressions.get( i ) ) );
 					appendSql( CLOSE_PARENTHESIS );
 				}
-
-				List<Expression> expressions = lhsTuple.getExpressions()
-						.stream()
-						.filter( expression -> expression.getColumnReference() != null )
-						.collect( Collectors.toList() );
 				appendSql( ") as v(" );
+
+				final List<? extends SqlAstNode> expressions = lhsTuple.getExpressions();
 				for ( int i = 0; i < expressions.size(); i++ ) {
 					if ( i > 0 ) {
 						appendSql( ", " );
 					}
-					appendSql( expressions.get( i ).getColumnReference().getColumnExpression() );
+					appendSql( "col_" + i );
 				}
-
 				appendSql( ") where " );
+
 				for ( int i = 0; i < expressions.size(); i++ ) {
 					if ( i > 0 ) {
 						appendSql( " and " );
 					}
-
-					Expression expression = expressions.get( i );
-					expression.accept( this );
-					appendSql( " = v." );
-					appendSql( expression.getColumnReference().getColumnExpression() );
+					expressions.get( i ).accept( this );
+					appendSql( " = v.col_" + i );
 				}
-
 				appendSql( CLOSE_PARENTHESIS );
 				return;
 			}

hibernate-core/src/test/java/org/hibernate/orm/test/dialect/functional/SQLServerDialectCompositeTest.java

@@ -52,7 +52,7 @@ public void testCompositeQueryWithInPredicate(EntityManagerFactoryScope scope) {
 		);
 
 		var query = sqlStatementInterceptor.getSqlQueries().get( 0 );
-		assertTrue( query.endsWith( "where exists (select 1 from (values (?,?), (?,?)) as v(id1, id2) where ewci1_0.id1 = v.id1 and ewci1_0.id2 = v.id2)" ) );
+		assertTrue( query.endsWith( "where exists (select 1 from (values (?,?), (?,?)) as v(col_0, col_1) where ewci1_0.id1 = v.col_0 and ewci1_0.id2 = v.col_1)" ) );
 	}
 
 	@Test
@@ -72,7 +72,7 @@ public void testCompositeQueryWithNotInPredicate(EntityManagerFactoryScope scope
 		);
 
 		var query = sqlStatementInterceptor.getSqlQueries().get( 0 );
-		assertTrue( query.endsWith( "where not exists (select 1 from (values (?,?), (?,?)) as v(id1, id2) where ewci1_0.id1 = v.id1 and ewci1_0.id2 = v.id2)" ) );
+		assertTrue( query.endsWith( "where not exists (select 1 from (values (?,?), (?,?)) as v(col_0, col_1) where ewci1_0.id1 = v.col_0 and ewci1_0.id2 = v.col_1)" ) );
 	}
 
 	@Test
@@ -93,6 +93,6 @@ public void testCompositeQueryWithMultiplePredicatesIncludingIn(EntityManagerFac
 		);
 
 		var query = sqlStatementInterceptor.getSqlQueries().get( 0 );
-		assertTrue( query.endsWith( "where ewci1_0.description=? and exists (select 1 from (values (?,?), (?,?)) as v(id1, id2) where ewci1_0.id1 = v.id1 and ewci1_0.id2 = v.id2)" ) );
+		assertTrue( query.endsWith( "where ewci1_0.description=? and exists (select 1 from (values (?,?), (?,?)) as v(col_0, col_1) where ewci1_0.id1 = v.col_0 and ewci1_0.id2 = v.col_1)" ) );
 	}
 }