Skip to content

Commit 08bd466

Browse files
committed
HHH-18498 - Generator on package level does not work when the name is not specified
HHH-18499 - Some new functions in Persistence 3.2 does not work HHH-18536 - Support implicit "this" alias in HQL HHH-18537 - Support Session#createNamedSelectionQuery for native-query
1 parent a82ac08 commit 08bd466

File tree

6 files changed

+33
-5
lines changed

6 files changed

+33
-5
lines changed

hibernate-core/src/test/java/org/hibernate/orm/test/annotations/id/generators/entity/ClassLevelGeneratorTest.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@
66
import jakarta.persistence.SequenceGenerator;
77
import jakarta.persistence.TableGenerator;
88
import org.hibernate.testing.orm.junit.DomainModel;
9+
import org.hibernate.testing.orm.junit.FailureExpected;
10+
import org.hibernate.testing.orm.junit.Jira;
911
import org.hibernate.testing.orm.junit.SessionFactory;
1012
import org.hibernate.testing.orm.junit.SessionFactoryScope;
1113
import org.junit.jupiter.api.Test;
@@ -16,6 +18,8 @@
1618
@DomainModel(annotatedClasses =
1719
{ClassLevelGeneratorTest.EntityWithAnonSequenceGenerator.class,
1820
ClassLevelGeneratorTest.EntityWithAnonTableGenerator.class})
21+
@FailureExpected( reason = "Support for unnamed generators is not implemented yet" )
22+
@Jira( "https://hibernate.atlassian.net/browse/HHH-18498" )
1923
public class ClassLevelGeneratorTest {
2024
@Test
2125
void testAnonGenerator(SessionFactoryScope scope) {

hibernate-core/src/test/java/org/hibernate/orm/test/annotations/id/generators/entity/FieldLevelGeneratorTest.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@
66
import jakarta.persistence.SequenceGenerator;
77
import jakarta.persistence.TableGenerator;
88
import org.hibernate.testing.orm.junit.DomainModel;
9+
import org.hibernate.testing.orm.junit.FailureExpected;
10+
import org.hibernate.testing.orm.junit.Jira;
911
import org.hibernate.testing.orm.junit.SessionFactory;
1012
import org.hibernate.testing.orm.junit.SessionFactoryScope;
1113
import org.junit.jupiter.api.Test;
@@ -16,6 +18,8 @@
1618
@DomainModel(annotatedClasses =
1719
{FieldLevelGeneratorTest.EntityWithAnonSequenceGenerator.class,
1820
FieldLevelGeneratorTest.EntityWithAnonTableGenerator.class})
21+
@FailureExpected( reason = "Support for unnamed generators is not implemented yet" )
22+
@Jira( "https://hibernate.atlassian.net/browse/HHH-18498" )
1923
public class FieldLevelGeneratorTest {
2024
@Test
2125
void testAnonGenerator(SessionFactoryScope scope) {

hibernate-core/src/test/java/org/hibernate/orm/test/annotations/id/generators/pkg/PackageLevelGeneratorTest.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@
44
import jakarta.persistence.GeneratedValue;
55
import jakarta.persistence.Id;
66
import org.hibernate.testing.orm.junit.DomainModel;
7+
import org.hibernate.testing.orm.junit.FailureExpected;
8+
import org.hibernate.testing.orm.junit.Jira;
79
import org.hibernate.testing.orm.junit.SessionFactory;
810
import org.hibernate.testing.orm.junit.SessionFactoryScope;
911
import org.junit.jupiter.api.Test;
@@ -14,6 +16,8 @@
1416
@DomainModel(annotatedClasses =
1517
{PackageLevelGeneratorTest.EntityWithAnonSequenceGenerator.class,
1618
PackageLevelGeneratorTest.EntityWithAnonTableGenerator.class})
19+
@FailureExpected( reason = "Support for unnamed generators is not implemented yet" )
20+
@Jira( "https://hibernate.atlassian.net/browse/HHH-18498" )
1721
public class PackageLevelGeneratorTest {
1822
@Test
1923
void testAnonGenerator(SessionFactoryScope scope) {

hibernate-core/src/test/java/org/hibernate/orm/test/jpa/query/NamedNativeQueryWithResultMappingTest.java

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,20 +9,24 @@
99
import jakarta.persistence.NamedNativeQuery;
1010
import jakarta.persistence.Table;
1111
import org.hibernate.testing.orm.junit.DomainModel;
12+
import org.hibernate.testing.orm.junit.FailureExpected;
13+
import org.hibernate.testing.orm.junit.Jira;
1214
import org.hibernate.testing.orm.junit.SessionFactory;
1315
import org.hibernate.testing.orm.junit.SessionFactoryScope;
1416
import org.junit.jupiter.api.Test;
1517

1618
@SessionFactory
1719
@DomainModel(annotatedClasses = NamedNativeQueryWithResultMappingTest.Mapped.class)
20+
@FailureExpected( jiraKey = "HHH-18537", reason = "Call to #createNamedSelectionQuery for native-query, which never worked." )
21+
@Jira( "https://hibernate.atlassian.net/browse/HHH-18537" )
1822
public class NamedNativeQueryWithResultMappingTest {
1923
@Test void test(SessionFactoryScope scope) {
2024
Mapped mapped = new Mapped();
2125
mapped.name = "Gavin";
2226
scope.inTransaction(s -> s.persist(mapped));
2327
scope.inSession(s -> {
24-
s.createNamedSelectionQuery("mapped-native-query").getSingleResult();
25-
s.createNamedSelectionQuery("unmapped-native-query").getSingleResult();
28+
s.createNamedSelectionQuery("mapped-native-query",Object[].class).getSingleResult();
29+
s.createNamedSelectionQuery("unmapped-native-query",Object[].class).getSingleResult();
2630
});
2731
}
2832
@NamedNativeQuery(

hibernate-core/src/test/java/org/hibernate/orm/test/query/hql/thisalias/HQLThisTest.java

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,16 @@
55
import jakarta.persistence.GeneratedValue;
66
import jakarta.persistence.Id;
77
import org.hibernate.testing.orm.junit.DomainModel;
8+
import org.hibernate.testing.orm.junit.FailureExpected;
9+
import org.hibernate.testing.orm.junit.Jira;
810
import org.hibernate.testing.orm.junit.SessionFactory;
911
import org.hibernate.testing.orm.junit.SessionFactoryScope;
1012
import org.junit.jupiter.api.Test;
1113

1214
@SessionFactory
1315
@DomainModel(annotatedClasses = HQLThisTest.This.class)
16+
@FailureExpected( jiraKey = "HHH-18536", reason = "Support implicit \"this\" alias in HQL" )
17+
@Jira( "https://hibernate.atlassian.net/browse/HHH-18536" )
1418
public class HQLThisTest {
1519
@Test
1620
void test(SessionFactoryScope scope) {
@@ -23,14 +27,18 @@ void test(SessionFactoryScope scope) {
2327
s.createSelectionQuery("select id(this) from This").getSingleResult();
2428
});
2529
}
26-
@Entity
30+
@Entity(name="This")
2731
static class This {
2832
@Id @GeneratedValue
2933
long id;
3034
@Basic(optional = false)
3135
String name;
3236

33-
This(String gavin) {}
34-
This() {}
37+
This(String name) {
38+
this.name = name;
39+
}
40+
41+
This() {
42+
}
3543
}
3644
}

hibernate-core/src/test/java/org/hibernate/orm/test/query/resultmapping/EntityResultTests.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,8 @@
2323

2424
import org.hibernate.testing.orm.domain.gambit.EntityOfBasics;
2525
import org.hibernate.testing.orm.junit.DomainModel;
26+
import org.hibernate.testing.orm.junit.FailureExpected;
27+
import org.hibernate.testing.orm.junit.Jira;
2628
import org.hibernate.testing.orm.junit.ServiceRegistry;
2729
import org.hibernate.testing.orm.junit.SessionFactoryScope;
2830
import org.hibernate.testing.orm.junit.Setting;
@@ -121,6 +123,8 @@ public void testImplicitAttributeMapping(SessionFactoryScope scope) {
121123
}
122124

123125
@Test
126+
@FailureExpected( jiraKey = "HHH-18535", reason = "Support for @EntityResult(lockMode) not implemented yet")
127+
@Jira( "https://hibernate.atlassian.net/browse/HHH-18535" )
124128
public void testImplicitAttributeMappingWithLockMode(SessionFactoryScope scope) {
125129
scope.inTransaction(
126130
session -> {

0 commit comments

Comments
 (0)