Skip to content

Commit 0b8444a

Browse files
committed
HHH-19260 - Move supportsNestedSubqueryCorrelation() from AbstractSqlAstTranslator to Dialect
Signed-off-by: Jan Schatteman <[email protected]>
1 parent 35a4c39 commit 0b8444a

File tree

14 files changed

+33
-45
lines changed

14 files changed

+33
-45
lines changed

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/MariaDBLegacySqlAstTranslator.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -243,12 +243,6 @@ protected boolean shouldEmulateLateralWithIntersect(QueryPart queryPart) {
243243
return supportsSimpleQueryGrouping() || !queryPart.hasOffsetOrFetchClause();
244244
}
245245

246-
@Override
247-
protected boolean supportsNestedSubqueryCorrelation() {
248-
// It seems it doesn't support it
249-
return false;
250-
}
251-
252246
@Override
253247
public void visitQueryGroup(QueryGroup queryGroup) {
254248
if ( shouldEmulateFetchClause( queryGroup ) ) {

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/MySQLLegacyDialect.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1519,4 +1519,9 @@ public boolean supportsJoinsInDelete() {
15191519
return true;
15201520
}
15211521

1522+
@Override
1523+
public boolean supportsNestedSubqueryCorrelation() {
1524+
return false;
1525+
}
1526+
15221527
}

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/MySQLLegacySqlAstTranslator.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -384,11 +384,6 @@ protected boolean supportsSimpleQueryGrouping() {
384384
return getDialect().getVersion().isSameOrAfter( 8 );
385385
}
386386

387-
@Override
388-
protected boolean supportsNestedSubqueryCorrelation() {
389-
return false;
390-
}
391-
392387
@Override
393388
protected boolean supportsWithClause() {
394389
return getDialect().getVersion().isSameOrAfter( 8 );

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/OracleLegacyDialect.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1664,4 +1664,10 @@ public boolean supportsDuplicateSelectItemsInQueryGroup() {
16641664
return false;
16651665
}
16661666

1667+
@Override
1668+
public boolean supportsNestedSubqueryCorrelation() {
1669+
// It seems it doesn't support it, at least on version 11
1670+
return false;
1671+
}
1672+
16671673
}

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/OracleLegacySqlAstTranslator.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -198,12 +198,6 @@ protected boolean shouldEmulateLateralWithIntersect(QueryPart queryPart) {
198198
return !queryPart.hasOffsetOrFetchClause();
199199
}
200200

201-
@Override
202-
protected boolean supportsNestedSubqueryCorrelation() {
203-
// It seems it doesn't support it, at least on version 11
204-
return false;
205-
}
206-
207201
protected boolean shouldEmulateFetchClause(QueryPart queryPart) {
208202
// Check if current query part is already row numbering to avoid infinite recursion
209203
if ( getQueryPartForRowNumbering() == queryPart ) {

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/SingleStoreDialect.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1420,4 +1420,9 @@ public boolean supportsJoinsInDelete() {
14201420
return true;
14211421
}
14221422

1423+
@Override
1424+
public boolean supportsNestedSubqueryCorrelation() {
1425+
return false;
1426+
}
1427+
14231428
}

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/SingleStoreSqlAstTranslator.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -248,11 +248,6 @@ public void visitEvery(Every every) {
248248
throw new UnsupportedOperationException( "SingleStore doesn't support ALL clause" );
249249
}
250250

251-
@Override
252-
protected boolean supportsNestedSubqueryCorrelation() {
253-
return false;
254-
}
255-
256251
@Override
257252
public void visitQueryGroup(QueryGroup queryGroup) {
258253
if ( shouldEmulateFetchClause( queryGroup ) ) {

hibernate-core/src/main/java/org/hibernate/dialect/Dialect.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5926,4 +5926,8 @@ public boolean supportsJoinsInDelete() {
59265926
return false;
59275927
}
59285928

5929+
public boolean supportsNestedSubqueryCorrelation() {
5930+
return true;
5931+
}
5932+
59295933
}

hibernate-core/src/main/java/org/hibernate/dialect/MariaDBSqlAstTranslator.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -246,12 +246,6 @@ protected boolean shouldEmulateLateralWithIntersect(QueryPart queryPart) {
246246
return supportsSimpleQueryGrouping() || !queryPart.hasOffsetOrFetchClause();
247247
}
248248

249-
@Override
250-
protected boolean supportsNestedSubqueryCorrelation() {
251-
// It seems it doesn't support it
252-
return false;
253-
}
254-
255249
@Override
256250
public void visitQueryGroup(QueryGroup queryGroup) {
257251
if ( shouldEmulateFetchClause( queryGroup ) ) {

hibernate-core/src/main/java/org/hibernate/dialect/MySQLDialect.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1613,4 +1613,9 @@ public boolean supportsJoinsInDelete() {
16131613
return true;
16141614
}
16151615

1616+
@Override
1617+
public boolean supportsNestedSubqueryCorrelation() {
1618+
return false;
1619+
}
1620+
16161621
}

0 commit comments

Comments
 (0)