add some more use of 'sealed' to org.hibernate.mapping

to enforce model restrictions we implicitly assume in our client code

Author: gavinking

hibernate-core/src/main/java/org/hibernate/mapping/Bag.java

@@ -18,7 +18,7 @@
  *
  * @author Gavin King
  */
-public class Bag extends Collection {
+public non-sealed class Bag extends Collection {
 	/**
 	 * hbm.xml binding
 	 */

hibernate-core/src/main/java/org/hibernate/mapping/Collection.java

@@ -44,7 +44,11 @@
  *
  * @author Gavin King
  */
-public abstract class Collection implements Fetchable, Value, Filterable, SoftDeletable {
+public abstract sealed class Collection
+		implements Fetchable, Value, Filterable, SoftDeletable
+		permits Set, Bag,
+				IndexedCollection, // List, Map
+				IdentifierCollection { // IdentifierBag only built-in implementation
 
 	public static final String DEFAULT_ELEMENT_COLUMN_NAME = "elt";
 	public static final String DEFAULT_KEY_COLUMN_NAME = "id";

hibernate-core/src/main/java/org/hibernate/mapping/IdentifierBag.java

@@ -27,7 +27,9 @@ public IdentifierBag(MetadataBuildingContext buildingContext, PersistentClass ow
 	/**
 	 * annotation binding
 	 */
-	public IdentifierBag(Supplier<ManagedBean<? extends UserCollectionType>> customTypeBeanResolver, PersistentClass owner, MetadataBuildingContext buildingContext) {
+	public IdentifierBag(
+			Supplier<ManagedBean<? extends UserCollectionType>> customTypeBeanResolver, PersistentClass owner,
+			MetadataBuildingContext buildingContext) {
 		super( customTypeBeanResolver, owner, buildingContext );
 	}
 

hibernate-core/src/main/java/org/hibernate/mapping/IdentifierCollection.java

@@ -17,7 +17,7 @@
  * A mapping model object representing a collection with a synthetic "identifier" column,
  * that is, a surrogate key.
  */
-public abstract class IdentifierCollection extends Collection {
+public non-sealed abstract class IdentifierCollection extends Collection {
 
 	public static final String DEFAULT_IDENTIFIER_COLUMN_NAME = "id";
 

hibernate-core/src/main/java/org/hibernate/mapping/IndexedCollection.java

@@ -18,7 +18,7 @@
  * primitive arrays.
  * @author Gavin King
  */
-public abstract class IndexedCollection extends Collection {
+public sealed abstract class IndexedCollection extends Collection permits Map, List  {
 
 	public static final String DEFAULT_INDEX_COLUMN_NAME = "idx";
 

hibernate-core/src/main/java/org/hibernate/mapping/JoinedSubclass.java

@@ -17,7 +17,7 @@
  *
  * @author Gavin King
  */
-public class JoinedSubclass extends Subclass implements TableOwner {
+public final class JoinedSubclass extends Subclass implements TableOwner {
 	private Table table;
 	private KeyValue key;
 

hibernate-core/src/main/java/org/hibernate/mapping/List.java

@@ -18,7 +18,7 @@
  *
  * @author Gavin King
  */
-public class List extends IndexedCollection {
+public non-sealed class List extends IndexedCollection {
 
 	private int baseIndex;
 

hibernate-core/src/main/java/org/hibernate/mapping/ManyToOne.java

@@ -17,7 +17,7 @@
  *
  * @author Gavin King
  */
-public class ManyToOne extends ToOne {
+public final class ManyToOne extends ToOne {
 	private boolean isLogicalOneToOne;
 	private NotFoundAction notFoundAction;
 

hibernate-core/src/main/java/org/hibernate/mapping/Map.java

@@ -19,7 +19,7 @@
  * A mapping model object representing a collection of type {@link java.util.Map}.
  * A map has a primary key consisting of the key columns + index columns.
  */
-public class Map extends IndexedCollection {
+public non-sealed class Map extends IndexedCollection {
 
 	private String mapKeyPropertyName;
 	private boolean hasMapKeyProperty;

hibernate-core/src/main/java/org/hibernate/mapping/OneToOne.java

@@ -18,7 +18,7 @@
  *
  * @author Gavin King
  */
-public class OneToOne extends ToOne {
+public final class OneToOne extends ToOne {
 
 	private boolean constrained;
 	private ForeignKeyDirection foreignKeyType;