HHH-19349 deprecate unused SessionFactoryOptions

- SchemaAutoTooling is completely obsolete and unused
- TempTableDdlTransactionHandling appears to also be
  obsolete; it's still overridable by a custom Dialect
  but no Dialect actually does override it

Author: gavinking

hibernate-core/src/main/java/org/hibernate/boot/SchemaAutoTooling.java

@@ -12,8 +12,11 @@
 /**
  * Defines the possible values for {@value AvailableSettings#HBM2DDL_AUTO}.
  *
+ * @deprecated This enumeration is currently unused and will be removed.
+ *
  * @author Steve Ebersole
  */
+@Deprecated(since = "7.0", forRemoval = true)
 public enum SchemaAutoTooling {
 	/**
 	 * Drop the schema and recreate it on {@code SessionFactory} startup.

hibernate-core/src/main/java/org/hibernate/boot/SessionFactoryBuilder.java

@@ -263,7 +263,10 @@ public interface SessionFactoryBuilder {
 	 * to transaction handling.
 	 *
 	 * @see TempTableDdlTransactionHandling
+	 *
+	 * @deprecated This has no effect and will be removed.
 	 */
+	@Deprecated(since = "7.0", forRemoval = true)
 	SessionFactoryBuilder applyTempTableDdlTransactionHandling(TempTableDdlTransactionHandling handling);
 
 	/**

hibernate-core/src/main/java/org/hibernate/boot/TempTableDdlTransactionHandling.java

@@ -9,7 +9,12 @@
  * transaction handling.
  *
  * @author Steve Ebersole
+ *
+ * @see org.hibernate.dialect.Dialect#getTemporaryTableDdlTransactionHandling
+ *
+ * @deprecated All dialects currently use {@link #NONE}, so it's obsolete.
  */
+@Deprecated(since = "7.0")
 public enum TempTableDdlTransactionHandling {
 	/**
 	 * No handling of transactions is needed

hibernate-core/src/main/java/org/hibernate/boot/internal/SessionFactoryBuilderImpl.java

@@ -192,7 +192,7 @@ public SessionFactoryBuilder applyLazyInitializationOutsideTransaction(boolean e
 		return this;
 	}
 
-	@Override
+	@Override @Deprecated
 	public SessionFactoryBuilder applyTempTableDdlTransactionHandling(TempTableDdlTransactionHandling handling) {
 		this.optionsBuilder.applyTempTableDdlTransactionHandling( handling );
 		return this;

hibernate-core/src/main/java/org/hibernate/boot/internal/SessionFactoryOptionsBuilder.java

@@ -443,13 +443,15 @@ public SessionFactoryOptionsBuilder(StandardServiceRegistry serviceRegistry, Boo
 			autoEvictCollectionCache = false;
 		}
 
+		// deprecated
 		try {
 			schemaAutoTooling = SchemaAutoTooling.interpret( (String) settings.get( AvailableSettings.HBM2DDL_AUTO ) );
 		}
 		catch (Exception e) {
 			log.warn( e.getMessage() + "  Ignoring" );
 		}
 
+		// deprecated
 		final ExtractedDatabaseMetaData meta = jdbcServices.getExtractedMetaDataSupport();
 		if ( meta.doesDataDefinitionCauseTransactionCommit() ) {
 			tempTableDdlTransactionHandling =
@@ -936,7 +938,7 @@ public boolean isInitializeLazyStateOutsideTransactionsEnabled() {
 		return initializeLazyStateOutsideTransactions;
 	}
 
-	@Override
+	@Override @Deprecated
 	public TempTableDdlTransactionHandling getTempTableDdlTransactionHandling() {
 		return tempTableDdlTransactionHandling;
 	}
@@ -1041,7 +1043,7 @@ public boolean isAutoEvictCollectionCache() {
 		return autoEvictCollectionCache;
 	}
 
-	@Override
+	@Override @Deprecated
 	public SchemaAutoTooling getSchemaAutoTooling() {
 		return schemaAutoTooling;
 	}
@@ -1381,6 +1383,7 @@ public void allowLazyInitializationOutsideTransaction(boolean enabled) {
 		this.initializeLazyStateOutsideTransactions = enabled;
 	}
 
+	@Deprecated(forRemoval = true)
 	public void applyTempTableDdlTransactionHandling(TempTableDdlTransactionHandling handling) {
 		this.tempTableDdlTransactionHandling = handling;
 	}

hibernate-core/src/main/java/org/hibernate/boot/spi/AbstractDelegatingSessionFactoryBuilder.java

@@ -148,7 +148,7 @@ public T applyLazyInitializationOutsideTransaction(boolean enabled) {
 		return getThis();
 	}
 
-	@Override
+	@Override @Deprecated
 	public T applyTempTableDdlTransactionHandling(TempTableDdlTransactionHandling handling) {
 		delegate.applyTempTableDdlTransactionHandling( handling );
 		return getThis();

hibernate-core/src/main/java/org/hibernate/boot/spi/AbstractDelegatingSessionFactoryOptions.java

@@ -174,7 +174,7 @@ public boolean isInitializeLazyStateOutsideTransactionsEnabled() {
 		return delegate.isInitializeLazyStateOutsideTransactionsEnabled();
 	}
 
-	@Override
+	@Override @Deprecated
 	public TempTableDdlTransactionHandling getTempTableDdlTransactionHandling() {
 		return delegate.getTempTableDdlTransactionHandling();
 	}
@@ -294,7 +294,7 @@ public boolean isAutoEvictCollectionCache() {
 		return delegate.isAutoEvictCollectionCache();
 	}
 
-	@Override
+	@Override @Deprecated
 	public SchemaAutoTooling getSchemaAutoTooling() {
 		return delegate.getSchemaAutoTooling();
 	}

hibernate-core/src/main/java/org/hibernate/boot/spi/SessionFactoryOptions.java

@@ -190,6 +190,10 @@ default boolean isAllowRefreshDetachedEntity() {
 	 */
 	boolean isInitializeLazyStateOutsideTransactionsEnabled();
 
+	/**
+	 * This is unused and will be removed.
+	 */
+	@Deprecated(since = "7.0", forRemoval = true)
 	TempTableDdlTransactionHandling getTempTableDdlTransactionHandling();
 
 	/**
@@ -290,6 +294,12 @@ default boolean isAllowRefreshDetachedEntity() {
 	 */
 	boolean isAutoEvictCollectionCache();
 
+	/**
+	 * @see org.hibernate.cfg.AvailableSettings#HBM2DDL_AUTO
+	 *
+	 * @deprecated This is unused and will be removed.
+	 */
+	@Deprecated(since = "7.0", forRemoval = true)
 	SchemaAutoTooling getSchemaAutoTooling();
 
 	/**

hibernate-core/src/main/java/org/hibernate/dialect/Dialect.java

@@ -3562,7 +3562,10 @@ public String getCreateTemporaryTableColumnAnnotation(int sqlTypeCode) {
 	/**
 	 * The sort of {@linkplain TempTableDdlTransactionHandling transaction handling}
 	 * to use when creating or dropping temporary tables.
+	 *
+	 * @deprecated No dialect currently overrides this, so it's obsolete
 	 */
+	@Deprecated(since = "7.0")
 	public TempTableDdlTransactionHandling getTemporaryTableDdlTransactionHandling() {
 		return TempTableDdlTransactionHandling.NONE;
 	}

hibernate-core/src/main/java/org/hibernate/dialect/DialectDelegateWrapper.java

@@ -924,7 +924,7 @@ public String getCreateTemporaryTableColumnAnnotation(int sqlTypeCode) {
 		return wrapped.getCreateTemporaryTableColumnAnnotation( sqlTypeCode );
 	}
 
-	@Override
+	@Override @Deprecated
 	public TempTableDdlTransactionHandling getTemporaryTableDdlTransactionHandling() {
 		return wrapped.getTemporaryTableDdlTransactionHandling();
 	}