Skip to content

Commit 1741e0f

Browse files
jmartisksebersole
authored andcommitted
HHH-10195 fix QueryHintSQLServer2012Test
(cherry picked from commit 06311d3)
1 parent 01c3589 commit 1741e0f

File tree

1 file changed

+10
-7
lines changed

1 file changed

+10
-7
lines changed

hibernate-core/src/test/java/org/hibernate/test/queryhint/QueryHintSQLServer2012Test.java

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ public void testQueryHint() {
6565

6666
// test Query w/ a simple SQLServer2012 optimizer hint
6767
s.getTransaction().begin();
68-
Query query = s.createQuery( "FROM QueryHintTest$Employee e WHERE e.department.name = :departmentName" ).addQueryHint( "MAXDOP 2" )
68+
Query query = s.createQuery( "FROM QueryHintSQLServer2012Test$Employee e WHERE e.department.name = :departmentName" ).addQueryHint( "MAXDOP 2" )
6969
.setParameter( "departmentName", "Sales" );
7070
List results = query.list();
7171
s.getTransaction().commit();
@@ -78,21 +78,25 @@ public void testQueryHint() {
7878

7979
// test multiple hints
8080
s.getTransaction().begin();
81-
query = s.createQuery( "FROM QueryHintTest$Employee e WHERE e.department.name = :departmentName" ).addQueryHint( "MAXDOP 2" )
82-
.addQueryHint( "USE_CONCAT" ).setParameter( "departmentName", "Sales" );
81+
query = s.createQuery( "FROM QueryHintSQLServer2012Test$Employee e WHERE e.department.name = :departmentName" )
82+
.addQueryHint("MAXDOP 2")
83+
.addQueryHint("CONCAT UNION")
84+
.setParameter("departmentName", "Sales");
8385
results = query.list();
8486
s.getTransaction().commit();
8587
s.clear();
8688

8789
assertEquals( results.size(), 2 );
88-
assertTrue( QueryHintTestSQLServer2012Dialect.getProcessedSql().contains( "OPTION (MAXDOP 2)" ) );
90+
assertTrue( QueryHintTestSQLServer2012Dialect.getProcessedSql().contains( "MAXDOP 2" ) );
91+
assertTrue( QueryHintTestSQLServer2012Dialect.getProcessedSql().contains( "CONCAT UNION" ) );
8992

9093
QueryHintTestSQLServer2012Dialect.resetProcessedSql();
9194

9295
// ensure the insertion logic can handle a comment appended to the front
9396
s.getTransaction().begin();
94-
query = s.createQuery( "FROM QueryHintTest$Employee e WHERE e.department.name = :departmentName" ).setComment( "this is a test" )
95-
.addQueryHint( "MAXDOP 2" ).setParameter( "departmentName", "Sales" );
97+
query = s.createQuery( "FROM QueryHintSQLServer2012Test$Employee e WHERE e.department.name = :departmentName" ).setComment( "this is a test" )
98+
.addQueryHint( "MAXDOP 2" )
99+
.setParameter( "departmentName", "Sales" );
96100
results = query.list();
97101
s.getTransaction().commit();
98102
s.clear();
@@ -112,7 +116,6 @@ public void testQueryHint() {
112116

113117
assertEquals( results.size(), 2 );
114118
assertTrue( QueryHintTestSQLServer2012Dialect.getProcessedSql().contains( "OPTION (MAXDOP 2)" ) );
115-
assertEquals( false, true );
116119
}
117120

118121
/**

0 commit comments

Comments
 (0)