Revert "special handling for literal null inside a cast in select clause"

This reverts commit 150d4f8.

Author: gavinking

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/InformixSqlAstTranslator.java

@@ -245,7 +245,7 @@ public void visitValuesTableReference(ValuesTableReference tableReference) {
 	protected boolean shouldEmulateFetchClause(QueryPart queryPart) {
 		// Check if current query part is already row numbering to avoid infinite recursion
 		return useOffsetFetchClause( queryPart ) && getQueryPartForRowNumbering() != queryPart
-			&& getDialect().supportsWindowFunctions() && !isRowsOnlyFetchClauseType( queryPart );
+			   && getDialect().supportsWindowFunctions() && !isRowsOnlyFetchClauseType( queryPart );
 	}
 
 	@Override

hibernate-core/src/main/java/org/hibernate/dialect/function/CastFunction.java

@@ -77,9 +77,6 @@ public void render(
 			renderCastArrayToString( sqlAppender, arguments.get( 0 ), dialect, walker );
 		}
 		else {
-			if ( source instanceof QueryLiteral<?> literal && literal.getLiteralValue() == null ) {
-				literal.setInCast(true);
-			}
 			new PatternRenderer( dialect.castPattern( sourceType, targetType ) )
 					.render( sqlAppender, arguments, walker );
 		}

hibernate-core/src/main/java/org/hibernate/sql/ast/spi/AbstractSqlAstTranslator.java

@@ -7503,12 +7503,7 @@ public void visitJdbcLiteral(JdbcLiteral<?> jdbcLiteral) {
 
 	@Override
 	public void visitQueryLiteral(QueryLiteral<?> queryLiteral) {
-		if ( queryLiteral.getLiteralValue() == null && queryLiteral.isInCast() ) {
-			appendSql( SqlAppender.NULL_KEYWORD );
-		}
-		else {
-			visitLiteral( queryLiteral );
-		}
+		visitLiteral( queryLiteral );
 	}
 
 	@Override

hibernate-core/src/main/java/org/hibernate/sql/ast/tree/expression/QueryLiteral.java

@@ -30,7 +30,6 @@
 public class QueryLiteral<T> implements Literal, DomainResultProducer<T> {
 	private final T value;
 	private final SqlExpressible expressible;
-	private boolean inCast;
 
 	public QueryLiteral(T value, SqlExpressible expressible) {
 		assert value == null || expressible.getJdbcMapping().getJdbcJavaType().isInstance( value );
@@ -101,12 +100,4 @@ public void applySqlSelections(DomainResultCreationState creationState) {
 				creationState.getSqlAstCreationState().getCreationContext().getMappingMetamodel().getTypeConfiguration()
 		);
 	}
-
-	public void setInCast(boolean inCast) {
-		this.inCast = inCast;
-	}
-
-	public boolean isInCast() {
-		return inCast;
-	}
 }