HHH-16516 no need to quote a $ except at the start of column/table name

Author: gavinking

hibernate-core/src/main/java/org/hibernate/boot/model/naming/Identifier.java

@@ -112,7 +112,7 @@ else if ( quoteOnNonIdentifierChar && !quote ) {
 			else {
 				for ( int i = start + 1; i < end; i++ ) {
 					c = text.charAt( i );
-					if ( !isLetterOrDigit( c ) && c != '_' ) {
+					if ( !isLetterOrDigit( c ) && c != '_' && c != '$' ) {
 						quote = true;
 						break;
 					}

hibernate-core/src/test/java/org/hibernate/orm/test/mapping/autoquote/SpecialCharactersTest.java

@@ -0,0 +1,31 @@
+/*
+ * SPDX-License-Identifier: LGPL-2.1-or-later
+ * Copyright Red Hat Inc. and Hibernate Authors
+ */
+package org.hibernate.orm.test.mapping.autoquote;
+
+import jakarta.persistence.Column;
+import jakarta.persistence.Entity;
+import jakarta.persistence.Id;
+import org.hibernate.testing.orm.junit.EntityManagerFactoryScope;
+import org.hibernate.testing.orm.junit.Jpa;
+import org.junit.jupiter.api.Test;
+
+@Jpa(annotatedClasses = SpecialCharactersTest.Simple.class)
+public class SpecialCharactersTest {
+	@Test void test(EntityManagerFactoryScope scope) {
+		scope.getEntityManagerFactory();
+	}
+	@Entity static class Simple {
+		@Id
+		long id;
+		@Column(name="NAME$NAME")
+		String nameWithDollar;
+		@Column(name="$NAME")
+		String nameWithInitialDollar;
+		@Column(name="NAME#NAME")
+		String nameWithHash;
+		@Column(name="NAME NAME")
+		String nameWithSpace;
+	}
+}