Skip to content

Commit 1b44ae5

Browse files
committed
use @SkipForDialect like in all other tests
and skip the test also on Informix
1 parent b20aa54 commit 1b44ae5

File tree

1 file changed

+10
-9
lines changed

1 file changed

+10
-9
lines changed

hibernate-core/src/test/java/org/hibernate/orm/test/query/sql/NativeQueryResultBuilderTests.java

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
import java.time.Instant;
1111
import java.util.List;
1212

13+
import org.hibernate.community.dialect.InformixDialect;
1314
import org.hibernate.dialect.DB2Dialect;
1415
import org.hibernate.community.dialect.DerbyDialect;
1516
import org.hibernate.dialect.OracleDialect;
@@ -20,6 +21,7 @@
2021
import org.hibernate.metamodel.mapping.internal.BasicAttributeMapping;
2122
import org.hibernate.query.NativeQuery;
2223
import org.hibernate.testing.orm.domain.gambit.BasicEntity;
24+
import org.hibernate.testing.orm.junit.SkipForDialect;
2325
import org.hibernate.type.descriptor.converter.spi.JpaAttributeConverter;
2426
import org.hibernate.type.descriptor.jdbc.spi.JdbcTypeRegistry;
2527

@@ -34,7 +36,6 @@
3436
import org.junit.jupiter.api.BeforeEach;
3537
import org.junit.jupiter.api.Test;
3638

37-
import org.assertj.core.api.Assumptions;
3839
import org.hamcrest.CustomMatcher;
3940
import org.hamcrest.Matcher;
4041

@@ -79,17 +80,17 @@ public void fullyImplicitTest(SessionFactoryScope scope) {
7980
}
8081

8182
@Test
83+
// DB2, Derby, SQL Server and Sybase return an Integer for count by default
84+
// Oracle returns a NUMERIC(39,0) i.e. a BigDecimal for count by default
85+
@SkipForDialect(dialectClass = DB2Dialect.class)
86+
@SkipForDialect(dialectClass = DerbyDialect.class)
87+
@SkipForDialect(dialectClass = SQLServerDialect.class)
88+
@SkipForDialect(dialectClass = SybaseDialect.class, matchSubTypes = true)
89+
@SkipForDialect(dialectClass = OracleDialect.class)
90+
@SkipForDialect(dialectClass = InformixDialect.class)
8291
public void fullyImplicitTest2(SessionFactoryScope scope) {
8392
scope.inTransaction(
8493
session -> {
85-
// DB2, Derby, SQL Server and Sybase return an Integer for count by default
86-
// Oracle returns a NUMERIC(39,0) i.e. a BigDecimal for count by default
87-
Assumptions.assumeThat( session.getJdbcServices().getDialect() )
88-
.isNotInstanceOf( DB2Dialect.class )
89-
.isNotInstanceOf( DerbyDialect.class )
90-
.isNotInstanceOf( SQLServerDialect.class )
91-
.isNotInstanceOf( SybaseDialect.class )
92-
.isNotInstanceOf( OracleDialect.class );
9394
final String sql = "select count(the_string) from EntityOfBasics";
9495
final NativeQuery<?> query = session.createNativeQuery( sql );
9596

0 commit comments

Comments
 (0)