HHH-19846 - Drop JUnit 4 usage

Not converted...
* org.hibernate.orm.test.hql.PostgreSQLFunctionSelectClauseTest - registering custom function
* org.hibernate.orm.test.hql.PostgreSQLFunctionWhereClauseTest - aux-db-object
* org.hibernate.orm.test.id.usertype - type registrations
* org.hibernate.orm.test.idgen.enhanced.HiloOptimizerConcurrencyTest - recreation of SF during tests
* org.hibernate.orm.test.type.AbstractJavaTimeTypeTest subtypes - crazy parameterization (see org.hibernate.orm.test.tm.InterceptorTransactionTest)
* org.hibernate.orm.test.cdi.general.hibernatesearch.extended.HibernateSearchExtendedCdiSupportTest - not sure yet, all the other tests here pass with conversion - shelved for now

Author: sebersole

hibernate-core/src/test/java/org/hibernate/orm/test/entitymode/map/basic/DynamicClassTest.java

@@ -8,6 +8,7 @@
 import org.hibernate.testing.orm.junit.DomainModel;
 import org.hibernate.testing.orm.junit.SessionFactory;
 import org.hibernate.testing.orm.junit.SessionFactoryScope;
+import org.junit.jupiter.api.AfterEach;
 import org.junit.jupiter.api.Test;
 
 import java.util.ArrayList;
@@ -25,11 +26,16 @@
 /**
  * @author Gavin King
  */
+@SuppressWarnings("JUnitMalformedDeclaration")
 @SessionFactory
 @DomainModel(
 		xmlMappings = "org/hibernate/orm/test/entitymode/map/basic/ProductLine.hbm.xml"
 )
 class DynamicClassTest {
+	@AfterEach
+	void tearDown(SessionFactoryScope factoryScope) {
+		factoryScope.dropData();
+	}
 
 	@Test
 	void testLazyDynamicClass(SessionFactoryScope scope) {

hibernate-core/src/test/java/org/hibernate/orm/test/entitymode/map/compositeId/CompositeIdTest.java

@@ -10,18 +10,24 @@
 import org.hibernate.testing.orm.junit.DomainModel;
 import org.hibernate.testing.orm.junit.SessionFactory;
 import org.hibernate.testing.orm.junit.SessionFactoryScope;
+import org.junit.jupiter.api.AfterEach;
 import org.junit.jupiter.api.Test;
 
 import static org.hamcrest.CoreMatchers.is;
 import static org.hamcrest.MatcherAssert.assertThat;
 import static org.junit.jupiter.api.Assertions.assertNotNull;
 
+@SuppressWarnings("JUnitMalformedDeclaration")
 @DomainModel(
 		xmlMappings = "org/hibernate/orm/test/entitymode/map/compositeId/CompId.hbm.xml"
 )
 @SessionFactory
 @JiraKey(value = "HHH-15201")
 public class CompositeIdTest {
+	@AfterEach
+	void tearDown(SessionFactoryScope factoryScope) {
+		factoryScope.dropData();
+	}
 
 	@Test
 	public void testImplicitCompositeIdInDynamicMapMode(SessionFactoryScope scope) {

hibernate-core/src/test/java/org/hibernate/orm/test/entitymode/map/subclass/SubclassDynamicMapTest.java

@@ -4,40 +4,30 @@
  */
 package org.hibernate.orm.test.entitymode.map.subclass;
 
-import java.util.HashMap;
-
-import org.junit.Test;
+import org.hibernate.testing.orm.junit.DomainModel;
+import org.hibernate.testing.orm.junit.SessionFactory;
+import org.hibernate.testing.orm.junit.SessionFactoryScope;
+import org.junit.jupiter.api.AfterEach;
+import org.junit.jupiter.api.Test;
 
-import org.hibernate.Session;
-import org.hibernate.testing.junit4.BaseCoreFunctionalTestCase;
+import java.util.HashMap;
 
 /**
  * @author Steve Ebersole
  */
-public class SubclassDynamicMapTest extends BaseCoreFunctionalTestCase {
-
-	@Override
-	protected String getBaseForMappings() {
-		return "org/hibernate/orm/test/";
-	}
-
-	@Override
-	public String[] getMappings() {
-		return new String[] { "entitymode/map/subclass/Mappings.hbm.xml" };
+@SuppressWarnings("JUnitMalformedDeclaration")
+@DomainModel(xmlMappings = "org/hibernate/orm/test/entitymode/map/subclass/Mappings.hbm.xml")
+@SessionFactory
+public class SubclassDynamicMapTest {
+	@AfterEach
+	void tearDown(SessionFactoryScope factoryScope) {
+		factoryScope.dropData();
 	}
 
 	@Test
-	public void testConcreateSubclassDeterminationOnEmptyDynamicMap() {
-		Session s = openSession();
-		s.beginTransaction();
-		s.persist( "Superclass", new HashMap() );
-		s.getTransaction().commit();
-		s.close();
-
-		s = openSession();
-		s.beginTransaction();
-		s.createQuery( "delete Superclass" ).executeUpdate();
-		s.getTransaction().commit();
-		s.close();
+	public void testConcreteSubclassDeterminationOnEmptyDynamicMap(SessionFactoryScope factoryScope) {
+		factoryScope.inTransaction( (session) -> {
+			session.persist( "Superclass", new HashMap() );
+		} );
 	}
 }