HHH-17155 More precise primitive type assignment compatibility check

Author: mbellade

hibernate-core/src/main/java/org/hibernate/query/sqm/tree/expression/Compatibility.java

@@ -102,14 +102,14 @@ else if ( to == byte.class ) {
 		}
 		else if ( isIntegralTypePrimitive( to ) ) {
 			return from == byte.class
-					|| isIntegralTypePrimitive( from )
+					|| isCompatibleIntegralTypePrimitive( to, from )
 					// this would for sure cause loss of precision
 					|| isFloatingTypePrimitive( from );
 		}
 		else if ( isFloatingTypePrimitive( to ) ) {
 			return from == byte.class
 					|| isIntegralTypePrimitive( from )
-					|| isFloatingTypePrimitive( from );
+					|| isCompatibleFloatingTypePrimitive( to, from );
 		}
 
 		return false;
@@ -133,6 +133,22 @@ private static boolean isIntegralTypePrimitive(Class potentialIntegral) {
 				|| potentialIntegral == long.class;
 	}
 
+	private static boolean isCompatibleIntegralTypePrimitive(Class to, Class from) {
+		assert isIntegralTypePrimitive( to );
+		assert from.isPrimitive();
+
+		if ( to == short.class ) {
+			return from == short.class;
+		}
+		else if ( to == int.class ) {
+			return from == short.class
+					|| from == int.class;
+		}
+		else {
+			return isIntegralTypePrimitive( from );
+		}
+	}
+
 	public static boolean isFloatingType(Class potentialFloating) {
 		if ( potentialFloating.isPrimitive() ) {
 			return isFloatingTypePrimitive( potentialFloating );
@@ -150,6 +166,18 @@ private static boolean isFloatingTypePrimitive(Class potentialFloating) {
 				|| potentialFloating == double.class;
 	}
 
+	private static boolean isCompatibleFloatingTypePrimitive(Class to, Class from) {
+		assert isFloatingTypePrimitive( to );
+		assert from.isPrimitive();
+
+		if ( to == float.class ) {
+			return from == float.class;
+		}
+		else {
+			return isFloatingTypePrimitive( from );
+		}
+	}
+
 	public static boolean areAssignmentCompatible(
 			JavaType to,
 			JavaType from) {