HHH-19653 replace lost test

Author: gavinking

hibernate-c3p0/src/test/java/org/hibernate/test/c3p0/C3P0DefaultIsolationLevelTest.java

@@ -11,7 +11,6 @@
 import jakarta.persistence.Id;
 
 import org.hibernate.boot.SessionFactoryBuilder;
-import org.hibernate.cfg.AvailableSettings;
 import org.hibernate.dialect.H2Dialect;
 
 import org.hibernate.testing.RequiresDialect;
@@ -20,6 +19,8 @@
 import org.hibernate.testing.junit4.BaseNonConfigCoreFunctionalTestCase;
 import org.junit.Test;
 
+import static org.hibernate.cfg.JdbcSettings.CONNECTION_PROVIDER;
+import static org.hibernate.cfg.JdbcSettings.ISOLATION;
 import static org.hibernate.testing.transaction.TransactionUtil.doInHibernate;
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertTrue;
@@ -52,8 +53,8 @@ protected Class<?>[] getAnnotatedClasses() {
 	@Override
 	protected void addSettings(Map<String,Object> settings) {
 		connectionProvider = new C3P0ProxyConnectionProvider();
-		settings.put( AvailableSettings.CONNECTION_PROVIDER, connectionProvider );
-		settings.put( AvailableSettings.ISOLATION, "READ_COMMITTED" );
+		settings.put( CONNECTION_PROVIDER, connectionProvider );
+		settings.put( ISOLATION, "READ_COMMITTED" );
 	}
 
 	@Test

hibernate-c3p0/src/test/java/org/hibernate/test/c3p0/C3P0DifferentIsolationLevelTest.java

@@ -11,7 +11,6 @@
 import jakarta.persistence.Id;
 
 import org.hibernate.boot.SessionFactoryBuilder;
-import org.hibernate.cfg.AvailableSettings;
 import org.hibernate.dialect.H2Dialect;
 
 import org.hibernate.testing.RequiresDialect;
@@ -20,6 +19,8 @@
 import org.hibernate.testing.junit4.BaseNonConfigCoreFunctionalTestCase;
 import org.junit.Test;
 
+import static org.hibernate.cfg.JdbcSettings.CONNECTION_PROVIDER;
+import static org.hibernate.cfg.JdbcSettings.ISOLATION;
 import static org.hibernate.testing.transaction.TransactionUtil.doInHibernate;
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertTrue;
@@ -52,8 +53,8 @@ protected Class<?>[] getAnnotatedClasses() {
 	@Override
 	protected void addSettings(Map<String,Object> settings) {
 		connectionProvider = new C3P0ProxyConnectionProvider();
-		settings.put( AvailableSettings.CONNECTION_PROVIDER, connectionProvider );
-		settings.put( AvailableSettings.ISOLATION, "REPEATABLE_READ" );
+		settings.put( CONNECTION_PROVIDER, connectionProvider );
+		settings.put( ISOLATION, "REPEATABLE_READ" );
 	}
 
 	@Test

hibernate-c3p0/src/test/java/org/hibernate/test/c3p0/C3P0EmptyIsolationLevelTest.java

@@ -0,0 +1,104 @@
+/*
+ * SPDX-License-Identifier: Apache-2.0
+ * Copyright Red Hat Inc. and Hibernate Authors
+ */
+package org.hibernate.test.c3p0;
+
+import jakarta.persistence.Entity;
+import jakarta.persistence.Id;
+import org.hibernate.boot.SessionFactoryBuilder;
+import org.hibernate.dialect.H2Dialect;
+import org.hibernate.testing.RequiresDialect;
+import org.hibernate.testing.jdbc.SQLStatementInterceptor;
+import org.hibernate.testing.junit4.BaseNonConfigCoreFunctionalTestCase;
+import org.hibernate.testing.orm.junit.JiraKey;
+import org.junit.Test;
+
+import java.sql.Connection;
+import java.sql.SQLException;
+import java.util.Map;
+
+import static org.hibernate.cfg.JdbcSettings.CONNECTION_PROVIDER;
+import static org.hibernate.cfg.JdbcSettings.ISOLATION;
+import static org.hibernate.testing.transaction.TransactionUtil.doInHibernate;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertTrue;
+import static org.mockito.Mockito.never;
+import static org.mockito.Mockito.verify;
+
+/**
+ * @author Vlad Mihalcea
+ */
+@JiraKey(value = "HHH-12749")
+@RequiresDialect(H2Dialect.class)
+public class C3P0EmptyIsolationLevelTest extends
+		BaseNonConfigCoreFunctionalTestCase {
+
+	private C3P0ProxyConnectionProvider connectionProvider;
+	private SQLStatementInterceptor sqlStatementInterceptor;
+
+	@Override
+	protected void configureSessionFactoryBuilder(SessionFactoryBuilder sfb) {
+		sqlStatementInterceptor = new SQLStatementInterceptor( sfb );
+	}
+
+	@Override
+	protected Class<?>[] getAnnotatedClasses() {
+		return new Class<?>[] {
+				Person.class,
+		};
+	}
+
+	@Override
+	protected void addSettings(Map<String,Object> settings) {
+		connectionProvider = new C3P0ProxyConnectionProvider();
+		settings.put( CONNECTION_PROVIDER, connectionProvider );
+		settings.put( ISOLATION, "" );
+	}
+
+	@Test
+	public void testStoredProcedureOutParameter() throws SQLException {
+		clearSpies();
+
+		doInHibernate( this::sessionFactory, session -> {
+			Person person = new Person();
+			person.id = 1L;
+			person.name = "Vlad Mihalcea";
+
+			session.persist( person );
+		} );
+
+		assertEquals( 1, sqlStatementInterceptor.getSqlQueries().size() );
+		assertTrue( sqlStatementInterceptor.getSqlQueries().get( 0 ).toLowerCase().startsWith( "insert into" ) );
+		Connection connectionSpy = connectionProvider.getConnectionSpyMap().keySet().iterator().next();
+		verify( connectionSpy, never() ).setTransactionIsolation( Connection.TRANSACTION_READ_COMMITTED );
+
+		clearSpies();
+
+		doInHibernate( this::sessionFactory, session -> {
+			Person person = session.find( Person.class, 1L );
+
+			assertEquals( "Vlad Mihalcea", person.name );
+		} );
+
+		assertEquals( 1, sqlStatementInterceptor.getSqlQueries().size() );
+		assertTrue( sqlStatementInterceptor.getSqlQueries().get( 0 ).toLowerCase().startsWith( "select" ) );
+		connectionSpy = connectionProvider.getConnectionSpyMap().keySet().iterator().next();
+		verify( connectionSpy, never() ).setTransactionIsolation( Connection.TRANSACTION_READ_COMMITTED );
+	}
+
+	private void clearSpies() {
+		sqlStatementInterceptor.getSqlQueries().clear();
+		connectionProvider.clear();
+	}
+
+	@Entity(name = "Person")
+	public static class Person {
+
+		@Id
+		private Long id;
+
+		private String name;
+	}
+
+}