HHH-18968 Fix localtime return type for MySQL

Author: beikov

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/MySQLLegacyDialect.java

@@ -618,10 +618,7 @@ public void initializeFunctionRegistry(FunctionContributions functionContributio
 		BasicTypeRegistry basicTypeRegistry = functionContributions.getTypeConfiguration().getBasicTypeRegistry();
 
 		SqmFunctionRegistry functionRegistry = functionContributions.getFunctionRegistry();
-		functionRegistry.noArgsBuilder( "localtime" )
-				.setInvariantType(basicTypeRegistry.resolve( StandardBasicTypes.TIMESTAMP ))
-				.setUseParenthesesWhenNoArgs( false )
-				.register();
+
 		// pi() produces a value with 7 digits unless we're explicit
 		if ( getMySQLVersion().isSameOrAfter( 8 ) ) {
 			functionRegistry.patternDescriptorBuilder( "pi", "cast(pi() as double)" )

hibernate-core/src/main/java/org/hibernate/dialect/MySQLDialect.java

@@ -634,11 +634,6 @@ public void initializeFunctionRegistry(FunctionContributions functionContributio
 
 		SqmFunctionRegistry functionRegistry = functionContributions.getFunctionRegistry();
 
-		functionRegistry.noArgsBuilder( "localtime" )
-				.setInvariantType(basicTypeRegistry.resolve( StandardBasicTypes.TIMESTAMP ))
-				.setUseParenthesesWhenNoArgs( false )
-				.register();
-
 		// pi() produces a value with 7 digits unless we're explicit
 		functionRegistry.patternDescriptorBuilder( "pi", "cast(pi() as double)" )
 				.setInvariantType( basicTypeRegistry.resolve( StandardBasicTypes.DOUBLE ) )

hibernate-core/src/test/java/org/hibernate/orm/test/temporal/MySQLTimestampFspFunctionTest.java

@@ -4,6 +4,7 @@
  */
 package org.hibernate.orm.test.temporal;
 
+import java.sql.Time;
 import java.sql.Timestamp;
 
 import org.hibernate.dialect.MySQLDialect;
@@ -16,6 +17,7 @@
 import org.hibernate.testing.orm.junit.SessionFactory;
 import org.hibernate.testing.orm.junit.SessionFactoryScope;
 
+import org.hibernate.type.descriptor.java.JdbcTimeJavaType;
 import org.junit.jupiter.api.Test;
 
 import static org.junit.Assert.assertEquals;
@@ -46,11 +48,13 @@ public void testTimeStampFunctions(SessionFactoryScope scope) {
 					);
 					Object[] oArray = (Object[]) q.uniqueResult();
 					for ( Object o : oArray ) {
-						( (Timestamp) o ).setNanos( 0 );
+						if ( o instanceof Timestamp ts ) {
+							ts.setNanos( 0 );
+						}
 					}
 					final Timestamp now = (Timestamp) oArray[0];
 					assertEquals( now, oArray[1] );
-					assertEquals( now, oArray[2] );
+					assertTrue( JdbcTimeJavaType.INSTANCE.areEqual( new Time( now.getTime() ), (Time) oArray[2] ) );
 					assertEquals( now, oArray[3] );
 					assertTrue( now.compareTo( (Timestamp) oArray[4] ) <= 0 );
 				}