HHH-19396 Parameter deduplicateSelectionItems must be set only for temporary tables and subqueries

          Selection items representing same column in (sub)query will be represented with single instance, this will hide real alias

Author: cigaly

hibernate-core/src/main/java/org/hibernate/query/sqm/internal/ConcreteSqmSelectQueryPlan.java

@@ -491,7 +491,7 @@ private static CacheableSqmInterpretation buildCacheableSqmInterpretation(
 								executionContext.getQueryParameterBindings(),
 								executionContext.getSession().getLoadQueryInfluencers(),
 								sessionFactory.getSqlTranslationEngine(),
-								true
+								sqm.getCteStatements().isEmpty()
 						)
 						.translate();
 

hibernate-core/src/main/java/org/hibernate/query/sqm/tree/cte/SqmCteTable.java

@@ -34,13 +34,14 @@ public class SqmCteTable<T> extends AnonymousTupleType<T> implements JpaCteCrite
 	private SqmCteTable(
 			String name,
 			SqmCteStatement<T> cteStatement,
-			SqmSelectableNode<?>[] sqmSelectableNodes) {
-		super( sqmSelectableNodes );
+			SqmSelectableNode<?>[] sqmSelectableNodes,
+			List<String> aliases) {
+		super( sqmSelectableNodes, aliases );
 		this.name = name;
 		this.cteStatement = cteStatement;
 		final List<SqmCteTableColumn> columns = new ArrayList<>( componentCount() );
 		for ( int i = 0; i < componentCount(); i++ ) {
-			columns.add( new SqmCteTableColumn( this, getComponentName(i), get(i) ) );
+			columns.add( new SqmCteTableColumn( this, aliases.get(i), get(i) ) );
 		}
 		this.columns = columns;
 	}
@@ -54,7 +55,7 @@ public static <X> SqmCteTable<X> createStatementTable(
 				.getSelectClause()
 				.getSelectionItems()
 				.toArray( SqmSelectableNode[]::new );
-		return new SqmCteTable<>( name, cteStatement, sqmSelectableNodes );
+		return new SqmCteTable<>( name, cteStatement, sqmSelectableNodes, extractAliases(selectStatement) );
 	}
 
 	@Override

hibernate-core/src/main/java/org/hibernate/query/sqm/tuple/internal/AnonymousTupleType.java

@@ -22,6 +22,7 @@
 import org.hibernate.query.sqm.SqmPathSource;
 import org.hibernate.query.sqm.tree.domain.SqmDomainType;
 import org.hibernate.query.sqm.tree.domain.SqmPluralPersistentAttribute;
+import org.hibernate.query.sqm.tree.select.SqmSelectQuery;
 import org.hibernate.query.sqm.tuple.TupleType;
 import org.hibernate.query.SemanticException;
 import org.hibernate.query.sqm.SqmExpressible;
@@ -56,10 +57,10 @@ public class AnonymousTupleType<T>
 	private final Map<String, Integer> componentIndexMap;
 
 	public AnonymousTupleType(SqmSubQuery<T> subQuery) {
-		this( extractSqmExpressibles( subQuery ) );
+		this( extractSqmExpressibles( subQuery ), extractAliases( subQuery ) );
 	}
 
-	public AnonymousTupleType(SqmSelectableNode<?>[] components) {
+	public AnonymousTupleType(SqmSelectableNode<?>[] components, List<String> aliases) {
 		expressibles = new SqmBindableType<?>[components.length];
 		componentSourcePaths = new NavigablePath[components.length];
 		for ( int i = 0; i < components.length; i++ ) {
@@ -74,7 +75,10 @@ public AnonymousTupleType(SqmSelectableNode<?>[] components) {
 		componentIndexMap = linkedMapOfSize( components.length );
 		for ( int i = 0; i < components.length; i++ ) {
 			final SqmSelectableNode<?> component = components[i];
-			final String alias = component.getAlias();
+			String alias = aliases == null ? null : aliases.get( i );
+			if ( alias == null ) {
+				alias = component.getAlias();
+			}
 			if ( alias == null ) {
 				throw new SemanticException( "Select item at position " + (i+1) + " in select list has no alias"
 						+ " (aliases are required in CTEs and in subqueries occurring in from clause)" );
@@ -121,6 +125,20 @@ private static SqmSelectableNode<?>[] extractSqmExpressibles(SqmSubQuery<?> subQ
 		return selectClause.getSelectionItems().toArray( SqmSelectableNode[]::new );
 	}
 
+	protected static List<String> extractAliases(SqmSelectQuery<?> subQuery) {
+		final SqmSelectClause selectClause = subQuery.getQueryPart()
+				.getFirstQuerySpec()
+				.getSelectClause();
+		final var aliases = new ArrayList<String>();
+		for (final var selection : selectClause.getSelections()) {
+			final var alias = selection.getAlias();
+			selection.getSelectableNode().visitSubSelectableNodes( node ->
+					aliases.add( alias == null ? node.getAlias() : alias )
+			);
+		}
+		return aliases;
+	}
+
 	private static JavaType<?>[] getTypeDescriptors(SqmSelectableNode<?>[] components) {
 		final JavaType<?>[] typeDescriptors = new JavaType<?>[components.length];
 		for ( int i = 0; i < components.length; i++ ) {