HHH-18976 Use .clone() instead of Arrays#copyOf where possible

Author: yrodiere

hibernate-core/src/main/java/org/hibernate/sql/results/jdbc/internal/JdbcValuesResultSetImpl.java

@@ -17,7 +17,6 @@
 import org.hibernate.engine.spi.SharedSessionContractImplementor;
 import org.hibernate.exception.DataException;
 import org.hibernate.exception.LockTimeoutException;
-import org.hibernate.internal.build.AllowReflection;
 import org.hibernate.query.spi.Limit;
 import org.hibernate.query.spi.QueryOptions;
 import org.hibernate.sql.ast.spi.SqlSelection;
@@ -347,15 +346,14 @@ public boolean usesFollowOnLocking() {
 	}
 
 	@Override
-	@AllowReflection
 	public void finishRowProcessing(RowProcessingState rowProcessingState, boolean wasAdded) {
 		if ( queryCachePutManager != null ) {
 			if ( wasAdded ) {
 				resultCount++;
 			}
 			final Object objectToCache;
 			if ( valueIndexesToCacheIndexes == null ) {
-				objectToCache = Arrays.copyOf( currentRowJdbcValues, currentRowJdbcValues.length );
+				objectToCache = currentRowJdbcValues.clone();
 			}
 			else if ( rowToCacheSize < 1 ) {
 				if ( !wasAdded ) {

rules/forbidden-apis.txt

@@ -15,7 +15,7 @@ org.hibernate.internal.util.collections.ArrayHelper#newInstance(java.lang.Class,
 org.hibernate.internal.util.collections.ArrayHelper#filledArray(java.lang.Object, java.lang.Class, int)
 org.hibernate.internal.util.collections.ArrayHelper#join(java.lang.Object[], java.lang.Object[])
 
-@defaultMessage Use a type-specific 'ArrayHelper.copyOf' instead if possible. This forbidden method requires reflection and may not work in natively compiled applications. If you really must use this forbidden method, annotate the calling method with @AllowReflection.
+@defaultMessage Use '.clone()' or a type-specific 'ArrayHelper.copyOf' instead if possible. This forbidden method requires reflection and may not work in natively compiled applications. If you really must use this forbidden method, annotate the calling method with @AllowReflection.
 
 java.util.Arrays#copyOf(java.lang.Object[], int)
 java.util.Arrays#copyOf(java.lang.Object[], int, java.lang.Class)