HHH-19260 - Move supportsJoinInMutationStatementSubquery() from AbstractSqlAstTranslator to Dialect

Signed-off-by: Jan Schatteman <[email protected]>

Author: jrenaat

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/DerbyDialect.java

@@ -1072,4 +1072,9 @@ public String getFromDualForSelectOnly() {
 		return " from " + getDual() + " dual";
 	}
 
+	@Override
+	public boolean supportsJoinInMutationStatementSubquery() {
+		return false;
+	}
+
 }

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/DerbyLegacyDialect.java

@@ -1077,4 +1077,10 @@ public String getDual() {
 	public String getFromDualForSelectOnly() {
 		return " from " + getDual() + " dual";
 	}
+
+	@Override
+	public boolean supportsJoinInMutationStatementSubquery() {
+		return false;
+	}
+
 }

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/DerbyLegacySqlAstTranslator.java

@@ -317,11 +317,6 @@ private boolean supportsOffsetFetchClause() {
 		return getDialect().getVersion().isSameOrAfter( 10, 5 );
 	}
 
-	@Override
-	protected boolean supportsJoinInMutationStatementSubquery() {
-		return false;
-	}
-
 	@Override
 	protected void visitArithmeticOperand(Expression expression) {
 		render( expression, SqlAstNodeRenderingMode.NO_PLAIN_PARAMETER );

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/DerbySqlAstTranslator.java

@@ -317,11 +317,6 @@ private boolean supportsOffsetFetchClause() {
 		return true;
 	}
 
-	@Override
-	protected boolean supportsJoinInMutationStatementSubquery() {
-		return false;
-	}
-
 	@Override
 	protected void visitArithmeticOperand(Expression expression) {
 		render( expression, SqlAstNodeRenderingMode.NO_PLAIN_PARAMETER );

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/H2LegacyDialect.java

@@ -1073,4 +1073,9 @@ public boolean supportsArrayConstructor() {
 		return getVersion().isSameOrAfter( 2 );
 	}
 
+	@Override
+	public boolean supportsJoinInMutationStatementSubquery() {
+		return false;
+	}
+
 }

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/H2LegacySqlAstTranslator.java

@@ -385,9 +385,4 @@ private boolean supportsOffsetFetchClausePercentWithTies() {
 		// Introduction of PERCENT support https://github.com/h2database/h2database/commit/f45913302e5f6ad149155a73763c0c59d8205849
 		return getDialect().getVersion().isSameOrAfter( 1, 4, 198 );
 	}
-
-	@Override
-	protected boolean supportsJoinInMutationStatementSubquery() {
-		return false;
-	}
 }

hibernate-core/src/main/java/org/hibernate/dialect/Dialect.java

@@ -5914,4 +5914,12 @@ public boolean supportsIntersect() {
 		return true;
 	}
 
+	/**
+	 * If the dialect supports using joins in mutation statement subquery
+	 * that could also use columns from the mutation target table
+	 */
+	public boolean supportsJoinInMutationStatementSubquery() {
+		return true;
+	}
+
 }

hibernate-core/src/main/java/org/hibernate/dialect/H2Dialect.java

@@ -1099,4 +1099,9 @@ public boolean supportsArrayConstructor() {
 		return true;
 	}
 
+	@Override
+	public boolean supportsJoinInMutationStatementSubquery() {
+		return false;
+	}
+
 }

hibernate-core/src/main/java/org/hibernate/dialect/H2SqlAstTranslator.java

@@ -357,9 +357,4 @@ private boolean supportsOffsetFetchClausePercentWithTies() {
 		// Introduction of PERCENT support https://github.com/h2database/h2database/commit/f45913302e5f6ad149155a73763c0c59d8205849
 		return true;
 	}
-
-	@Override
-	protected boolean supportsJoinInMutationStatementSubquery() {
-		return false;
-	}
 }

hibernate-core/src/main/java/org/hibernate/sql/ast/spi/AbstractSqlAstTranslator.java

@@ -1098,7 +1098,7 @@ protected Predicate determineWhereClauseRestrictionWithJoinEmulation(
 		);
 		querySpec.applyPredicate( statement.getRestriction() );
 
-		if ( supportsJoinInMutationStatementSubquery() ) {
+		if ( dialect.supportsJoinInMutationStatementSubquery() ) {
 			for ( TableGroup root : statement.getFromClause().getRoots() ) {
 				if ( root.getPrimaryTableReference() == statement.getTargetTable() ) {
 					final TableGroup dmlTargetTableGroup = new StandardTableGroup(
@@ -8566,14 +8566,6 @@ protected boolean supportsRowValueConstructorSyntaxInInSubQuery() {
 		return supportsRowValueConstructorSyntaxInInList();
 	}
 
-	/**
-	 * If the dialect supports using joins in mutation statement subquery
-	 * that could also use columns from the mutation target table
-	 */
-	protected boolean supportsJoinInMutationStatementSubquery() {
-		return true;
-	}
-
 	/**
 	 * Returns a table expression that has one row.
 	 *