Merge Hibernate Tools into ORM : Fix failing test on Oracle and Graal platforms

Author: koentsje

tooling/hibernate-reveng/src/main/java/org/hibernate/tool/reveng/internal/xml/AbstractXMLPrettyPrinterStrategy.java

@@ -19,13 +19,15 @@
 import javax.xml.xpath.XPathFactory;
 import java.io.ByteArrayInputStream;
 import java.io.IOException;
+import java.util.logging.Logger;
 
 public abstract class AbstractXMLPrettyPrinterStrategy implements XMLPrettyPrinterStrategy {
 
-	protected Document newDocument(String xml, String encoding) throws SAXException, IOException, ParserConfigurationException {
-		final DocumentBuilderFactory dbf = DocumentBuilderFactory.newInstance();
-		dbf.setFeature("http://apache.org/xml/features/nonvalidating/load-external-dtd", false);
-		final Document document = dbf
+	private static final Logger LOGGER = Logger.getLogger( AbstractXMLPrettyPrinterStrategy.class.getName() );
+	private static final DocumentBuilderFactory DOCUMENT_BUILDER_FACTORY = createDocumentBuilderFactory();
+
+	public Document newDocument(String xml, String encoding) throws SAXException, IOException, ParserConfigurationException {
+		final Document document = DOCUMENT_BUILDER_FACTORY
 				.newDocumentBuilder()
 				.parse(new InputSource(new ByteArrayInputStream(xml.getBytes(encoding))));
 		document.normalize();
@@ -43,4 +45,22 @@ protected void removeWhitespace(final Document document) throws XPathExpressionE
 			node.getParentNode().removeChild(node);
 		}
 	}
+
+	private static DocumentBuilderFactory createDocumentBuilderFactory() {
+		DocumentBuilderFactory result = null;
+		try {
+			result = DocumentBuilderFactory.newInstance(
+					"com.sun.org.apache.xerces.internal.jaxp.DocumentBuilderFactoryImpl",
+					null);
+			result.setFeature("http://apache.org/xml/features/nonvalidating/load-external-dtd", false);
+		}
+		catch (ParserConfigurationException e) {
+			LOGGER.severe(
+					"A ParserConfigurationException happened while setting the " +
+					"'http://apache.org/xml/features/nonvalidating/load-external-dtd' feature" +
+					"to false." );
+			throw new RuntimeException(e);
+		}
+		return result;
+	}
 }

tooling/hibernate-reveng/src/main/java/org/hibernate/tool/reveng/internal/xml/TrAXPrettyPrinterStrategy.java

@@ -14,8 +14,15 @@
 import javax.xml.transform.dom.DOMSource;
 import javax.xml.transform.stream.StreamResult;
 import java.io.StringWriter;
+import java.util.logging.Logger;
 
 public class TrAXPrettyPrinterStrategy extends AbstractXMLPrettyPrinterStrategy {
+
+	private static final Logger LOGGER = Logger.getLogger( TrAXPrettyPrinterStrategy.class.getName() );
+	private static final TransformerFactory TRANSFORMER_FACTORY = TransformerFactory.newInstance(
+			"com.sun.org.apache.xalan.internal.xsltc.trax.TransformerFactoryImpl",
+			null);
+
 	private int indent = 4;
 	private boolean omitXmlDeclaration;
 
@@ -32,17 +39,18 @@ public String prettyPrint(String xml) throws Exception {
 	}
 
 	protected Transformer newTransformer(final Document document) throws TransformerConfigurationException {
-		final TransformerFactory transformerFactory = newTransformerFactory();
 
-		final Transformer transformer = transformerFactory.newTransformer();
+		final Transformer transformer = TRANSFORMER_FACTORY.newTransformer();
 		transformer.setOutputProperty(OutputKeys.METHOD, "xml");
 		transformer.setOutputProperty(OutputKeys.ENCODING, "UTF-8");
 		transformer.setOutputProperty(OutputKeys.INDENT, "yes");
 		transformer.setOutputProperty(OutputKeys.OMIT_XML_DECLARATION, isOmitXmlDeclaration() ? "yes" : "no");
 		try {
 			transformer.setOutputProperty("{http://xml.apache.org/xslt}indent-amount", String.valueOf(getIndent()));
 		}
-		catch (IllegalArgumentException ignored) {
+		catch (IllegalArgumentException e) {
+			LOGGER.severe( "An IllegalArgumentException happened while adding the 'indent' property." );
+			throw new RuntimeException(e);
 		}
 
 		final DocumentType doctype = document.getDoctype();
@@ -54,17 +62,6 @@ protected Transformer newTransformer(final Document document) throws Transformer
 		return transformer;
 	}
 
-	protected TransformerFactory newTransformerFactory() {
-		final TransformerFactory transformerFactory = TransformerFactory.newInstance();
-		try {
-			transformerFactory.setAttribute("indent-number", getIndent());
-		}
-		catch (IllegalArgumentException ignored) {
-		}
-
-		return transformerFactory;
-	}
-
 	public int getIndent() {
 		return indent;
 	}
@@ -80,4 +77,5 @@ public boolean isOmitXmlDeclaration() {
 	public void setOmitXmlDeclaration(boolean omitXmlDeclaration) {
 		this.omitXmlDeclaration = omitXmlDeclaration;
 	}
+
 }