deprecate old code for fetching id by natural id

Author: gavinking

hibernate-core/src/main/java/org/hibernate/persister/entity/AbstractEntityPersister.java

@@ -5578,7 +5578,7 @@ rs, getPropertyAliases(
 		}
 	}
 
-	@Override
+	@Override @Deprecated
 	public Serializable loadEntityIdByNaturalId(
 			Object[] naturalIdValues,
 			LockOptions lockOptions,
@@ -5653,6 +5653,7 @@ public static boolean[] determineValueNullness(Object[] naturalIdValues) {
 	private Boolean naturalIdIsNonNullable;
 	private String cachedPkByNonNullableNaturalIdQuery;
 
+	@Deprecated
 	protected String determinePkByNaturalIdQuery(boolean[] valueNullness) {
 		if ( !hasNaturalIdentifier() ) {
 			throw new HibernateException(
@@ -5694,6 +5695,7 @@ private boolean determineNaturalIdNullability() {
 		return true;
 	}
 
+	@Deprecated
 	private String generateEntityIdByNaturalIdSql(boolean[] valueNullness) {
 		EntityPersister rootPersister = getFactory().getEntityPersister( getRootEntityName() );
 		if ( rootPersister != this ) {

hibernate-core/src/main/java/org/hibernate/persister/entity/EntityPersister.java

@@ -365,7 +365,10 @@ default Object initializeEnhancedEntityUsedAsProxy(
 
 	/**
 	 * Load the id for the entity based on the natural id.
+	 * 
+	 * @deprecated use {@link UniqueKeyLoadable#loadByNaturalId(Object[], LockOptions, SharedSessionContractImplementor)}
 	 */
+	@Deprecated
 	Serializable loadEntityIdByNaturalId(
 			Object[] naturalIdValues, LockOptions lockOptions,
 			SharedSessionContractImplementor session);