HHH-19005 Memory leak modify String to StringBuilder

Author: dev3way

hibernate-core/src/main/java/org/hibernate/engine/jdbc/internal/BasicFormatterImpl.java

@@ -79,34 +79,17 @@ public String perform() {
 				}
 
 				lcToken = token.toLowerCase( Locale.ROOT );
-				StringBuilder sb = new StringBuilder();
 				switch ( lcToken ) {
 					case "'":
 					case "`":
 					case "\"":
-						String t;
-						sb.append( this.token );
-						do {
-							t = tokens.nextToken();
-							sb.append( t );
-						}
-						while ( !lcToken.equals( t ) && tokens.hasMoreTokens() );
-						this.token = sb.toString();
-						lcToken = token;
+						appendUntilToken(lcToken);
 						misc();
 						break;
 					// SQL Server uses "[" and "]" to escape reserved words
 					// see SQLServerDialect.openQuote and SQLServerDialect.closeQuote
 					case "[":
-						String tt;
-						sb.append( this.token );
-						do {
-							tt = tokens.nextToken();
-							sb.append( tt );
-						}
-						while ( !"]".equals( tt ) && tokens.hasMoreTokens() );
-						this.token = sb.toString();
-						lcToken = token;
+						appendUntilToken("]");
 						misc();
 						break;
 
@@ -394,8 +377,8 @@ private void endNewClause() {
 			newline();
 			afterBeginBeforeEnd = false;
 			afterByOrSetOrFromOrSelect = "by".equals( lcToken )
-					|| "set".equals( lcToken )
-					|| "from".equals( lcToken );
+										 || "set".equals( lcToken )
+										 || "from".equals( lcToken );
 		}
 
 		private void beginNewClause() {
@@ -514,6 +497,19 @@ private void newline() {
 					.append( INDENT_STRING.repeat( indent ) );
 			beginLine = true;
 		}
+
+		private void appendUntilToken(String stopToken) {
+			StringBuilder sb = new StringBuilder();
+			String t;
+			sb.append( this.token );
+			do {
+				t = tokens.nextToken();
+				sb.append( t );
+			}
+			while ( !stopToken.equals( t ) && tokens.hasMoreTokens() );
+			this.token = sb.toString();
+			lcToken = token;
+		}
 	}
 
 }