Skip to content

Commit 4c8dd9c

Browse files
committed
HHH-19745 Use custom SqmCacheable#isCompatible and SqmCacheable#cacheHashCode instead of equals/hashCode for SqmNode
1 parent 4fd814b commit 4c8dd9c

File tree

151 files changed

+1539
-1048
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

151 files changed

+1539
-1048
lines changed

hibernate-core/src/main/java/org/hibernate/metamodel/model/domain/internal/AnyDiscriminatorSqmPath.java

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
import org.hibernate.query.sqm.tree.domain.SqmPath;
1414
import org.hibernate.spi.NavigablePath;
1515

16-
import java.util.Objects;
1716

1817
public class AnyDiscriminatorSqmPath<T> extends AbstractSqmPath<T> implements DiscriminatorSqmPath<T> {
1918

@@ -51,13 +50,13 @@ public AnyDiscriminatorSqmPathSource<T> getExpressible() {
5150

5251

5352
@Override
54-
public boolean equals(Object object) {
53+
public boolean isCompatible(Object object) {
5554
return object instanceof AnyDiscriminatorSqmPath<?> that
56-
&& Objects.equals( this.getLhs(), that.getLhs() );
55+
&& getLhs().isCompatible( that.getLhs() );
5756
}
5857

5958
@Override
60-
public int hashCode() {
61-
return getLhs().hashCode();
59+
public int cacheHashCode() {
60+
return getLhs().cacheHashCode();
6261
}
6362
}

hibernate-core/src/main/java/org/hibernate/metamodel/model/domain/internal/EmbeddedDiscriminatorSqmPath.java

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
import org.hibernate.query.sqm.tree.domain.SqmPath;
1515
import org.hibernate.spi.NavigablePath;
1616

17-
import java.util.Objects;
1817

1918
/**
2019
* {@link SqmPath} specialization for an embeddable discriminator
@@ -63,13 +62,13 @@ public <X> X accept(SemanticQueryWalker<X> walker) {
6362
}
6463

6564
@Override
66-
public boolean equals(Object object) {
65+
public boolean isCompatible(Object object) {
6766
return object instanceof EmbeddedDiscriminatorSqmPath<?> that
68-
&& Objects.equals( this.getLhs(), that.getLhs() );
67+
&& getLhs().isCompatible( that.getLhs() );
6968
}
7069

7170
@Override
72-
public int hashCode() {
73-
return getLhs().hashCode();
71+
public int cacheHashCode() {
72+
return getLhs().cacheHashCode();
7473
}
7574
}

hibernate-core/src/main/java/org/hibernate/metamodel/model/domain/internal/EntityDiscriminatorSqmPath.java

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
import org.hibernate.query.sqm.tree.domain.SqmEntityDomainType;
1818
import org.hibernate.spi.NavigablePath;
1919

20-
import java.util.Objects;
2120

2221
/**
2322
* {@link SqmPath} specialization for an entity discriminator
@@ -77,13 +76,13 @@ public <X> X accept(SemanticQueryWalker<X> walker) {
7776
}
7877

7978
@Override
80-
public boolean equals(Object object) {
79+
public boolean isCompatible(Object object) {
8180
return object instanceof EntityDiscriminatorSqmPath<?> that
82-
&& Objects.equals( this.getLhs(), that.getLhs() );
81+
&& getLhs().isCompatible( that.getLhs() );
8382
}
8483

8584
@Override
86-
public int hashCode() {
87-
return getLhs().hashCode();
85+
public int cacheHashCode() {
86+
return getLhs().cacheHashCode();
8887
}
8988
}

hibernate-core/src/main/java/org/hibernate/query/hql/internal/FullyQualifiedReflectivePath.java

Lines changed: 0 additions & 66 deletions
This file was deleted.

hibernate-core/src/main/java/org/hibernate/query/hql/internal/FullyQualifiedReflectivePathSource.java

Lines changed: 0 additions & 14 deletions
This file was deleted.

0 commit comments

Comments
 (0)