HHH-6951 IdentifiableType.getIdType() should respect @IdClass

Before this commit, `IdentifiableType.getIdType()` returns unexpected `null` if multiple @id present.

Author: quaff

hibernate-core/src/main/java/org/hibernate/metamodel/model/domain/AbstractIdentifiableType.java

@@ -184,6 +184,9 @@ public SimpleDomainType<?> getIdType() {
 			if ( idClassAttributes.size() == 1 ) {
 				return idClassAttributes.iterator().next().getType();
 			}
+			else if ( idClassType instanceof SimpleDomainType<?> ) {
+				return (SimpleDomainType<?>) idClassType;
+			}
 		}
 
 		return null;

hibernate-core/src/test/java/org/hibernate/orm/test/jpa/metamodel/MixedIdAndIdClassHandling.java

@@ -6,6 +6,8 @@
  */
 package org.hibernate.orm.test.jpa.metamodel;
 
+import java.util.Objects;
+
 import jakarta.persistence.Column;
 import jakarta.persistence.Entity;
 import jakarta.persistence.Id;
@@ -14,8 +16,8 @@
 import jakarta.persistence.Table;
 import jakarta.persistence.metamodel.EntityType;
 
-import org.hibernate.testing.TestForIssue;
 import org.hibernate.testing.orm.junit.EntityManagerFactoryScope;
+import org.hibernate.testing.orm.junit.JiraKey;
 import org.hibernate.testing.orm.junit.Jpa;
 
 import org.junit.jupiter.api.Test;
@@ -29,14 +31,16 @@
  * Ugh
  *
  * @author Steve Ebersole
+ * @author Yanming Zhou
  */
 @Jpa(annotatedClasses = {
-		MixedIdAndIdClassHandling.FullTimeEmployee.class
+		MixedIdAndIdClassHandling.FullTimeEmployee.class,
+		MixedIdAndIdClassHandling.Person.class
 })
 public class MixedIdAndIdClassHandling {
 
 	@Test
-	@TestForIssue( jiraKey = "HHH-8533" )
+	@JiraKey( "HHH-8533" )
 	public void testAccess(EntityManagerFactoryScope scope) {
 		EntityType<FullTimeEmployee> entityType = scope.getEntityManagerFactory().getMetamodel().entity( FullTimeEmployee.class );
 		try {
@@ -50,8 +54,16 @@ public void testAccess(EntityManagerFactoryScope scope) {
 		assertEquals( 1, entityType.getSupertype().getIdClassAttributes().size() );
 
 		assertFalse( entityType.hasSingleIdAttribute() );
+	}
 
-		assertEquals( String.class, entityType.getIdType().getJavaType() );
+	@Test
+	@JiraKey( "HHH-6951" )
+	public void testGetIdType(EntityManagerFactoryScope scope) {
+		EntityType<FullTimeEmployee> fullTimeEmployeeEntityType = scope.getEntityManagerFactory().getMetamodel().entity( FullTimeEmployee.class );
+		assertEquals( String.class, fullTimeEmployeeEntityType.getIdType().getJavaType() ); // return single @Id instead of @IdClass
+
+		EntityType<Person> personEntityType = scope.getEntityManagerFactory().getMetamodel().entity( Person.class );
+		assertEquals( PersonId.class, personEntityType.getIdType().getJavaType() ); // return @IdClass instead of null
 	}
 
 	@MappedSuperclass
@@ -90,27 +102,78 @@ public void setId(String id) {
 			this.id = id;
 		}
 
-
 		@Override
-		public boolean equals(Object obj) {
-			if (obj == null) {
-				return false;
+		public boolean equals(Object o) {
+			if ( this == o ) {
+				return true;
 			}
-			if (getClass() != obj.getClass()) {
+			if ( !( o instanceof EmployeeId ) ) {
 				return false;
 			}
-			final EmployeeId other = (EmployeeId) obj;
-			if ((this.id == null) ? (other.id != null) : !this.id.equals(other.id)) {
+			EmployeeId that = ( EmployeeId ) o;
+			return Objects.equals( id, that.id );
+		}
+
+		@Override
+		public int hashCode() {
+			return Objects.hashCode( id );
+		}
+	}
+
+	@IdClass( PersonId.class )
+	@Entity( name = "Person" )
+	@Table( name="PERSON" )
+	public static class Person {
+		@Id
+		private String type;
+		@Id
+		private String no;
+		private String name;
+	}
+
+	public static class PersonId implements java.io.Serializable {
+		String type;
+		String no;
+
+		public PersonId() {
+		}
+
+		public PersonId(String type, String no) {
+			this.type = type;
+			this.no = no;
+		}
+
+		public String getType() {
+			return type;
+		}
+
+		public void setType(String type) {
+			this.type = type;
+		}
+
+		public String getNo() {
+			return no;
+		}
+
+		public void setNo(String no) {
+			this.no = no;
+		}
+
+		@Override
+		public boolean equals(Object o) {
+			if ( this == o ) {
+				return true;
+			}
+			if ( !( o instanceof PersonId ) ) {
 				return false;
 			}
-			return true;
+			PersonId that = ( PersonId ) o;
+			return Objects.equals( type, that.type ) && Objects.equals( no, that.no );
 		}
 
 		@Override
 		public int hashCode() {
-			int hash = 5;
-			hash = 29 * hash + (this.id != null ? this.id.hashCode() : 0);
-			return hash;
+			return Objects.hash( type, no );
 		}
 	}
 }