HHH-19260 - Move supportsDuplicateSelectItemsInQueryGroup() from AbstractSqlAstTranslator to Dialect

Signed-off-by: Jan Schatteman <[email protected]>

Author: jrenaat

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/OracleLegacyDialect.java

@@ -1659,4 +1659,9 @@ public String getFromDualForSelectOnly() {
 		return " from " + getDual();
 	}
 
+	@Override
+	public boolean supportsDuplicateSelectItemsInQueryGroup() {
+		return false;
+	}
+
 }

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/OracleLegacySqlAstTranslator.java

@@ -686,11 +686,6 @@ else if ( expression instanceof Summarization ) {
 		}
 	}
 
-	@Override
-	protected boolean supportsDuplicateSelectItemsInQueryGroup() {
-		return false;
-	}
-
 	@Override
 	protected boolean supportsRowValueConstructorSyntax() {
 		return false;

hibernate-core/src/main/java/org/hibernate/dialect/Dialect.java

@@ -5906,4 +5906,8 @@ public boolean supportsArrayConstructor() {
 		return false;
 	}
 
+	public boolean supportsDuplicateSelectItemsInQueryGroup() {
+		return true;
+	}
+
 }

hibernate-core/src/main/java/org/hibernate/dialect/OracleDialect.java

@@ -1740,4 +1740,9 @@ public String getFromDualForSelectOnly() {
 		return getVersion().isSameOrAfter( 23 ) ? "" : ( " from " + getDual() );
 	}
 
+	@Override
+	public boolean supportsDuplicateSelectItemsInQueryGroup() {
+		return false;
+	}
+
 }

hibernate-core/src/main/java/org/hibernate/dialect/OracleSqlAstTranslator.java

@@ -648,11 +648,6 @@ public void visitBinaryArithmeticExpression(BinaryArithmeticExpression arithmeti
 		super.visitBinaryArithmeticExpression(arithmeticExpression);
 	}
 
-	@Override
-	protected boolean supportsDuplicateSelectItemsInQueryGroup() {
-		return false;
-	}
-
 	@Override
 	protected boolean supportsRowValueConstructorSyntax() {
 		return false;

hibernate-core/src/main/java/org/hibernate/sql/ast/spi/AbstractSqlAstTranslator.java

@@ -3645,7 +3645,7 @@ public void visitQuerySpec(QuerySpec querySpec) {
 						// We need to assign aliases when we render a query spec as subquery to avoid clashing aliases
 						this.needsSelectAliases = this.needsSelectAliases || hasDuplicateSelectItems( querySpec );
 					}
-					else if ( !supportsDuplicateSelectItemsInQueryGroup() ) {
+					else if ( !dialect.supportsDuplicateSelectItemsInQueryGroup() ) {
 						this.needsSelectAliases = this.needsSelectAliases || hasDuplicateSelectItems( querySpec );
 					}
 				}
@@ -3698,10 +3698,6 @@ protected boolean supportsSimpleQueryGrouping() {
 		return true;
 	}
 
-	protected boolean supportsDuplicateSelectItemsInQueryGroup() {
-		return true;
-	}
-
 	protected final void visitWhereClause(Predicate whereClauseRestrictions) {
 		final Predicate additionalWherePredicate = this.additionalWherePredicate;
 		if ( whereClauseRestrictions != null && !whereClauseRestrictions.isEmpty() || additionalWherePredicate != null ) {