HHH-19209 Reverting commit "Sorting record components by name when generating ID class"

          Reverting test assertions checking if record components are alphabetically ordered

Author: cigaly

hibernate-core/src/test/java/org/hibernate/orm/test/mapping/hhh18829/AutoGeneratedIdClassTest.java

@@ -56,7 +56,7 @@ void setUp(SessionFactoryScope sessionFactoryScope) {
 	public void test(SessionFactoryScope sessionFactoryScope)
 			throws ClassNotFoundException, InvocationTargetException, InstantiationException, IllegalAccessException {
 		final var idClass = Class.forName( EmployeeWithoutIdClass.class.getName() + "_$Id" );
-		final var id = idClass.getConstructors()[0].newInstance( 1, "John Doe" );
+		final var id = idClass.getConstructors()[0].newInstance( "John Doe", 1 );
 		final var employees = sessionFactoryScope.fromSession(
 				sess -> sess.createQuery( "from EmployeeWithoutIdClass where id=:id", EmployeeWithoutIdClass.class )
 						.setParameter( "id", id )
@@ -70,7 +70,7 @@ public void test(SessionFactoryScope sessionFactoryScope)
 	public void innerEntityClassTest(SessionFactoryScope sessionFactoryScope)
 			throws ClassNotFoundException, InvocationTargetException, InstantiationException, IllegalAccessException {
 		final var idClass = Class.forName( AutoGeneratedIdClassTest .class.getName() + "_$Inner_$Id" );
-		final var id = idClass.getConstructors()[0].newInstance( 13, "Dave Default" );
+		final var id = idClass.getConstructors()[0].newInstance( "Dave Default", 13 );
 		final Inner employee = sessionFactoryScope.fromSession(
 				sess -> sess.find( Inner.class, id ) );
 		assertEquals( "1600 Pennsylvania Avenue", employee.address );

tooling/metamodel-generator/src/main/java/org/hibernate/processor/annotation/AnnotationMetaEntity.java

@@ -66,7 +66,6 @@
 import static java.beans.Introspector.decapitalize;
 import static java.lang.Boolean.FALSE;
 import static java.util.Collections.emptyList;
-import static java.util.Comparator.comparing;
 import static java.util.stream.Collectors.toList;
 import static javax.lang.model.util.ElementFilter.fieldsIn;
 import static javax.lang.model.util.ElementFilter.methodsIn;
@@ -488,7 +487,6 @@ private void addIdClassIfNeeded(List<? extends Element> fields, List<? extends E
 		if ( components.size() < 2 ) {
 			return;
 		}
-		components.sort( comparing( MetaAttribute::getPropertyName ) );
 		putMember( ID_CLASS_MEMBER_NAME, new IdClassMetaAttribute( this, components ) );
 	}
 

tooling/metamodel-generator/src/test/java/org/hibernate/processor/test/hhh18829/AutoGeneratedIdClassTest.java

@@ -29,7 +29,7 @@ public void test() {
 		System.out.println( TestUtil.getMetaModelSourceAsString( Address.class ) );
 		System.out.println( TestUtil.getMetaModelSourceAsString( EmployeeWithIdClass.class ) );
 
-		checkIfIdClassIsGenerated( Employee.class, new String[] {"empId", "empName"} );
+		checkIfIdClassIsGenerated( Employee.class, new String[] {"empName", "empId"} );
 		checkIfIdClassIsGenerated( AnotherEmployee.class, new String[] {"empId", "empName"} );
 
 		final var clazz = getMetamodelClassFor( EmployeeWithIdClass.class );
@@ -46,8 +46,8 @@ public void testInner() {
 		System.out.println( TestUtil.getMetaModelSourceAsString( Outer.Inner.class ) );
 		System.out.println( TestUtil.getMetaModelSourceAsString( Outer.Super.class ) );
 
-		checkIfIdClassIsGenerated( Outer.Inner.class, new String[] {"empId", "empName"} );
-		checkIfIdClassIsGenerated( Outer.Super.class, new String[] {"empId", "empName"} );
+		checkIfIdClassIsGenerated( Outer.Inner.class, new String[] {"empName", "empId"} );
+		checkIfIdClassIsGenerated( Outer.Super.class, new String[] {"empName", "empId"} );
 	}
 
 	private static void checkIfIdClassIsGenerated(Class<?> entityClass, String[] idComponentNames) {