Skip to content

Commit 4f44dbf

Browse files
beikovmarko-bekhta
authored andcommitted
Make bytecode test engine backwards compatible with older JUnit versions
(cherry picked from commit 7a2f7f0) Make bytecode test engine backwards compatible with older JUnit versions (cherry picked from commit 399120a)
1 parent e7bcbb4 commit 4f44dbf

File tree

2 files changed

+12
-7
lines changed

2 files changed

+12
-7
lines changed

hibernate-testing/src/main/java/org/hibernate/testing/bytecode/enhancement/extension/engine/BytecodeEnhancedEngineDescriptor.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,18 @@
88

99
import org.junit.jupiter.engine.config.JupiterConfiguration;
1010
import org.junit.jupiter.engine.descriptor.JupiterEngineDescriptor;
11+
import org.junit.platform.engine.TestDescriptor;
1112
import org.junit.platform.engine.UniqueId;
1213

1314
public class BytecodeEnhancedEngineDescriptor extends JupiterEngineDescriptor {
1415
public BytecodeEnhancedEngineDescriptor(UniqueId uniqueId, JupiterConfiguration configuration) {
1516
super( uniqueId, configuration );
1617
}
18+
19+
public BytecodeEnhancedEngineDescriptor(JupiterEngineDescriptor engineDescriptor) {
20+
this( engineDescriptor.getUniqueId(), engineDescriptor.getConfiguration() );
21+
for ( TestDescriptor child : engineDescriptor.getChildren() ) {
22+
addChild( child );
23+
}
24+
}
1725
}

hibernate-testing/src/main/java/org/hibernate/testing/bytecode/enhancement/extension/engine/BytecodeEnhancedTestEngine.java

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -35,15 +35,13 @@
3535
import org.junit.jupiter.api.io.CleanupMode;
3636
import org.junit.jupiter.api.io.TempDirFactory;
3737
import org.junit.jupiter.api.parallel.ExecutionMode;
38-
import org.junit.jupiter.engine.config.CachingJupiterConfiguration;
39-
import org.junit.jupiter.engine.config.DefaultJupiterConfiguration;
38+
import org.junit.jupiter.engine.JupiterTestEngine;
4039
import org.junit.jupiter.engine.config.JupiterConfiguration;
4140
import org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor;
4241
import org.junit.jupiter.engine.descriptor.ClassTestDescriptor;
4342
import org.junit.jupiter.engine.descriptor.JupiterEngineDescriptor;
4443
import org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor;
4544
import org.junit.jupiter.engine.descriptor.TestTemplateTestDescriptor;
46-
import org.junit.jupiter.engine.discovery.DiscoverySelectorResolver;
4745
import org.junit.jupiter.engine.execution.JupiterEngineExecutionContext;
4846
import org.junit.platform.engine.EngineDiscoveryRequest;
4947
import org.junit.platform.engine.ExecutionRequest;
@@ -62,10 +60,9 @@ public String getId() {
6260

6361
@Override
6462
public TestDescriptor discover(EngineDiscoveryRequest discoveryRequest, UniqueId uniqueId) {
65-
JupiterConfiguration configuration = new CachingJupiterConfiguration(
66-
new DefaultJupiterConfiguration( discoveryRequest.getConfigurationParameters() ) );
67-
JupiterEngineDescriptor engineDescriptor = new BytecodeEnhancedEngineDescriptor( uniqueId, configuration );
68-
new DiscoverySelectorResolver().resolveSelectors( discoveryRequest, engineDescriptor );
63+
final BytecodeEnhancedEngineDescriptor engineDescriptor = new BytecodeEnhancedEngineDescriptor(
64+
(JupiterEngineDescriptor) new JupiterTestEngine().discover( discoveryRequest, uniqueId )
65+
);
6966

7067
for ( TestDescriptor testDescriptor : new HashSet<>( engineDescriptor.getChildren() ) ) {
7168
if ( testDescriptor instanceof ClassBasedTestDescriptor ) {

0 commit comments

Comments
 (0)