fix some unnecessary use of raw types

Author: gavinking

hibernate-core/src/main/java/org/hibernate/query/sqm/tree/expression/JpaCriteriaParameter.java

@@ -145,8 +145,8 @@ private String name(SqmRenderContext context) {
 	}
 
 	@Override
-	public int compareTo(SqmParameter parameter) {
-		return parameter instanceof JpaCriteriaParameter
+	public int compareTo(SqmParameter<T> parameter) {
+		return parameter instanceof JpaCriteriaParameter<T>
 				? Integer.compare( hashCode(), parameter.hashCode() )
 				: 1;
 	}

hibernate-core/src/main/java/org/hibernate/query/sqm/tree/expression/SqmJpaCriteriaParameterWrapper.java

@@ -129,8 +129,8 @@ public void appendHqlString(StringBuilder hql, SqmRenderContext context) {
 	}
 
 	@Override
-	public int compareTo(SqmParameter anotherParameter) {
-		return anotherParameter instanceof SqmJpaCriteriaParameterWrapper<?> wrapper
+	public int compareTo(SqmParameter<T> parameter) {
+		return parameter instanceof SqmJpaCriteriaParameterWrapper<T> wrapper
 				? getJpaCriteriaParameter().compareTo( wrapper.getJpaCriteriaParameter() )
 				: 1;
 	}

hibernate-core/src/main/java/org/hibernate/query/sqm/tree/expression/SqmNamedParameter.java

@@ -83,8 +83,8 @@ public void appendHqlString(StringBuilder hql, SqmRenderContext context) {
 	}
 
 	@Override
-	public int compareTo(SqmParameter anotherParameter) {
-		return anotherParameter instanceof SqmNamedParameter<?> namedParameter
+	public int compareTo(SqmParameter<T> parameter) {
+		return parameter instanceof SqmNamedParameter<T> namedParameter
 				? getName().compareTo( namedParameter.getName() )
 				: -1;
 	}

hibernate-core/src/main/java/org/hibernate/query/sqm/tree/expression/SqmParameter.java

@@ -75,21 +75,21 @@ public interface SqmParameter<T> extends SqmExpression<T>, JpaParameterExpressio
 	 * support any previous extensions
 	 */
 	@Override
-	default int compareTo(SqmParameter<T> anotherParameter) {
-		if ( this instanceof SqmNamedParameter<?> one ) {
-			return anotherParameter instanceof SqmNamedParameter<?>
-					? one.getName().compareTo( anotherParameter.getName() )
+	default int compareTo(SqmParameter<T> parameter) {
+		if ( this instanceof SqmNamedParameter<T> one ) {
+			return parameter instanceof SqmNamedParameter<?>
+					? one.getName().compareTo( parameter.getName() )
 					: -1;
 		}
-		else if ( this instanceof SqmPositionalParameter<?> one ) {
-			return anotherParameter instanceof SqmPositionalParameter<?>
-					? one.getPosition().compareTo( anotherParameter.getPosition() )
+		else if ( this instanceof SqmPositionalParameter<T> one ) {
+			return parameter instanceof SqmPositionalParameter<?>
+					? one.getPosition().compareTo( parameter.getPosition() )
 					: 1;
 		}
-		else if ( this instanceof SqmJpaCriteriaParameterWrapper
-				&& anotherParameter instanceof SqmJpaCriteriaParameterWrapper ) {
-			return Integer.compare( this.hashCode(), anotherParameter.hashCode() );
+		else if ( this instanceof SqmJpaCriteriaParameterWrapper<T>
+				&& parameter instanceof SqmJpaCriteriaParameterWrapper<T> ) {
+			return Integer.compare( this.hashCode(), parameter.hashCode() );
 		}
-		throw new HibernateException( "Unexpected SqmParameter type for comparison : " + this + " & " + anotherParameter );
+		throw new HibernateException( "Unexpected SqmParameter type for comparison : " + this + " & " + parameter );
 	}
 }

hibernate-core/src/main/java/org/hibernate/query/sqm/tree/expression/SqmPositionalParameter.java

@@ -85,8 +85,8 @@ public void appendHqlString(StringBuilder hql, SqmRenderContext context) {
 	}
 
 	@Override
-	public int compareTo(SqmParameter anotherParameter) {
-		return anotherParameter instanceof SqmPositionalParameter<?> positionalParameter
+	public int compareTo(SqmParameter<T> parameter) {
+		return parameter instanceof SqmPositionalParameter<T> positionalParameter
 				? getPosition().compareTo( positionalParameter.getPosition() )
 				: 1;
 	}

hibernate-core/src/main/java/org/hibernate/query/sqm/tree/expression/ValueBindJpaCriteriaParameter.java

@@ -56,7 +56,7 @@ public void appendHqlString(StringBuilder hql, SqmRenderContext context) {
 
 	@Override
 	// TODO: fix this
-	public int compareTo(SqmParameter parameter) {
+	public int compareTo(SqmParameter<T> parameter) {
 		return this == parameter ? 0 : 1;
 	}