HHH-19846 - Drop JUnit 4 usage

Not converted...
* org.hibernate.orm.test.hql.PostgreSQLFunctionSelectClauseTest - registering custom function
* org.hibernate.orm.test.hql.PostgreSQLFunctionWhereClauseTest - aux-db-object
* org.hibernate.orm.test.id.usertype - type registrations
* org.hibernate.orm.test.idgen.enhanced.HiloOptimizerConcurrencyTest - recreation of SF during tests
* org.hibernate.orm.test.type.AbstractJavaTimeTypeTest subtypes - crazy parameterization (see org.hibernate.orm.test.tm.InterceptorTransactionTest)
* org.hibernate.orm.test.cdi.general.hibernatesearch.extended.HibernateSearchExtendedCdiSupportTest - not sure yet, all the other tests here pass with conversion - shelved for now

Author: sebersole

hibernate-core/src/test/java/org/hibernate/orm/test/hql/DB297SubStringFunctionsTest.java

@@ -114,7 +114,7 @@ public void testSubstrWithoutStringUnits(SessionFactoryScope factoryScope) {
 			assertThat( value ).isEqualTo( "description" );
 		} );
 		assertThat( sqlCollector.getSqlQueries() ).hasSize( 1 );
-		assertThat( sqlCollector.getSqlQueries().get( 0 ) ).contains( "substring(" );
+		assertThat( sqlCollector.getSqlQueries().get( 0 ) ).contains( "substr(" );
 	}
 
 	@Entity(name="AnEntity")

hibernate-core/src/test/java/org/hibernate/orm/test/schemafilter/CatalogFilterTest.java

@@ -20,6 +20,7 @@
 import org.hibernate.testing.orm.junit.RequiresDialect;
 import org.hibernate.testing.orm.junit.ServiceRegistry;
 import org.hibernate.testing.orm.junit.ServiceRegistryScope;
+import org.hibernate.testing.orm.junit.Setting;
 import org.hibernate.tool.schema.internal.DefaultSchemaFilter;
 import org.hibernate.tool.schema.internal.SchemaCreatorImpl;
 import org.hibernate.tool.schema.internal.SchemaDropperImpl;
@@ -30,9 +31,10 @@
 import org.junit.jupiter.api.Test;
 
 import static org.hamcrest.MatcherAssert.assertThat;
+import static org.hibernate.cfg.JdbcSettings.FORMAT_SQL;
 
 @SuppressWarnings({"rawtypes", "unchecked", "JUnitMalformedDeclaration"})
-@ServiceRegistry
+@ServiceRegistry(settings = @Setting(name = FORMAT_SQL, value = "false"))
 @RequiresDialect(value = SQLServerDialect.class, comment = "Unit test - limit to minimize complexity of checks")
 @DomainModel(annotatedClasses = {
 		CatalogFilterTest.CatalogNoneEntity0.class,

hibernate-core/src/test/java/org/hibernate/orm/test/where/hbm/LazyManyToManyNonUniqueIdNotFoundWhereTest.java

@@ -29,7 +29,7 @@
  */
 @SuppressWarnings("JUnitMalformedDeclaration")
 @DomainModel(xmlMappings = "hbm/where/LazyManyToManyNonUniqueIdNotFoundWhereTest.hbm.xml")
-@SessionFactory(exportSchema = false)
+@SessionFactory
 public class LazyManyToManyNonUniqueIdNotFoundWhereTest {
 	@AfterAll
 	static void dropSchema(SessionFactoryScope factoryScope) {
@@ -41,9 +41,9 @@ public void createSchema(SessionFactoryScope factoryScope) {
 		factoryScope.inTransaction( session -> session.doWork( connection -> {
 			final Dialect dialect = session.getDialect();
 			try (final Statement statement = connection.createStatement()) {
+				statement.executeUpdate( dialect.getDropTableString( "MATERIAL_RATINGS" ) );
 				statement.executeUpdate( dialect.getDropTableString( "BUILDING_RATINGS" ) );
 				statement.executeUpdate( dialect.getDropTableString( "ASSOCIATION_TABLE" ) );
-				statement.executeUpdate( dialect.getDropTableString( "MATERIAL_RATINGS" ) );
 				statement.executeUpdate( dialect.getDropTableString( "MAIN_TABLE" ) );
 
 				statement.executeUpdate( """