HHH-19276 use TypecheckUtil to test assignability of array elements

Author: gavinking

hibernate-core/src/main/java/org/hibernate/dialect/function/array/ArrayAndElementArgumentValidator.java

@@ -11,6 +11,8 @@
 import org.hibernate.query.sqm.produce.function.FunctionArgumentException;
 import org.hibernate.query.sqm.tree.SqmTypedNode;
 
+import static org.hibernate.query.sqm.internal.TypecheckUtil.isTypeAssignable;
+
 /**
  * A {@link ArgumentsValidator} that validates the array type is compatible with the element type.
  */
@@ -37,8 +39,9 @@ public void validate(
 				final var expressible = elementArgument.getExpressible();
 				final var elementType = expressible != null ? expressible.getSqmType() : null;
 				if ( expectedElementType != null && elementType != null
-					 && !expectedElementType.getJavaType()
-						.isAssignableFrom( elementType.getExpressibleJavaType().getJavaTypeClass() ) ) {
+						&& !isTypeAssignable( expectedElementType, elementType.getSqmType(), bindingContext ) ) {
+//						&& !expectedElementType.getRelationalJavaType().getJavaTypeClass()
+//							.isAssignableFrom( elementType.getRelationalJavaType().getJavaTypeClass() ) ) {
 					throw new FunctionArgumentException(
 							String.format(
 									"Parameter %d of function '%s()' has type %s, but argument is of type '%s'",

hibernate-core/src/main/java/org/hibernate/query/sqm/internal/TypecheckUtil.java

@@ -312,7 +312,7 @@ else if ( rhsType instanceof SqmBindableType<?> rhsExpressible ) {
 	 *
 	 * @see #areTypesComparable(SqmBindableType, SqmBindableType, BindingContext)
 	 */
-	private static boolean isTypeAssignable(
+	public static boolean isTypeAssignable(
 			SqmBindableType<?> targetType, SqmBindableType<?> expressionType,
 			BindingContext bindingContext) {