HHH-17550 Add test for issue

Author: mbellade

hibernate-core/src/test/java/org/hibernate/orm/test/foreignkeys/disabled/DefaultConstraintModeTest.java

@@ -6,69 +6,90 @@
  */
 package org.hibernate.orm.test.foreignkeys.disabled;
 
-import static org.hamcrest.core.Is.is;
-import static org.junit.Assert.assertThat;
-
+import java.util.List;
 import java.util.stream.StreamSupport;
 
-import jakarta.persistence.Entity;
-import jakarta.persistence.Id;
-import jakarta.persistence.JoinColumn;
-import jakarta.persistence.ManyToOne;
-
 import org.hibernate.boot.Metadata;
 import org.hibernate.boot.MetadataSources;
 import org.hibernate.boot.registry.StandardServiceRegistry;
 import org.hibernate.cfg.Environment;
 import org.hibernate.mapping.Table;
-import org.hibernate.testing.TestForIssue;
+
 import org.hibernate.testing.junit4.BaseUnitTestCase;
+import org.hibernate.testing.orm.junit.Jira;
 import org.hibernate.testing.util.ServiceRegistryUtil;
 import org.junit.Test;
 
+import jakarta.persistence.ElementCollection;
+import jakarta.persistence.Entity;
+import jakarta.persistence.Id;
+import jakarta.persistence.Inheritance;
+import jakarta.persistence.InheritanceType;
+import jakarta.persistence.JoinColumn;
+import jakarta.persistence.ManyToMany;
+import jakarta.persistence.ManyToOne;
+import jakarta.persistence.OneToMany;
+
+import static org.hamcrest.core.Is.is;
+import static org.junit.Assert.assertThat;
+
 /**
  * @author Yanming Zhou
  */
+@Jira( "https://hibernate.atlassian.net/browse/HHH-14253" )
+@Jira( "https://hibernate.atlassian.net/browse/HHH-17550" )
 public class DefaultConstraintModeTest extends BaseUnitTestCase {
-
-	private static final String TABLE_NAME = "TestEntity";
-
 	@Test
-	@TestForIssue(jiraKey = "HHH-14253")
 	public void testForeignKeyShouldNotBeCreated() {
-		testForeignKeyCreation(false);
+		testForeignKeyCreation( false );
 	}
 
 	@Test
-	@TestForIssue(jiraKey = "HHH-14253")
 	public void testForeignKeyShouldBeCreated() {
-		testForeignKeyCreation(true);
+		testForeignKeyCreation( true );
 	}
 
 	private void testForeignKeyCreation(boolean created) {
 		try (StandardServiceRegistry ssr = ServiceRegistryUtil.serviceRegistryBuilder()
-				.applySetting(Environment.HBM2DDL_DEFAULT_CONSTRAINT_MODE, created ? "CONSTRAINT" : "NO_CONSTRAINT").build()) {
-			Metadata metadata = new MetadataSources( ssr ).addAnnotatedClass( TestEntity.class ).buildMetadata();
-			assertThat( findTable( metadata, TABLE_NAME ).getForeignKeys().isEmpty(), is( !created ) );
+				.applySetting( Environment.HBM2DDL_DEFAULT_CONSTRAINT_MODE, created ? "CONSTRAINT" : "NO_CONSTRAINT" )
+				.build()) {
+			Metadata metadata = new MetadataSources( ssr ).addAnnotatedClasses( TestEntity.class, ChildEntity.class ).buildMetadata();
+			assertThat( findTable( metadata, "TestEntity" ).getForeignKeys().isEmpty(), is( !created ) );
+			assertThat( findTable( metadata, "ChildEntity" ).getForeignKeys().isEmpty(), is( !created ) );
 		}
 	}
 
 	private static Table findTable(Metadata metadata, String tableName) {
-		return StreamSupport.stream(metadata.getDatabase().getNamespaces().spliterator(), false)
-				.flatMap(namespace -> namespace.getTables().stream()).filter(t -> t.getName().equals(tableName))
-				.findFirst().orElse(null);
+		return StreamSupport.stream( metadata.getDatabase().getNamespaces().spliterator(), false )
+				.flatMap( namespace -> namespace.getTables().stream() ).filter( t -> t.getName().equals( tableName ) )
+				.findFirst().orElse( null );
 	}
 
-	@Entity
-	@jakarta.persistence.Table(name = TABLE_NAME)
+	@Entity( name = "TestEntity" )
+	@jakarta.persistence.Table( name = "TestEntity" )
+	@Inheritance( strategy = InheritanceType.JOINED )
 	public static class TestEntity {
 
 		@Id
 		private Long id;
 
 		@ManyToOne
+		private TestEntity toOne;
+
+		@OneToMany
 		@JoinColumn
-		private TestEntity mate;
+		private List<ChildEntity> oneToMany;
+
+		@ManyToMany
+		private List<ChildEntity> manyToMany;
+
+		@ElementCollection
+		private List<String> elements;
+	}
 
+	@Entity( name = "ChildEntity" )
+	@jakarta.persistence.Table( name = "ChildEntity" )
+	public static class ChildEntity extends TestEntity {
+		private String childName;
 	}
 }