HHH-19497 Distribute 'not' to create a terser implementation and predicate.

Author: Mike Mannion

hibernate-core/src/main/java/org/hibernate/sql/ast/spi/AbstractSqlAstTranslator.java

@@ -7643,9 +7643,6 @@ public void visitInListPredicate(InListPredicate inListPredicate) {
 								.getExpressions().get( 0 );
 			}
 			else if ( !dialect.supportsRowValueConstructorSyntaxInInList() ) {
-				final ComparisonOperator comparisonOperator = inListPredicate.isNegated() ?
-						ComparisonOperator.NOT_EQUAL :
-						ComparisonOperator.EQUAL;
 				// Some DBs like Oracle support tuples only for the IN subquery predicate
 				if ( dialect.supportsRowValueConstructorSyntaxInInSubQuery() && dialect.supportsUnionAll() ) {
 					inListPredicate.getTestExpression().accept( this );
@@ -7664,20 +7661,21 @@ else if ( !dialect.supportsRowValueConstructorSyntaxInInList() ) {
 					appendSql( CLOSE_PARENTHESIS );
 				}
 				else {
-					if (inListPredicate.isNegated()) {
-						appendSql("not ");
-					}
+					final ComparisonOperator tupleComparisonOperator = inListPredicate.isNegated() ?
+							ComparisonOperator.NOT_EQUAL :
+							ComparisonOperator.EQUAL;
+					final String expressionJunction = inListPredicate.isNegated() ? " and " : " or ";
 					appendSql( OPEN_PARENTHESIS );
 					String separator = NO_SEPARATOR;
 					for (Expression expression : listExpressions) {
 						appendSql(separator);
 						emulateTupleComparison(
 								lhsTuple.getExpressions(),
 								SqlTupleContainer.getSqlTuple(expression).getExpressions(),
-								ComparisonOperator.EQUAL,
+								tupleComparisonOperator,
 								true
 						);
-						separator = " or ";
+						separator = expressionJunction;
 					}
 					appendSql( CLOSE_PARENTHESIS );
 				}