Skip to content

Commit 6d42e82

Browse files
committed
Skip some listagg tests on MySQL 8.0+ due to a MySQL regression
1 parent 3150805 commit 6d42e82

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

hibernate-core/src/test/java/org/hibernate/orm/test/query/criteria/CriteriaOrderedSetAggregateTest.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -200,13 +200,14 @@ public void testListaggWithFilterAndWindow(SessionFactoryScope scope) {
200200
}
201201

202202
/*
203-
* Skipped for MySQL 9.2: The test fails due to a regression in MySQL 9.2, which no longer supports NULLS FIRST/LAST in ORDER BY within LISTAGG as expected.
203+
* Skipped for MySQL 8.0: The test fails due to a regression in MySQL 8.0.x, which no longer supports NULLS FIRST/LAST in ORDER BY within LISTAGG as expected.
204204
* See https://bugs.mysql.com/bug.php?id=117765 for more details.
205205
* This is a MySQL issue, not a problem in the dialect implementation.
206206
*/
207207
@Test
208208
@RequiresDialectFeature(feature = DialectFeatureChecks.SupportsStringAggregation.class)
209-
@SkipForDialect(dialectClass = MySQLDialect.class, majorVersion = 9, minorVersion = 2, reason = "https://bugs.mysql.com/bug.php?id=117765")
209+
@SkipForDialect(dialectClass = MySQLDialect.class, majorVersion = 8, reason = "https://bugs.mysql.com/bug.php?id=117765")
210+
@SkipForDialect(dialectClass = MySQLDialect.class, majorVersion = 9, reason = "https://bugs.mysql.com/bug.php?id=117765")
210211
public void testListaggWithNullsClause(SessionFactoryScope scope) {
211212
scope.inTransaction( session -> {
212213
HibernateCriteriaBuilder cb = session.getCriteriaBuilder();

hibernate-core/src/test/java/org/hibernate/orm/test/query/hql/OrderedSetAggregateTest.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -136,14 +136,15 @@ public void testListaggWithFilter(SessionFactoryScope scope) {
136136
}
137137

138138
/*
139-
* Skipped for MySQL 9.2: The test fails due to a regression in MySQL 9.2, which no longer supports NULLS FIRST/LAST in ORDER BY within LISTAGG as expected.
139+
* Skipped for MySQL 8.0: The test fails due to a regression in MySQL 8.0.x, which no longer supports NULLS FIRST/LAST in ORDER BY within LISTAGG as expected.
140140
* See https://bugs.mysql.com/bug.php?id=117765 for more details.
141141
* This is a MySQL issue, not a problem in the dialect implementation.
142142
*/
143143
@Test
144144
@JiraKey( value = "HHH-15360")
145145
@RequiresDialectFeature(feature = DialectFeatureChecks.SupportsStringAggregation.class)
146-
@SkipForDialect(dialectClass = MySQLDialect.class, majorVersion = 9, minorVersion = 2, reason = "https://bugs.mysql.com/bug.php?id=117765")
146+
@SkipForDialect(dialectClass = MySQLDialect.class, majorVersion = 8, reason = "https://bugs.mysql.com/bug.php?id=117765")
147+
@SkipForDialect(dialectClass = MySQLDialect.class, majorVersion = 9, reason = "https://bugs.mysql.com/bug.php?id=117765")
147148
public void testListaggWithNullsClause(SessionFactoryScope scope) {
148149
scope.inTransaction(
149150
session -> {

0 commit comments

Comments
 (0)