tiny refactor to NullPrecedence stuff

Author: gavinking

hibernate-core/src/main/java/org/hibernate/query/NullPrecedence.java

@@ -7,6 +7,7 @@
 import org.hibernate.dialect.NullOrdering;
 
 import jakarta.persistence.criteria.Nulls;
+import org.hibernate.query.internal.NullPrecedenceHelper;
 
 /**
  * Enumerates the possibilities for the precedence of null values within
@@ -38,21 +39,7 @@ public enum NullPrecedence {
 	 */
 	@Deprecated(since = "7.0", forRemoval = true)
 	public boolean isDefaultOrdering(SortDirection sortOrder, NullOrdering nullOrdering) {
-		return switch (this) {
-			case NONE -> true;
-			case FIRST -> switch (nullOrdering) {
-				case FIRST -> true;
-				case LAST -> false;
-				case SMALLEST -> sortOrder == SortDirection.ASCENDING;
-				case GREATEST -> sortOrder == SortDirection.DESCENDING;
-			};
-			case LAST -> switch (nullOrdering) {
-				case LAST -> true;
-				case FIRST -> false;
-				case SMALLEST -> sortOrder == SortDirection.DESCENDING;
-				case GREATEST -> sortOrder == SortDirection.ASCENDING;
-			};
-		};
+		return NullPrecedenceHelper.isDefaultOrdering( getJpaValue(), sortOrder, nullOrdering );
 	}
 
 	/**
@@ -99,6 +86,5 @@ public static NullPrecedence fromJpaValue(Nulls jpaValue) {
 			case FIRST -> NullPrecedence.FIRST;
 			case LAST -> NullPrecedence.LAST;
 		};
-
 	}
 }

hibernate-core/src/main/java/org/hibernate/query/internal/NullPrecedenceHelper.java

@@ -4,7 +4,6 @@
  */
 package org.hibernate.query.internal;
 
-import org.hibernate.AssertionFailure;
 import org.hibernate.dialect.NullOrdering;
 import org.hibernate.query.SortDirection;
 
@@ -22,38 +21,21 @@ public static boolean isDefaultOrdering(
 			Nulls precedence,
 			SortDirection sortOrder,
 			NullOrdering nullOrdering) {
-		switch (precedence) {
-			case NONE:
-				return true;
-			case FIRST:
-				switch ( nullOrdering ) {
-					case FIRST:
-						return true;
-					case LAST:
-						return false;
-					case SMALLEST:
-						return sortOrder == SortDirection.ASCENDING;
-					case GREATEST:
-						return sortOrder == SortDirection.DESCENDING;
-					default:
-						throw new AssertionFailure( "Unrecognized NullOrdering");
-				}
-			case LAST:
-				switch ( nullOrdering ) {
-					case LAST:
-						return true;
-					case FIRST:
-						return false;
-					case SMALLEST:
-						return sortOrder == SortDirection.DESCENDING;
-					case GREATEST:
-						return sortOrder == SortDirection.ASCENDING;
-					default:
-						throw new AssertionFailure("Unrecognized NullOrdering");
-				}
-			default:
-				throw new AssertionFailure("Unrecognized NullPrecedence");
-		}
+		return switch ( precedence ) {
+			case NONE -> true;
+			case FIRST -> switch ( nullOrdering ) {
+				case FIRST -> true;
+				case LAST -> false;
+				case SMALLEST -> sortOrder == SortDirection.ASCENDING;
+				case GREATEST -> sortOrder == SortDirection.DESCENDING;
+			};
+			case LAST -> switch ( nullOrdering ) {
+				case LAST -> true;
+				case FIRST -> false;
+				case SMALLEST -> sortOrder == SortDirection.DESCENDING;
+				case GREATEST -> sortOrder == SortDirection.ASCENDING;
+			};
+		};
 	}
 
 	/**