move management of fetch profiles to the SqlTranslationEngine

gavinking · gavinking · commit 6eacabbc63c2 · 2025-01-05T16:30:46.000+01:00
diff --git a/hibernate-core/src/main/java/org/hibernate/internal/FetchProfileHelper.java b/hibernate-core/src/main/java/org/hibernate/internal/FetchProfileHelper.java
@@ -33,16 +33,21 @@
  */
 public class FetchProfileHelper {
 
+	@SuppressWarnings("unused")
 	public static Map<String, FetchProfile> getFetchProfiles(
 			MetadataImplementor bootMetamodel,
 			RuntimeMetamodels runtimeMetamodels) {
 		final Map<String, FetchProfile> fetchProfiles = new HashMap<>();
+		addFetchProfiles( bootMetamodel, runtimeMetamodels, fetchProfiles );
+		return fetchProfiles;
+	}
+
+	static void addFetchProfiles(MetadataImplementor bootMetamodel, RuntimeMetamodels runtimeMetamodels, Map<String, FetchProfile> fetchProfiles) {
 		for ( org.hibernate.mapping.FetchProfile mappingProfile : bootMetamodel.getFetchProfiles() ) {
 			final FetchProfile fetchProfile = createFetchProfile( runtimeMetamodels.getMappingMetamodel(), mappingProfile );
 			fetchProfiles.put( fetchProfile.getName(), fetchProfile );
 		}
 		fetchProfiles.put( HIBERNATE_DEFAULT_PROFILE, new DefaultFetchProfile( runtimeMetamodels ) );
-		return fetchProfiles;
 	}
 
 	private static FetchProfile createFetchProfile(
@@ -53,7 +58,9 @@ private static FetchProfile createFetchProfile(
 		for ( org.hibernate.mapping.FetchProfile.Fetch mappingFetch : mappingProfile.getFetches() ) {
 			// resolve the persister owning the fetch
 			final EntityPersister owner = getEntityPersister( mappingMetamodel, fetchProfile, mappingFetch );
-			( (FetchProfileAffectee) owner ).registerAffectingFetchProfile( profileName);
+			if ( owner instanceof FetchProfileAffectee fetchProfileAffectee ) {
+				fetchProfileAffectee.registerAffectingFetchProfile( profileName );
+			}
 
 			final Association association = new Association( owner, mappingFetch.getAssociation() );
 			final FetchStyle fetchStyle = fetchStyle( mappingFetch.getMethod() );
@@ -62,8 +69,8 @@ private static FetchProfile createFetchProfile(
 			// validate the specified association fetch
 			final ModelPart fetchablePart = owner.findByPath( association.getAssociationPath() );
 			validateFetchablePart( fetchablePart, profileName, association );
-			if ( fetchablePart instanceof FetchProfileAffectee ) {
-				( (FetchProfileAffectee) fetchablePart ).registerAffectingFetchProfile( profileName );
+			if ( fetchablePart instanceof FetchProfileAffectee fetchProfileAffectee ) {
+				fetchProfileAffectee.registerAffectingFetchProfile( profileName );
 			}
 
 			// then register the association with the FetchProfile
@@ -73,16 +80,11 @@ private static FetchProfile createFetchProfile(
 	}
 
 	private static FetchStyle fetchStyle(FetchMode fetchMode) {
-		switch ( fetchMode ) {
-			case JOIN:
-				return FetchStyle.JOIN;
-			case SELECT:
-				return FetchStyle.SELECT;
-			case SUBSELECT:
-				return FetchStyle.SUBSELECT;
-			default:
-				throw new IllegalArgumentException( "Unknown FetchMode" );
-		}
+		return switch ( fetchMode ) {
+			case JOIN -> FetchStyle.JOIN;
+			case SELECT -> FetchStyle.SELECT;
+			case SUBSELECT -> FetchStyle.SUBSELECT;
+		};
 	}
 
 	private static void validateFetchablePart(ModelPart fetchablePart, String profileName, Association association) {
diff --git a/hibernate-core/src/main/java/org/hibernate/internal/SessionFactoryImpl.java b/hibernate-core/src/main/java/org/hibernate/internal/SessionFactoryImpl.java
@@ -139,7 +139,7 @@
 import static java.util.Collections.emptySet;
 import static java.util.Collections.unmodifiableSet;
 import static org.hibernate.cfg.AvailableSettings.CURRENT_SESSION_CONTEXT_CLASS;
-import static org.hibernate.internal.FetchProfileHelper.getFetchProfiles;
+import static org.hibernate.internal.FetchProfileHelper.addFetchProfiles;
 import static org.hibernate.internal.SessionFactorySettings.deprecationCheck;
 import static org.hibernate.internal.SessionFactorySettings.determineJndiName;
 import static org.hibernate.internal.SessionFactorySettings.getSessionFactoryName;
@@ -201,7 +201,6 @@ public class SessionFactoryImpl implements SessionFactoryImplementor, BindingCon
 
 	private final transient Map<String, FilterDefinition> filters;
 	private final transient java.util.Collection<FilterDefinition> autoEnabledFilters = new HashSet<>();
-	private final transient Map<String, FetchProfile> fetchProfiles;
 	private final transient JavaType<Object> tenantIdentifierJavaType;
 
 	private final transient EventListenerGroups eventListenerGroups;
@@ -305,7 +304,8 @@ public SessionFactoryImpl(
 			// and SqmFunctionRegistry, instantiating just the
 			// registry here, and doing the engine later
 			queryEngine = new QueryEngineImpl( bootMetamodel, options, this, serviceRegistry, settings, name );
-			sqlTranslationEngine = new SqlTranslationEngineImpl( this, typeConfiguration );
+			final Map<String, FetchProfile> fetchProfiles = new HashMap<>();
+			sqlTranslationEngine = new SqlTranslationEngineImpl( this, typeConfiguration, fetchProfiles );
 
 			// create runtime metamodels (mapping and JPA)
 			final RuntimeMetamodelsImpl runtimeMetamodelsImpl = new RuntimeMetamodelsImpl();
@@ -318,7 +318,7 @@ public SessionFactoryImpl(
 
 			// this needs to happen after the mapping metamodel is
 			// completely built, since we need to use the persisters
-			fetchProfiles = getFetchProfiles( bootMetamodel, runtimeMetamodelsImpl );
+			addFetchProfiles( bootMetamodel, runtimeMetamodelsImpl, fetchProfiles );
 
 			defaultSessionOpenOptions = createDefaultSessionOpenOptionsIfPossible();
 			temporarySessionOpenOptions = defaultSessionOpenOptions == null ? null : buildTemporarySessionOpenOptions();
@@ -1035,18 +1035,23 @@ public java.util.Collection<FilterDefinition> getAutoEnabledFilters() {
 	}
 
 	@Override
-	public boolean containsFetchProfileDefinition(String name) {
-		return fetchProfiles.containsKey( name );
+	public Set<String> getDefinedFilterNames() {
+		return unmodifiableSet( filters.keySet() );
 	}
 
 	@Override
-	public Set<String> getDefinedFilterNames() {
-		return unmodifiableSet( filters.keySet() );
+	public FetchProfile getFetchProfile(String name) {
+		return sqlTranslationEngine.getFetchProfile( name );
+	}
+
+	@Override
+	public boolean containsFetchProfileDefinition(String name) {
+		return sqlTranslationEngine.containsFetchProfileDefinition( name );
 	}
 
 	@Override
 	public Set<String> getDefinedFetchProfileNames() {
-		return unmodifiableSet( fetchProfiles.keySet() );
+		return sqlTranslationEngine.getDefinedFetchProfileNames();
 	}
 
 	@Override @Deprecated
@@ -1126,11 +1131,6 @@ public EntityNotFoundDelegate getEntityNotFoundDelegate() {
 		return sessionFactoryOptions.getEntityNotFoundDelegate();
 	}
 
-	@Override
-	public FetchProfile getFetchProfile(String name) {
-		return fetchProfiles.get( name );
-	}
-
 	/**
 	 * @deprecated use {@link #configuredInterceptor(Interceptor, boolean, SessionFactoryOptions)}
 	 */
diff --git a/hibernate-core/src/main/java/org/hibernate/loader/ast/internal/SingleIdEntityLoaderStandardImpl.java b/hibernate-core/src/main/java/org/hibernate/loader/ast/internal/SingleIdEntityLoaderStandardImpl.java
@@ -36,7 +36,8 @@ public SingleIdEntityLoaderStandardImpl(
 		this(
 				entityDescriptor,
 				loadQueryInfluencers,
-				(lockOptions, influencers) -> createLoadPlan( entityDescriptor, lockOptions, influencers, influencers.getSessionFactory() )
+				(lockOptions, influencers) ->
+						createLoadPlan( entityDescriptor, lockOptions, influencers, influencers.getSessionFactory() )
 		);
 	}
 
diff --git a/hibernate-core/src/main/java/org/hibernate/query/sql/internal/SqlTranslationEngineImpl.java b/hibernate-core/src/main/java/org/hibernate/query/sql/internal/SqlTranslationEngineImpl.java
@@ -11,16 +11,31 @@
 import org.hibernate.query.sql.spi.SqlTranslationEngine;
 import org.hibernate.type.spi.TypeConfiguration;
 
+import java.util.Map;
+import java.util.Set;
+
+import static java.util.Collections.unmodifiableSet;
+
 public class SqlTranslationEngineImpl implements SqlTranslationEngine {
 
 	//TODO: consider unifying with SqlStringGenerationContextImpl
 
 	private final SessionFactoryImplementor factory;
 	private final TypeConfiguration typeConfiguration;
+	private final Map<String, FetchProfile> fetchProfiles;
 
-	public SqlTranslationEngineImpl(SessionFactoryImplementor factory, TypeConfiguration typeConfiguration) {
+	public SqlTranslationEngineImpl(
+			SessionFactoryImplementor factory,
+			TypeConfiguration typeConfiguration,
+			Map<String, FetchProfile> fetchProfiles) {
 		this.factory = factory;
 		this.typeConfiguration = typeConfiguration;
+		this.fetchProfiles = fetchProfiles;
+	}
+
+	@Override
+	public TypeConfiguration getTypeConfiguration() {
+		return typeConfiguration;
 	}
 
 	@Override
@@ -50,11 +65,16 @@ public JpaMetamodel getJpaMetamodel() {
 
 	@Override
 	public FetchProfile getFetchProfile(String name) {
-		return factory.getFetchProfile( name );
+		return fetchProfiles.get( name );
 	}
 
 	@Override
-	public TypeConfiguration getTypeConfiguration() {
-		return typeConfiguration;
+	public boolean containsFetchProfileDefinition(String name) {
+		return fetchProfiles.containsKey( name );
+	}
+
+	@Override
+	public Set<String> getDefinedFetchProfileNames() {
+		return unmodifiableSet( fetchProfiles.keySet() );
 	}
 }
diff --git a/hibernate-core/src/main/java/org/hibernate/query/sql/spi/SqlTranslationEngine.java b/hibernate-core/src/main/java/org/hibernate/query/sql/spi/SqlTranslationEngine.java
@@ -7,6 +7,8 @@
 import org.hibernate.Incubating;
 import org.hibernate.sql.ast.spi.SqlAstCreationContext;
 
+import java.util.Set;
+
 /**
  * Introduced as an analog of {@link org.hibernate.query.spi.QueryEngine}
  * and/or {@link org.hibernate.query.sqm.NodeBuilder} for the SQL
@@ -19,4 +21,8 @@
 @Incubating
 public interface SqlTranslationEngine extends SqlAstCreationContext {
 	// TODO: consider implementing SqlStringGenerationContext
+
+	boolean containsFetchProfileDefinition(String name);
+
+	Set<String> getDefinedFetchProfileNames();
 }
diff --git a/hibernate-core/src/main/java/org/hibernate/sql/ast/spi/SqlAstCreationContext.java b/hibernate-core/src/main/java/org/hibernate/sql/ast/spi/SqlAstCreationContext.java
@@ -56,14 +56,24 @@ public interface SqlAstCreationContext extends BindingContext {
 	 */
 	FetchProfile getFetchProfile(String name);
 
+	/**
+	 * Obtain the {@link SqmFunctionRegistry}.
+	 */
 	default SqmFunctionRegistry getSqmFunctionRegistry() {
 		return getSessionFactory().getQueryEngine().getSqmFunctionRegistry();
 	}
 
+	/**
+	 * Obtain the {@link Dialect}.
+	 */
 	default Dialect getDialect() {
 		return getSessionFactory().getQueryEngine().getDialect();
 	}
 
+	/**
+	 * Obtain the "incomplete" {@link WrapperOptions} that would be
+	 * returned by {@link SessionFactoryImplementor#getWrapperOptions()}.
+	 */
 	default WrapperOptions getWrapperOptions() {
 		return getSessionFactory().getWrapperOptions();
 	}
diff --git a/tooling/metamodel-generator/src/main/java/org/hibernate/processor/validation/MockSessionFactory.java b/tooling/metamodel-generator/src/main/java/org/hibernate/processor/validation/MockSessionFactory.java
@@ -239,7 +239,7 @@ public Class<?> classForName(String className) {
 
 		nodeBuilder = new SqmCriteriaNodeBuilder("", "", this, this, this);
 
-		sqlTranslationEngine = new SqlTranslationEngineImpl(this, typeConfiguration);
+		sqlTranslationEngine = new SqlTranslationEngineImpl(this, typeConfiguration, emptyMap() );
 	}
 
 	@Override

Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,8 @@ public SingleIdEntityLoaderStandardImpl(`
`36`	`36`	`this(`
`37`	`37`	`entityDescriptor,`
`38`	`38`	`loadQueryInfluencers,`
`39`		`- (lockOptions, influencers) -> createLoadPlan( entityDescriptor, lockOptions, influencers, influencers.getSessionFactory() )`
	`39`	`+ (lockOptions, influencers) ->`
	`40`	`+ createLoadPlan( entityDescriptor, lockOptions, influencers, influencers.getSessionFactory() )`
`40`	`41`	`);`
`41`	`42`	`}`
`42`	`43`
Original file line number	Diff line number	Diff line change
`@@ -239,7 +239,7 @@ public Class<?> classForName(String className) {`
`239`	`239`
`240`	`240`	`nodeBuilder = new SqmCriteriaNodeBuilder("", "", this, this, this);`
`241`	`241`
`242`		`- sqlTranslationEngine = new SqlTranslationEngineImpl(this, typeConfiguration);`
	`242`	`+ sqlTranslationEngine = new SqlTranslationEngineImpl(this, typeConfiguration, emptyMap() );`
`243`	`243`	`}`
`244`	`244`
`245`	`245`	`@Override`