SQL Templates no longer use the SqmFunctionRegistry so we can simplify

gavinking · gavinking · commit 715ea1dd73f9 · 2025-01-06T16:09:06.000+01:00
diff --git a/hibernate-core/src/main/java/org/hibernate/boot/model/internal/AggregateComponentSecondPass.java b/hibernate-core/src/main/java/org/hibernate/boot/model/internal/AggregateComponentSecondPass.java
@@ -151,11 +151,7 @@ public void doSecondPass(Map<String, PersistentClass> persistentClasses) throws
 			if ( subColumn.getCustomReadExpression() == null ) {
 				if ( subColumn.isFormula() ) {
 					customReadExpression = aggregateSupport.aggregateComponentCustomReadExpression(
-							subColumn.getTemplate(
-									dialect,
-									typeConfiguration,
-									null
-							),
+							subColumn.getTemplate( dialect, typeConfiguration ),
 							Template.TEMPLATE + ".",
 							aggregateReadTemplate,
 							"",
diff --git a/hibernate-core/src/main/java/org/hibernate/internal/SessionFactoryImpl.java b/hibernate-core/src/main/java/org/hibernate/internal/SessionFactoryImpl.java
@@ -288,16 +288,8 @@ public SessionFactoryImpl(
 			runtimeMetamodels = runtimeMetamodelsImpl;
 
 			// we build this before creating the runtime metamodels
-			// because the persisters need the SqmFunctionRegistry
-			// to translate SQL formulas. But, if we fix Dialect
-			// as I proposed, so that it can contribute functions
-			// to the SqmFunctionRegistry before the QueryEngine is
-			// created, then we can split creation of QueryEngine
-			// and SqmFunctionRegistry, instantiating just the
-			// registry here, and doing the engine later, and we
-			// can thus untie this nasty little knot. Alternatively,
-			// perhaps it's not really appropriate that they use the
-			// SqmFunctionRegistry for that purpose at all?
+			// because the SqlAstTranslators (unnecessarily, perhaps)
+			// use the SqmFunctionRegistry when rendering SQL for Loaders
 			queryEngine = new QueryEngineImpl( bootMetamodel, options, runtimeMetamodels, serviceRegistry, settings, name );
 			final Map<String, FetchProfile> fetchProfiles = new HashMap<>();
 			sqlTranslationEngine = new SqlTranslationEngineImpl( this, typeConfiguration, fetchProfiles );
diff --git a/hibernate-core/src/main/java/org/hibernate/mapping/Column.java b/hibernate-core/src/main/java/org/hibernate/mapping/Column.java
@@ -21,7 +21,6 @@
 import org.hibernate.engine.jdbc.Size;
 import org.hibernate.loader.internal.AliasConstantsHelper;
 import org.hibernate.metamodel.mapping.JdbcMapping;
-import org.hibernate.query.sqm.function.SqmFunctionRegistry;
 import org.hibernate.sql.Template;
 import org.hibernate.tool.schema.extract.spi.ColumnTypeInformation;
 import org.hibernate.type.BasicType;
@@ -622,7 +621,7 @@ public boolean hasCheckConstraint() {
 	}
 
 	@Override
-	public String getTemplate(Dialect dialect, TypeConfiguration typeConfiguration, SqmFunctionRegistry registry) {
+	public String getTemplate(Dialect dialect, TypeConfiguration typeConfiguration) {
 		return safeInterning(
 				hasCustomRead()
 					// see note in renderTransformerReadFragment wrt access to SessionFactory
diff --git a/hibernate-core/src/main/java/org/hibernate/mapping/Formula.java b/hibernate-core/src/main/java/org/hibernate/mapping/Formula.java
@@ -9,7 +9,6 @@
 
 import org.hibernate.dialect.Dialect;
 import org.hibernate.loader.internal.AliasConstantsHelper;
-import org.hibernate.query.sqm.function.SqmFunctionRegistry;
 import org.hibernate.type.spi.TypeConfiguration;
 
 import static org.hibernate.internal.util.StringHelper.replace;
@@ -40,7 +39,7 @@ public Formula(String formula) {
 	}
 
 	@Override
-	public String getTemplate(Dialect dialect, TypeConfiguration typeConfiguration, SqmFunctionRegistry registry) {
+	public String getTemplate(Dialect dialect, TypeConfiguration typeConfiguration) {
 		final String template = renderWhereStringTemplate( formula, dialect, typeConfiguration );
 		return safeInterning( replace( template, "{alias}", TEMPLATE ) );
 	}
diff --git a/hibernate-core/src/main/java/org/hibernate/mapping/IdentifierCollection.java b/hibernate-core/src/main/java/org/hibernate/mapping/IdentifierCollection.java
@@ -26,7 +26,10 @@ public IdentifierCollection(MetadataBuildingContext buildingContext, PersistentC
 		super( buildingContext, owner );
 	}
 
-	public IdentifierCollection(Supplier<ManagedBean<? extends UserCollectionType>> customTypeBeanResolver, PersistentClass owner, MetadataBuildingContext buildingContext) {
+	public IdentifierCollection(
+			Supplier<ManagedBean<? extends UserCollectionType>> customTypeBeanResolver,
+			PersistentClass owner,
+			MetadataBuildingContext buildingContext) {
 		super( customTypeBeanResolver, owner, buildingContext );
 	}
 
@@ -38,22 +41,24 @@ protected IdentifierCollection(IdentifierCollection original) {
 	public KeyValue getIdentifier() {
 		return identifier;
 	}
+
 	public void setIdentifier(KeyValue identifier) {
 		this.identifier = identifier;
 	}
+
 	public final boolean isIdentified() {
 		return true;
 	}
 
 	@Override
 	public boolean isSame(Collection other) {
 		return other instanceof IdentifierCollection
-				&& isSame( (IdentifierCollection) other );
+			&& isSame( (IdentifierCollection) other );
 	}
 
 	public boolean isSame(IdentifierCollection other) {
 		return super.isSame( other )
-				&& isSame( identifier, other.identifier );
+			&& isSame( identifier, other.identifier );
 	}
 
 	void createPrimaryKey() {
diff --git a/hibernate-core/src/main/java/org/hibernate/mapping/PersistentClass.java b/hibernate-core/src/main/java/org/hibernate/mapping/PersistentClass.java
@@ -29,7 +29,6 @@
 import org.hibernate.jdbc.Expectation;
 import org.hibernate.jpa.event.spi.CallbackDefinition;
 import org.hibernate.metamodel.spi.RuntimeModelCreationContext;
-import org.hibernate.query.sqm.function.SqmFunctionRegistry;
 import org.hibernate.service.ServiceRegistry;
 import org.hibernate.sql.Alias;
 import org.hibernate.type.CollectionType;
@@ -1019,7 +1018,6 @@ public void prepareForMappingModel(RuntimeModelCreationContext context) {
 			// in SQL formulas
 			final Dialect dialect = context.getDialect();
 			final TypeConfiguration types = context.getTypeConfiguration();
-			final SqmFunctionRegistry functions = context.getFunctionRegistry();
 
 			// now, move @Formulas to the correct AttributeContainers
 			//TODO: skip this step for hbm.xml
@@ -1028,7 +1026,7 @@ public void prepareForMappingModel(RuntimeModelCreationContext context) {
 					if ( selectable.isFormula() && properties.contains( property ) ) {
 						final Formula formula = (Formula) selectable;
 						final AttributeContainer container =
-								container( collectColumnNames( formula.getTemplate( dialect, types, functions ) ) );
+								container( collectColumnNames( formula.getTemplate( dialect, types ) ) );
 						if ( !container.contains( property ) ) {
 							properties.remove( property );
 							container.addProperty( property );
diff --git a/hibernate-core/src/main/java/org/hibernate/mapping/Selectable.java b/hibernate-core/src/main/java/org/hibernate/mapping/Selectable.java
@@ -7,7 +7,6 @@
 import org.hibernate.Incubating;
 import org.hibernate.dialect.Dialect;
 import org.hibernate.metamodel.mapping.JdbcMapping;
-import org.hibernate.query.sqm.function.SqmFunctionRegistry;
 import org.hibernate.type.spi.TypeConfiguration;
 
 /**
@@ -61,7 +60,7 @@ public sealed interface Selectable permits Column, Formula {
 	@Deprecated(since = "6.0")
 	String getAlias(Dialect dialect, Table table);
 
-	String getTemplate(Dialect dialect, TypeConfiguration typeConfiguration, SqmFunctionRegistry functionRegistry);
+	String getTemplate(Dialect dialect, TypeConfiguration typeConfiguration);
 
 	@Incubating
 	default String getWriteExpr() {
diff --git a/hibernate-core/src/main/java/org/hibernate/metamodel/mapping/internal/AbstractEmbeddableMapping.java b/hibernate-core/src/main/java/org/hibernate/metamodel/mapping/internal/AbstractEmbeddableMapping.java
@@ -309,8 +309,7 @@ protected boolean finishInitialization(
 					if ( selectable.isFormula() ) {
 						columnExpression = selectable.getTemplate(
 								dialect,
-								creationProcess.getCreationContext().getTypeConfiguration(),
-								creationProcess.getSqmFunctionRegistry()
+								creationProcess.getCreationContext().getTypeConfiguration()
 						);
 					}
 					else {
diff --git a/hibernate-core/src/main/java/org/hibernate/metamodel/mapping/internal/EmbeddableMappingTypeImpl.java b/hibernate-core/src/main/java/org/hibernate/metamodel/mapping/internal/EmbeddableMappingTypeImpl.java
@@ -453,8 +453,7 @@ private boolean finishInitialization(
 					if ( selectable.isFormula() ) {
 						columnExpression = selectable.getTemplate(
 								dialect,
-								creationProcess.getCreationContext().getTypeConfiguration(),
-								creationProcess.getSqmFunctionRegistry()
+								creationProcess.getCreationContext().getTypeConfiguration()
 						);
 					}
 					else {
@@ -726,8 +725,7 @@ private EmbeddableDiscriminatorMapping generateDiscriminatorMapping(
 			final Formula formula = (Formula) selectable;
 			discriminatorColumnExpression = name = formula.getTemplate(
 					creationContext.getDialect(),
-					creationContext.getTypeConfiguration(),
-					creationContext.getFunctionRegistry()
+					creationContext.getTypeConfiguration()
 			);
 			columnDefinition = null;
 			length = null;
diff --git a/hibernate-core/src/main/java/org/hibernate/metamodel/mapping/internal/SelectableMappingImpl.java b/hibernate-core/src/main/java/org/hibernate/metamodel/mapping/internal/SelectableMappingImpl.java
@@ -172,7 +172,7 @@ public static SelectableMapping from(
 		final boolean isLob;
 		final boolean isNullable;
 		if ( selectable.isFormula() ) {
-			columnExpression = selectable.getTemplate( dialect, typeConfiguration, sqmFunctionRegistry );
+			columnExpression = selectable.getTemplate( dialect, typeConfiguration );
 			columnDefinition = null;
 			length = null;
 			precision = null;
diff --git a/hibernate-core/src/main/java/org/hibernate/persister/collection/AbstractCollectionPersister.java b/hibernate-core/src/main/java/org/hibernate/persister/collection/AbstractCollectionPersister.java
@@ -126,6 +126,7 @@
 import org.hibernate.type.CompositeType;
 import org.hibernate.type.EntityType;
 import org.hibernate.type.Type;
+import org.hibernate.type.spi.TypeConfiguration;
 
 import java.sql.PreparedStatement;
 import java.sql.ResultSet;
@@ -284,7 +285,8 @@ public AbstractCollectionPersister(
 		sqlExceptionHelper = creationContext.getJdbcServices().getSqlExceptionHelper();
 		collectionType = collectionBootDescriptor.getCollectionType();
 		navigableRole = new NavigableRole( collectionBootDescriptor.getRole() );
-		ownerPersister = creationContext.getDomainModel().getEntityDescriptor( collectionBootDescriptor.getOwnerEntityName() );
+		ownerPersister = creationContext.getDomainModel()
+				.getEntityDescriptor( collectionBootDescriptor.getOwnerEntityName() );
 		queryLoaderName = collectionBootDescriptor.getLoaderName();
 		isMutable = collectionBootDescriptor.isMutable();
 		mappedByProperty = collectionBootDescriptor.getMappedByProperty();
@@ -329,7 +331,7 @@ public AbstractCollectionPersister(
 				keyColumnNames[k] = column.getQuotedName( dialect );
 			}
 			else {
-				throw new MappingException("Collection keys may not contain formulas: " + navigableRole.getFullPath() );
+				throw new MappingException( "Collection keys may not contain formulas: " + navigableRole.getFullPath() );
 			}
 			k++;
 		}
@@ -350,6 +352,8 @@ public AbstractCollectionPersister(
 		// because it is needed in OneToManyPersister.getTableName()
 		spaces[0] = getTableName();
 
+		final TypeConfiguration typeConfiguration = creationContext.getTypeConfiguration();
+
 		final int elementSpan = elementBootDescriptor.getColumnSpan();
 		elementColumnAliases = new String[elementSpan];
 		elementColumnNames = new String[elementSpan];
@@ -371,23 +375,15 @@ public AbstractCollectionPersister(
 			elementColumnAliases[j] = selectable.getAlias( dialect, table );
 			if ( selectable.isFormula() ) {
 				Formula form = (Formula) selectable;
-				elementFormulaTemplates[j] = form.getTemplate(
-						dialect,
-						creationContext.getTypeConfiguration(),
-						creationContext.getFunctionRegistry()
-				);
+				elementFormulaTemplates[j] = form.getTemplate( dialect, typeConfiguration );
 				elementFormulas[j] = form.getFormula();
 			}
 			else {
 				final Column col = (Column) selectable;
 				elementColumnNames[j] = col.getQuotedName( dialect );
 				elementColumnWriters[j] = col.getWriteExpr( elementBootDescriptor.getSelectableType( factory.getRuntimeMetamodels(), j ), dialect );
 				elementColumnReaders[j] = col.getReadExpr( dialect );
-				elementColumnReaderTemplates[j] = col.getTemplate(
-						dialect,
-						creationContext.getTypeConfiguration(),
-						creationContext.getFunctionRegistry()
-				);
+				elementColumnReaderTemplates[j] = col.getTemplate( dialect, typeConfiguration );
 				elementColumnIsGettable[j] = true;
 				if ( elementType instanceof ComponentType || elementType instanceof AnyType ) {
 					// Implements desired behavior specifically for @ElementCollection mappings.
@@ -425,11 +421,7 @@ public AbstractCollectionPersister(
 				indexColumnAliases[i] = selectable.getAlias( dialect );
 				if ( selectable.isFormula() ) {
 					final Formula indexForm = (Formula) selectable;
-					indexFormulaTemplates[i] = indexForm.getTemplate(
-							dialect,
-							creationContext.getTypeConfiguration(),
-							creationContext.getFunctionRegistry()
-					);
+					indexFormulaTemplates[i] = indexForm.getTemplate( dialect, typeConfiguration );
 					indexFormulas[i] = indexForm.getFormula();
 					hasFormula = true;
 				}
@@ -529,11 +521,8 @@ public AbstractCollectionPersister(
 		}
 		else {
 			manyToManyWhereString = "( " + collectionBootDescriptor.getManyToManyWhere() + ")";
-			manyToManyWhereTemplate = renderWhereStringTemplate(
-					manyToManyWhereString,
-					creationContext.getDialect(),
-					creationContext.getTypeConfiguration()
-			);
+			manyToManyWhereTemplate =
+					renderWhereStringTemplate( manyToManyWhereString, creationContext.getDialect(), typeConfiguration );
 		}
 
 		comparator = collectionBootDescriptor.getComparator();
diff --git a/hibernate-core/src/main/java/org/hibernate/persister/entity/AbstractEntityPersister.java b/hibernate-core/src/main/java/org/hibernate/persister/entity/AbstractEntityPersister.java
@@ -191,7 +191,6 @@
 import org.hibernate.query.spi.QueryOptions;
 import org.hibernate.query.sql.internal.SQLQueryParser;
 import org.hibernate.query.sqm.ComparisonOperator;
-import org.hibernate.query.sqm.function.SqmFunctionRegistry;
 import org.hibernate.query.sqm.mutation.spi.SqmMultiTableInsertStrategy;
 import org.hibernate.query.sqm.mutation.spi.SqmMultiTableMutationStrategy;
 import org.hibernate.query.sqm.mutation.spi.SqmMultiTableMutationStrategyProvider;
@@ -547,18 +546,13 @@ public AbstractEntityPersister(
 		queryLoaderName = persistentClass.getLoaderName();
 
 		final TypeConfiguration typeConfiguration = creationContext.getTypeConfiguration();
-		final SqmFunctionRegistry functionRegistry = creationContext.getFunctionRegistry();
 
 		final List<Column> columns = persistentClass.getIdentifier().getColumns();
 		for (int i = 0; i < columns.size(); i++ ) {
 			final Column column = columns.get(i);
 			rootTableKeyColumnNames[i] = column.getQuotedName( dialect );
 			rootTableKeyColumnReaders[i] = column.getReadExpr( dialect );
-			rootTableKeyColumnReaderTemplates[i] = column.getTemplate(
-					dialect,
-					typeConfiguration,
-					functionRegistry
-			);
+			rootTableKeyColumnReaderTemplates[i] = column.getTemplate( dialect, typeConfiguration );
 			identifierAliases[i] = column.getAlias( dialect, persistentClass.getRootTable() );
 		}
 
@@ -626,8 +620,7 @@ public AbstractEntityPersister(
 					formula.setFormula( substituteBrackets( formula.getFormula() ) );
 					formulaTemplates[k] = selectable.getTemplate(
 							dialect,
-							typeConfiguration,
-							functionRegistry
+							typeConfiguration
 					);
 				}
 				else {
@@ -702,11 +695,7 @@ public AbstractEntityPersister(
 			for ( int i = 0; i < selectables.size(); i++ ) {
 				final Selectable selectable = selectables.get(i);
 				if ( selectable.isFormula() ) {
-					final String template = selectable.getTemplate(
-							dialect,
-							typeConfiguration,
-							functionRegistry
-					);
+					final String template = selectable.getTemplate( dialect, typeConfiguration );
 					forms[i] = template;
 					final String formulaAlias = selectable.getAlias( dialect );
 					if ( prop.isSelectable() && !formulaAliases.contains( formulaAlias ) ) {
@@ -725,8 +714,7 @@ public AbstractEntityPersister(
 					readers[i] = column.getReadExpr( dialect );
 					readerTemplates[i] = column.getTemplate(
 							dialect,
-							typeConfiguration,
-							functionRegistry
+							typeConfiguration
 					);
 					if ( thisClassProperties.contains( prop )
 							? persistentClass.hasSubclasses()
@@ -5413,8 +5401,7 @@ protected AttributeMapping generateNonIdAttributeMapping(
 
 					customReadExpr = selectable.getTemplate(
 							creationContext.getDialect(),
-							creationContext.getTypeConfiguration(),
-							creationContext.getFunctionRegistry()
+							creationContext.getTypeConfiguration()
 					);
 					customWriteExpr = selectable.getWriteExpr( (JdbcMapping) attrType, creationContext.getDialect() );
 					Column column = value.getColumns().get( 0 );
diff --git a/hibernate-core/src/main/java/org/hibernate/persister/entity/JoinedSubclassEntityPersister.java b/hibernate-core/src/main/java/org/hibernate/persister/entity/JoinedSubclassEntityPersister.java
@@ -46,7 +46,6 @@
 import org.hibernate.metamodel.mapping.internal.MappingModelCreationProcess;
 import org.hibernate.metamodel.spi.MappingMetamodelImplementor;
 import org.hibernate.metamodel.spi.RuntimeModelCreationContext;
-import org.hibernate.query.sqm.function.SqmFunctionRegistry;
 import org.hibernate.sql.ast.SqlAstJoinType;
 import org.hibernate.sql.ast.tree.from.NamedTableReference;
 import org.hibernate.sql.ast.tree.from.TableGroup;
@@ -164,7 +163,6 @@ public JoinedSubclassEntityPersister(
 		super( persistentClass, cacheAccessStrategy, naturalIdRegionAccessStrategy, creationContext );
 
 		final Dialect dialect = creationContext.getDialect();
-		final SqmFunctionRegistry functionRegistry = creationContext.getFunctionRegistry();
 		final TypeConfiguration typeConfiguration = creationContext.getTypeConfiguration();
 		final BasicTypeRegistry basicTypeRegistry = typeConfiguration.getBasicTypeRegistry();
 
@@ -237,7 +235,7 @@ public JoinedSubclassEntityPersister(
 				final Column column = columns.get(k);
 				keyCols[k] = column.getQuotedName( dialect );
 				keyColReaders[k] = column.getReadExpr( dialect );
-				keyColReaderTemplates[k] = column.getTemplate( dialect, typeConfiguration, functionRegistry );
+				keyColReaderTemplates[k] = column.getTemplate( dialect, typeConfiguration );
 			}
 			keyColumns.add( keyCols );
 			keyColumnReaders.add( keyColReaders );
@@ -273,7 +271,7 @@ public JoinedSubclassEntityPersister(
 				final Column column = columns.get(k);
 				keyCols[k] = column.getQuotedName( dialect );
 				keyColReaders[k] = column.getReadExpr( dialect );
-				keyColReaderTemplates[k] = column.getTemplate( dialect, typeConfiguration, functionRegistry );
+				keyColReaderTemplates[k] = column.getTemplate( dialect, typeConfiguration );
 			}
 			keyColumns.add( keyCols );
 			keyColumnReaders.add( keyColReaders );
diff --git a/hibernate-core/src/main/java/org/hibernate/persister/entity/SingleTableEntityPersister.java b/hibernate-core/src/main/java/org/hibernate/persister/entity/SingleTableEntityPersister.java

Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,6 @@`
`9`	`9`
`10`	`10`	`import org.hibernate.dialect.Dialect;`
`11`	`11`	`import org.hibernate.loader.internal.AliasConstantsHelper;`
`12`		`-import org.hibernate.query.sqm.function.SqmFunctionRegistry;`
`13`	`12`	`import org.hibernate.type.spi.TypeConfiguration;`
`14`	`13`
`15`	`14`	`import static org.hibernate.internal.util.StringHelper.replace;`
`@@ -40,7 +39,7 @@ public Formula(String formula) {`
`40`	`39`	`}`
`41`	`40`
`42`	`41`	`@Override`
`43`		`- public String getTemplate(Dialect dialect, TypeConfiguration typeConfiguration, SqmFunctionRegistry registry) {`
	`42`	`+ public String getTemplate(Dialect dialect, TypeConfiguration typeConfiguration) {`
`44`	`43`	`final String template = renderWhereStringTemplate( formula, dialect, typeConfiguration );`
`45`	`44`	`return safeInterning( replace( template, "{alias}", TEMPLATE ) );`
`46`	`45`	`}`
Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,10 @@ public IdentifierCollection(MetadataBuildingContext buildingContext, PersistentC`
`26`	`26`	`super( buildingContext, owner );`
`27`	`27`	`}`
`28`	`28`
`29`		`- public IdentifierCollection(Supplier<ManagedBean<? extends UserCollectionType>> customTypeBeanResolver, PersistentClass owner, MetadataBuildingContext buildingContext) {`
	`29`	`+ public IdentifierCollection(`
	`30`	`+ Supplier<ManagedBean<? extends UserCollectionType>> customTypeBeanResolver,`
	`31`	`+ PersistentClass owner,`
	`32`	`+ MetadataBuildingContext buildingContext) {`
`30`	`33`	`super( customTypeBeanResolver, owner, buildingContext );`
`31`	`34`	`}`
`32`	`35`
`@@ -38,22 +41,24 @@ protected IdentifierCollection(IdentifierCollection original) {`
`38`	`41`	`public KeyValue getIdentifier() {`
`39`	`42`	`return identifier;`
`40`	`43`	`}`
	`44`	`+`
`41`	`45`	`public void setIdentifier(KeyValue identifier) {`
`42`	`46`	`this.identifier = identifier;`
`43`	`47`	`}`
	`48`	`+`
`44`	`49`	`public final boolean isIdentified() {`
`45`	`50`	`return true;`
`46`	`51`	`}`
`47`	`52`
`48`	`53`	`@Override`
`49`	`54`	`public boolean isSame(Collection other) {`
`50`	`55`	`return other instanceof IdentifierCollection`
`51`		`- && isSame( (IdentifierCollection) other );`
	`56`	`+ && isSame( (IdentifierCollection) other );`
`52`	`57`	`}`
`53`	`58`
`54`	`59`	`public boolean isSame(IdentifierCollection other) {`
`55`	`60`	`return super.isSame( other )`
`56`		`- && isSame( identifier, other.identifier );`
	`61`	`+ && isSame( identifier, other.identifier );`
`57`	`62`	`}`
`58`	`63`
`59`	`64`	`void createPrimaryKey() {`