HHH-19314 StackOverflowException when using onConflict with createCriteriaInsertValues and createCriteriaInsertSelect

Author: dreab8

hibernate-core/src/main/java/org/hibernate/query/sqm/tree/insert/AbstractSqmInsertStatement.java

@@ -71,6 +71,10 @@ protected List<SqmPath<?>> copyInsertionTargetPaths(SqmCopyContext context) {
 		}
 	}
 
+	void setConflictClause(SqmConflictClause<T> conflictClause) {
+		this.conflictClause = conflictClause;
+	}
+
 	protected void verifyInsertTypesMatch(
 			List<SqmPath<?>> insertionTargetPaths,
 			List<? extends SqmTypedNode<?>> expressions) {

hibernate-core/src/main/java/org/hibernate/query/sqm/tree/insert/SqmConflictClause.java

@@ -52,7 +52,7 @@ private SqmConflictClause(
 		this.insertStatement = insertStatement;
 		this.excludedRoot = excludedRoot;
 		this.constraintName = constraintName;
-		this.constraintPaths = Collections.unmodifiableList( constraintPaths );
+		this.constraintPaths = constraintPaths == null ? null : Collections.unmodifiableList( constraintPaths );
 		this.updateAction = updateAction;
 	}
 
@@ -155,7 +155,7 @@ public SqmConflictClause<T> copy(SqmCopyContext context) {
 						insertStatement.copy( context ),
 						excludedRoot.copy( context ),
 						constraintName,
-						copyOf( constraintPaths, context ),
+						constraintPaths == null ? null : copyOf( constraintPaths, context ),
 						updateAction == null ? null : updateAction.copy( context )
 				)
 		);

hibernate-core/src/main/java/org/hibernate/query/sqm/tree/insert/SqmInsertSelectStatement.java

@@ -81,19 +81,26 @@ public SqmInsertSelectStatement<T> copy(SqmCopyContext context) {
 		if ( existing != null ) {
 			return existing;
 		}
-		return context.registerCopy(
-				this,
-				new SqmInsertSelectStatement<>(
-						nodeBuilder(),
-						context.getQuerySource() == null ? getQuerySource() : context.getQuerySource(),
-						copyParameters( context ),
-						copyCteStatements( context ),
-						getTarget().copy( context ),
-						copyInsertionTargetPaths( context ),
-						getConflictClause() == null ? null : getConflictClause().copy( context ),
-						selectQueryPart.copy( context )
-				)
+		final SqmInsertSelectStatement<T> sqmInsertSelectStatementCopy = new SqmInsertSelectStatement<>(
+				nodeBuilder(),
+				context.getQuerySource() == null ? getQuerySource() : context.getQuerySource(),
+				copyParameters( context ),
+				copyCteStatements( context ),
+				getTarget().copy( context ),
+				null,
+				null,
+				selectQueryPart.copy( context )
 		);
+
+		context.registerCopy( this, sqmInsertSelectStatementCopy );
+
+		sqmInsertSelectStatementCopy.setInsertionTargetPaths( copyInsertionTargetPaths( context ) );
+
+		if ( getConflictClause() != null ) {
+			sqmInsertSelectStatementCopy.setConflictClause( getConflictClause().copy( context ) );
+		}
+
+		return sqmInsertSelectStatementCopy;
 	}
 
 	@Override

hibernate-core/src/main/java/org/hibernate/query/sqm/tree/insert/SqmInsertValuesStatement.java

@@ -86,7 +86,8 @@ public SqmInsertValuesStatement<T> copy(SqmCopyContext context) {
 				valuesList.add( sqmValues.copy( context ) );
 			}
 		}
-		return context.registerCopy(
+
+		final SqmInsertValuesStatement<T> sqmInsertValuesStatementCopy = context.registerCopy(
 				this,
 				new SqmInsertValuesStatement<>(
 						nodeBuilder(),
@@ -95,10 +96,16 @@ public SqmInsertValuesStatement<T> copy(SqmCopyContext context) {
 						copyCteStatements( context ),
 						getTarget().copy( context ),
 						copyInsertionTargetPaths( context ),
-						getConflictClause() == null ? null : getConflictClause().copy( context ),
+						null,
 						valuesList
 				)
 		);
+
+		if ( getConflictClause() != null ) {
+			sqmInsertValuesStatementCopy.setConflictClause( getConflictClause().copy( context ) );
+		}
+
+		return sqmInsertValuesStatementCopy;
 	}
 
 	public SqmInsertValuesStatement<T> copyWithoutValues(SqmCopyContext context) {